From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59946C369D9 for ; Wed, 30 Apr 2025 10:09:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 548296B00C0; Wed, 30 Apr 2025 06:09:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F6286B00C1; Wed, 30 Apr 2025 06:09:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 397876B00C2; Wed, 30 Apr 2025 06:09:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 135F26B00C0 for ; Wed, 30 Apr 2025 06:09:23 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 41A3CC7B86 for ; Wed, 30 Apr 2025 10:09:24 +0000 (UTC) X-FDA: 83390287848.27.C32617F Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by imf30.hostedemail.com (Postfix) with ESMTP id 364C980005 for ; Wed, 30 Apr 2025 10:09:21 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=mVEDHGIr; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf30.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.132 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746007762; a=rsa-sha256; cv=none; b=Mz2lVFSk+RvPyWEdFEoSidzglxbCU5CbuvsFoHLjZBKxW2kln57hi0CfLCqwhd6qqOFzRw RUtJnZoGjWGmixgsOnQJymdFTG7whbfmzQGiSpQ/i+TtiaGUZ5b+O6c1HA+X1jGTDwUm6V xnIprpOVixCkYWZ+jm/CKaAYp9mdBU0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=mVEDHGIr; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf30.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.132 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746007762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4nwQzxilbFOqh5VEZWNSx+cKoBVCmfBTfSB2Il9HUho=; b=sTxuXDPaNMid7IV7WxzER5U1AG/U+SewOBV8pHB+HTuNznNTqMOgXzr2ICNq0Z6Aq4/yOB Da189unAW1UHsIOHJtC6yK+txpqPwTiqnM8vh1eCjppoSuAa9EbnU9A9ycXo+OowGWD+yL HfK2kx1M42A8GB4JZWkWB26/GyK+jno= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1746007759; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=4nwQzxilbFOqh5VEZWNSx+cKoBVCmfBTfSB2Il9HUho=; b=mVEDHGIrZ14bJcoMUIWJyVKSNxCI3cFqNl5UFhDz8yM6E5k+JEthmKh2E9DWchI2iz2Ej84dErrFJHX6aF7bvDvffyCSOmV867rTl3KZihSL9YZYNbaSUI4By7drCaXJ10mMzvOWlNQ2sghVdDvS26KnXflMRtlgd1RSOrk5gMs= Received: from 30.74.146.9(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WYoKPvm_1746007756 cluster:ay36) by smtp.aliyun-inc.com; Wed, 30 Apr 2025 18:09:17 +0800 Message-ID: <140d91bc-13cb-46c4-a6bc-0cbd8d329cdc@linux.alibaba.com> Date: Wed, 30 Apr 2025 18:09:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 08/12] khugepaged: skip collapsing mTHP to smaller orders To: Nico Pache , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, david@redhat.com, baohua@kernel.org, ryan.roberts@arm.com, willy@infradead.org, peterx@redhat.com, ziy@nvidia.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, dev.jain@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com References: <20250428181218.85925-1-npache@redhat.com> <20250428181218.85925-9-npache@redhat.com> From: Baolin Wang In-Reply-To: <20250428181218.85925-9-npache@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 364C980005 X-Rspamd-Server: rspam04 X-Stat-Signature: p5ed6fk5jj1yqwbsgw8jeyszzxn6n8hc X-HE-Tag: 1746007761-536138 X-HE-Meta: U2FsdGVkX1+DB5GrDcJaD/tWupEyief01pTv75IgUjy1MerFwp8UsmZnVsPmBdsgeGXreugLkX/0XIHflvZlp3E0tb7dQ6ZjAiDiWvz604OXx84QL571y0YWZ32twTs6xjXJHB4R1s32fAJllhcCO3TmuUtwImwSIt2m19ahQpb/iDXI6YAa/Ion/6wP+ESLDC2JkKkhkuUHhpIQf3J7MRbdUxjy9sVTOWj624C27Mnp1tybrHfqu3djtoewA20Rcb+dk8GmCj60BS4hqk1SFH2YqyHBu/gzVvGlqyw7LWSEo+h8YYq7K97JzQamrxZ8lUcqRiX+0Kax0uuqjOb3V21RCGHCDaFlPX7kXf3X6NJxeAuE2nmYe489nVeEDvy1pGQoGgCYiLYhFWYpLH7gHIcaApGkutivbn4yYWKfUW5dg1nWy80rneZYVyp6RuHlMq7/Y2A7jlQiFbV3sKWWLo5gOwaYHZxHGb/dqXi/SR+zgsW+LG4GEAapcmw7j3W/GOlBjDisxlL63kmllRg91E6nZ4SeblflB7UYL8WWO1xG8wJeVgA7C2zz4IX6Gv+pRRp7iSqMlU3MRs4mYuduJQL2w/rl2xBHthQLybvXeUgszDS0vbIlZxe1c+dl8j7ACxTR/bbOWIQeFe1RT5MJ22MoXH+ZVkwECMfeQMVvj754SolY0dOnY10/hmfPC5ubdRkyxc5JAq0bOgLlvCHPBcg/jhxvsO7RtVfBFdc48cjh+9msSEMPkpO9vmfbSdr/NnbZRLnNO2/kLYkg1ihtHR1t6iZqBDtm+N7A9MjAmCEzIn27VP/flxuGwsyL5dJkFsMfE4tBFnpuYh3IkWiwyArjENLeIvR1uqrmFZpj/uJHGbuXF/g11PyjANsfsquwyjQTI4PPEJpEC4pxt30V4OeYt784VALfxMfiQjrQOrDS7Q77cdDBcLyvzvnQMQXSXX1y2eULdO1gzc1ttMl tKCShAzK kguXm1B/SAumMen5lcAch4l/72ObF/67xzMkZ2rTDCFCnM7SXQyGUpTQgSITWHLtcM6ODHMe5hjPdJW0F5GCIShcjanCIE/tszP7Ao9U3iX/nux9pjJRLzl/86FG2+0s9yuFBnWzoXTDr0hel2J0ZZimeyyt5ek5/S24vCPP4xYgtybZrD9B0MrAK7g7Jk8dj/0hW+mO8a1ONMuK9/dnohhZccjtO8FTAGarm8Glmz8NoGaTmzDhFvDndH99x0nP/M53lyXdEDKzwNTEK6GEyouG71UqoMnEUS9R2nud4PEZHPdMWzmB7zlpJAE9OWwogDCPt2jI94UWGQv3KkrOkJ5dW2Ddme+YDXxNN79Bcw6HuZFDkjk3Fx4bo6Jt2I4hKZ6Qry0Y5tr0rCM/Sx/Bf4qRdDGiSDGRtn/F1psfUBP3bfvNiIFSigoUdqB1AMVw4RoKH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/4/29 02:12, Nico Pache wrote: > khugepaged may try to collapse a mTHP to a smaller mTHP, resulting in > some pages being unmapped. Skip these cases until we have a way to check > if its ok to collapse to a smaller mTHP size (like in the case of a > partially mapped folio). > > This patch is inspired by Dev Jain's work on khugepaged mTHP support [1]. > > [1] https://lore.kernel.org/lkml/20241216165105.56185-11-dev.jain@arm.com/ > > Co-developed-by: Dev Jain > Signed-off-by: Dev Jain > Signed-off-by: Nico Pache LGTM. Reviewed-by: Baolin Wang