From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94199C4345F for ; Wed, 24 Apr 2024 07:11:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BB2C6B0248; Wed, 24 Apr 2024 03:11:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0698B6B0249; Wed, 24 Apr 2024 03:11:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4B596B024A; Wed, 24 Apr 2024 03:11:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C74106B0248 for ; Wed, 24 Apr 2024 03:11:57 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 31DDAA1996 for ; Wed, 24 Apr 2024 07:11:57 +0000 (UTC) X-FDA: 82043555874.07.0F805D8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id E264B4000E for ; Wed, 24 Apr 2024 07:11:54 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ScqHD1Cb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713942715; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4gidzFVBqoRHAUEwIxjlBCREzviKDY/DnMV8t7zCI8g=; b=ikKvivz9AFij6SeCka/u0qW/3Zxg42/Fks1lKWtdbX2nOWdJS/PEiX2SK/RCCrh1svTIW1 9dII0excuPP8XVeJjdhQgCsPPVOJvtUxzb4jLsoWPa5aVrKCocvpXGQNdqla2Wh9AXDChG ec2PsOTBJWDx/8Z/VogpH4bYs7nJ6TU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ScqHD1Cb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713942715; a=rsa-sha256; cv=none; b=YsO38gUy/HBE3eZb4HF/v1PnrXbh0UwqI52yXIfeWntC0/Z8pYOwOkSDmSjvmjsM5ciM07 bbG4tpE3n8bWb+Joxuj6JQWKG4cSYZmYT0u+15Cf2X25/bJ51ZJN35+gOCgS7yLdtCO8Zt W7D82kk1dcVNq9KueDKFqTqVD5Zyi94= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713942714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4gidzFVBqoRHAUEwIxjlBCREzviKDY/DnMV8t7zCI8g=; b=ScqHD1Cb4mm5n+bR9cNUnRIyPIjSl0zZgEUbT+APzHYZaBkR45x8TLk5oPKtMRhmpRdyti Ps3z9AX/KG/kNnOwEgbRjTYfz/NP6kWi70mlCi+ipH5AdNN/3CBskeugX2/d9ZnbfNMkYE OI1doWB+pxOS/E4/NkMllb3IhBqO4rE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-Sn_kFV1iOjq_FW_kd3ypUg-1; Wed, 24 Apr 2024 03:11:52 -0400 X-MC-Unique: Sn_kFV1iOjq_FW_kd3ypUg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-41a1eb33994so14686565e9.1 for ; Wed, 24 Apr 2024 00:11:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713942711; x=1714547511; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4gidzFVBqoRHAUEwIxjlBCREzviKDY/DnMV8t7zCI8g=; b=YTInHz2gQPVSpmxbeKX56J7EZChdCynaAuZJwgnhN2KkkCs6NttYws/R0iXAp3dqt6 8YtRdjIhF1yM9En3ut1//KPQ3kozvoeFgBL9luBWH8Cpsi2P/riy+IFvcBevsCyqRqOO D8uFzpuT5phpm70RycJRQSi1yqoboRUwKU4hHFRmZAKaZfPSSBfq/B3zKI8nMFkY3gcH nDk6Jd7/IJpz9ifO3ep30gasQ1ETFeF3wsRuyJzAR8De7muNEz3yAopai1aIPysvORsX BovruvFClfyHp5lZFvk2j3ULOJYT/XWav4/o0cqpyoSbLf5dVret3nxY2eg1iZutD91q ATCg== X-Forwarded-Encrypted: i=1; AJvYcCUQtW7+Hjc1ZQWeuY2iFLCSADqhJH2h1wtMR9xeI/fMtmuQdSih67/qUN+pd5LX0q3npYR1QeofCMBvIcCIxF8gDRc= X-Gm-Message-State: AOJu0Yw8brSTvQlfZ6EKXYCkwyfoyTqdZNxqFUPh8A8DLeuXsbJmx5h1 POY8Sp4wMugea+LPo2FYzBMbjMvjcjaUMuJBLvPwb4GnbW6YyPQlAjYbwU3Olfu6adaMQmLJGjM /CBmjWb52TnDuvWv9G5zVmf0EM+9UC6a7WSAgi5uXkL5RwysZ X-Received: by 2002:a05:600c:46c8:b0:414:d95:cc47 with SMTP id q8-20020a05600c46c800b004140d95cc47mr1502577wmo.30.1713942711015; Wed, 24 Apr 2024 00:11:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEW/6OMvqQ+A7LtzwxtNbMauk6g/P1+vTSYce+cNLQBIpUr+Rxj27VOKM/pu+RBYDoSHTyrbw== X-Received: by 2002:a05:600c:46c8:b0:414:d95:cc47 with SMTP id q8-20020a05600c46c800b004140d95cc47mr1502550wmo.30.1713942710594; Wed, 24 Apr 2024 00:11:50 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:1f00:7a4e:8f21:98db:baef? (p200300cbc70d1f007a4e8f2198dbbaef.dip0.t-ipconnect.de. [2003:cb:c70d:1f00:7a4e:8f21:98db:baef]) by smtp.gmail.com with ESMTPSA id je12-20020a05600c1f8c00b004183edc31adsm26418482wmb.44.2024.04.24.00.11.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 00:11:50 -0700 (PDT) Message-ID: <140d4efa-28a0-449a-9570-9d44c23b55d1@redhat.com> Date: Wed, 24 Apr 2024 09:11:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 5/5] mm: shmem: add anonymous share mTHP counters To: Baolin Wang , Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, hughd@google.com, willy@infradead.org, wangkefeng.wang@huawei.com, ryan.roberts@arm.com, ying.huang@intel.com, shy828301@gmail.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <05d0096e4ec3e572d1d52d33a31a661321ac1551.1713755580.git.baolin.wang@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E264B4000E X-Stat-Signature: kwr3q5axospf5b3sdc1fqw8i1c9daz18 X-HE-Tag: 1713942714-814613 X-HE-Meta: U2FsdGVkX183ijAJvLf/A/nXT1yfGb+198ehIFbh+XGWKnEMx3Fa4r+/HhI9q+iQmh+1RPLjqXV8QqVVyyb68jsq0g4wrHl3tQ4jdtHsm0aNGfYieqwaC/YzZb4PzntGNtZtuPig3weYj6OMVzY2k9DWKiHC8nmE6qjbFzzWNMyWa4qywSG03U5QVbxajwR+96TjP6NwnYddO6yYFS7VwrwCC+UqvMZXzRpFQU6jPHSxbXVv5HH+jdALnrFk14zPRC4KPy8N58BSK6j4NAzeP7JjMnqV4fLkEar/sLud08D1IwKtH4yk1aAN2Fh0NRxOVutDLxrvrhQZ+YK2I9HGlTF4/gOOxsFGb0ll1FkyuYErSIX/GpwDgOwTDalofgChdeUzqKQP4gRWwtVt1zaa7T+Fr/ch08HrCnxvN/oSPIGvDXq1nOa2xCSOAEpXZex1CzNhpLWxWfvyYU8eBIrwMbpU4ONBY3NP1UdtpJUlwBS69CJNrIq4b9k1yFpCcbx6zuCOsQwo8FDCCyF4pTDesgcz4RiQ8z4MsdtZYRkp62fCUwTaFsEGSH0X4Dv6BKXNQw7RWOLuVKWowU4Qyjruy5ROSenp6g9nHb+YOSpeub59sha88k6ng82EBpwuO+7TFA2j83Fhnf+bhT6XEsHMf5qWz9nV5JHtWLEyMHm+Wpzy+zwD7C4U4fAXrPkIB8f8L5fPiUZXzpM8/0CsQpj6Ci2li9iacjehgOm1C45fWBL3R66CZGVamJb9V1s+xyofGtzX548Jk1LJuMoJvNgi2YysQdH5ygRgae7P21YqXwLQjhuxu7L6nIUzJJX0FNz0vsNjmvgiN64ttREayndp12l4UhaI5FQtqJDbgD7HZ+W5PgC/RfS+LLROUyCZxh8bNTr4/m5zN5w3kw6gEFo3yuulmvtHI15pviFZfzTKAonGsuDNROXWKmgFc/gXnX4IZGcReedb+WK6JdWtC7E /WnYYOnM enm5vNtuamr7knPuNPbcnXtNLqs3YLLLZHdU6VjNDrzeozKzws2CfuNp3t/ENTgKUwECPu2frmVm9NbGF4pMJSCDhCPAaD5caTKQiLIFtcho9CYqmWZRo+BudbLZa7FMdeAzfCwufrS6qYm/ySEnMmpOnarb+fZ3AWXTjy4xlP3krdRvTYSnKutMIjm4eLVOntXYABwpv1NZauwq52nd1D2Fa8t1ts1j6CksO3cr409tkjffRd2Rrrp7MdxQXFjEbEeX9zSl/+mgTOnnDkcNjspMm5VfRFZOO5VAohZQAW1dG3New3ML6ulcm/NcatK6P/hjnGdwxAC3x+S/pmNstZxmN6JzpJRG6XT3PFwHIFCRv28jRDT/6WWXIEW8ECZs9QDjE9O/H+/yjpVhFIPMepHZg5svico1T1TBcnsVEqWodZglMH/QffNcuRbMs32ut25ZemsPz8I5ZoWRdzn93oat8xY5tUQBabW0V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.04.24 08:10, Baolin Wang wrote: > > > On 2024/4/23 19:37, David Hildenbrand wrote: >> On 23.04.24 03:17, Barry Song wrote: >>> On Mon, Apr 22, 2024 at 3:03 PM Baolin Wang >>> wrote: >>>> >>>> Signed-off-by: Baolin Wang >>>> --- >>>>   include/linux/huge_mm.h | 2 ++ >>>>   mm/huge_memory.c        | 4 ++++ >>>>   mm/shmem.c              | 5 ++++- >>>>   3 files changed, 10 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >>>> index 26b6fa98d8ac..67b9c1acad31 100644 >>>> --- a/include/linux/huge_mm.h >>>> +++ b/include/linux/huge_mm.h >>>> @@ -270,6 +270,8 @@ enum mthp_stat_item { >>>>          MTHP_STAT_ANON_SWPOUT, >>>>          MTHP_STAT_ANON_SWPOUT_FALLBACK, >>>>          MTHP_STAT_ANON_SWPIN_REFAULT, >>>> +       MTHP_STAT_SHMEM_ANON_ALLOC, >>>> +       MTHP_STAT_SHMEM_ANON_ALLOC_FALLBACK, >>> >>> not quite sure about this. for 2MB pmd-mapped THP shmem, we count them >>> as FILE_THP. >>> here we are counting as SHMEM_ANON. To me, SHMEM_ANON is more correct but >>> it doesn't align with pmd-mapped THP. David, Ryan, what do you think? >> >> The term "anonymous share" in the patch subject is weird to begin with >> ;) Easy to confuse with anonymous cow-shared memory. Let's just call it >> "anonymous shmem", which it is under the hood. > > Sure. > >> ... regarding the question: if we add FILE_ALLOC and friends, at least >> initially, we wouldn't account other large pagecache folios. >> >> ... likely we should add that then as well so the counter matches the >> actual name? >> >> If we later realize that we need separate FILE vs. SHMEM vs. WHATEVER >> counters, we can always add more fine-grained counters later. Doing it >> consistently w.r.t. traditional THPs first sounds reasonable. > > Um, once we expose it to userspace through the sysfs interface, the > sysfs interface should be explicit as much as possible and avoid > confusing users, otherwise it will be difficult to change this kind of > interface in the future. Personally, I prefer to Ryan's suggestion. Inconsistency is confusing. As long as you avoid that, I don't particularly care. -- Cheers, David / dhildenb