From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8671DE77188 for ; Fri, 3 Jan 2025 05:25:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2E526B007B; Fri, 3 Jan 2025 00:25:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB7936B0082; Fri, 3 Jan 2025 00:25:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 909B26B0083; Fri, 3 Jan 2025 00:25:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6DF466B007B for ; Fri, 3 Jan 2025 00:25:08 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CC572A03B9 for ; Fri, 3 Jan 2025 05:25:07 +0000 (UTC) X-FDA: 82965000888.04.08F4F7B Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf28.hostedemail.com (Postfix) with ESMTP id E115EC0009 for ; Fri, 3 Jan 2025 05:24:10 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=daynix-com.20230601.gappssmtp.com header.s=20230601 header.b=sMwrTzvF; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akihiko.odaki@daynix.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=akihiko.odaki@daynix.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735881882; a=rsa-sha256; cv=none; b=xkylIrdlQsuIdVvEvnPMK3d9LldccJI38AeAOTQma8uoGkyd7SrglxlOUom4LvVxfyf0Ht rNfFOE9erERO07eLyt6ChilUkGjtbSwCE6vXYJS9EEdJyjQmtqxXs2HWnxLbm6oQRzZmz6 b4e41L+l6+pQgw1L+MJK9UtunT+vEaY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=daynix-com.20230601.gappssmtp.com header.s=20230601 header.b=sMwrTzvF; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akihiko.odaki@daynix.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=akihiko.odaki@daynix.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735881882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2SLe5jS4i20cAa31nleBBSUYQvSD4WD61FneFXlk2DY=; b=PTkRc1H+nvZlQNvxEAOQ0ZXCmWri5cPGNQcF221W6/hIyXzrYYsMuaiIsumONLCATUoMVD v8YKlUBGaToqjGLEX4lseC1fk6gqJLnDD2raZ4MuupaQ/uFlwqJn/inh05JXbSnHfTEb6i aO8jL7F7c23eEok/q26MoZEWAMcy5UI= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-215770613dbso121873295ad.2 for ; Thu, 02 Jan 2025 21:25:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1735881904; x=1736486704; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2SLe5jS4i20cAa31nleBBSUYQvSD4WD61FneFXlk2DY=; b=sMwrTzvFg35u68FBhAMBlqYLlV0A5dCL/q8akJnFNZ2RAr+1U6UJwjuPjxHoKzU+/x /9J7w9di8NHuf96upYxWLPS69TQ5HcgKh6g2Kd0cWnGDqJg3LqB6Nz9zGV38miWx0j0y h6BSBqHSxks92T7bpubUYbPj/dM1ECnGDZHPrn3RR2OD71MZXGxmWHIObQUx0Qmc3tog 7JnzcMzAzCPLO60JphteN5kjyB0WNJ1v9U/EQdQjv41DyKB/2rNxr4xUk4Exj3g0/rxy 4b9VGpf46kIp9JPDuD1OgDBL4aDock6ysDJCf7l7nAMaMQ+hoGKyDNCY/jwrnEgWBDKt Gp4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735881904; x=1736486704; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2SLe5jS4i20cAa31nleBBSUYQvSD4WD61FneFXlk2DY=; b=OscDQkL88dTrDSNCqRCldU8YXdxnT3dwthIgwT2km6YXhGHpmbYix+fTP7msv/Yu7L 5PdFOeNSg/cRKLrUlWccxn2WZ/ONqnnI4Vb7wWTp1DGmNDYitKF74pQH9x3MAA4lMVnf /g0aguGt/TJBfsXX/9PFdCaT27kQ3RF0fdfWVqN9zKx++Z7Qu/Nl0AtAN+xE8Uy+I6qT B9xKOS61/tbl6rBZXnHpKvXkJj8oVkE8rngp8H6tUmxrjMciZ3iYUEiJNtNMjjFRvz4f pN5O9b4qFLlk+ITsRzdX5/QlD0L+QA/cHVlKOgInQOraNwrS7TfON/CEyg0p8z71VmpD mOpw== X-Forwarded-Encrypted: i=1; AJvYcCX1IKIvoszBF4hrzVPt6dKeFeLU5luZNuWeHPx9xwBpilJYn6QFzNuPw2d47WQ02r0MDN9m1dAPGQ==@kvack.org X-Gm-Message-State: AOJu0YwOvmIfzuObu41kiB1FxTSf3hnFB3R/7HBpgyY0ZpUTpjTLUsU4 oajjE2rvnlc1gRUK89vmEXAf1QpEyy5vpwP+ZR9MUkn4Txct5GH+AzNyuuT5KVA= X-Gm-Gg: ASbGncuDJyl2juBKXSROzySafbDGg+Nrof4iDBkf/JcSdAsvYPSyPXZWfNr183MHhTo BVUtdEQGMmhDNDlK37x2skAyIrikHKmgyrV9Rl/afRRVmyi5HtZy5lpwY4P3h6fwEgQ9njwyCls BDpoQOcAarS0MIPC3I55Q5jZnMaAPKXox2fnkZE+s8J7nMAVteS57ry4R6XUSNbX2F5W6fq/6ld WAsW7XAlvG/jOGRrc9zPfglLYHjF4nHF7xUNeq+gFGpwuNW+ToIReHEgCI/ECgqTPrxPg== X-Google-Smtp-Source: AGHT+IEXvVyokP5/bTyNDUw22/wFmib5/IQCXZZQCrRkdaq441l+w5hOtOD0MdqFjzgfs4vUcoDCew== X-Received: by 2002:a17:902:c40e:b0:216:2dc5:233c with SMTP id d9443c01a7336-219e6f0e6e2mr660593875ad.41.1735881904299; Thu, 02 Jan 2025 21:25:04 -0800 (PST) Received: from [157.82.207.107] ([157.82.207.107]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f4477ec3acsm30266189a91.25.2025.01.02.21.25.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2025 21:25:03 -0800 (PST) Message-ID: <140d4869-3578-43e4-975f-f52b46711aaa@daynix.com> Date: Fri, 3 Jan 2025 14:25:00 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] elf: Correct note name comment To: Dave Martin Cc: Eric Biederman , Kees Cook , Catalin Marinas , Mark Brown , linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@daynix.com References: <20241225-elf-v1-1-79e940350d50@daynix.com> Content-Language: en-US From: Akihiko Odaki In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E115EC0009 X-Stat-Signature: z7dpgh7r6e3okn4zio3f79st9tzndkam X-HE-Tag: 1735881850-636518 X-HE-Meta: U2FsdGVkX1872wNxCmgfNuuJikIIC2pXq28VDaOVwTRPZFY0aLVDCzUXw3MX5gs7/KlJy4NqWE5mpcWEZXNui+MtLoxGX0ZA+H3KGJ7CVYim8bh+xLxNKVbaGjLIZsGpYoXmfZ3+lx0xS0CRj8A8hzrdJzMvixbIzizJNyWi7wDmYRH1c05p/ORThasYI+wqUZH2mvVEpDBQ3JrsJoIzl5dC5UaxJ/64w9ej3l9NtL6EBizrzbIdiaWiF4Mq38GJrYWfu1fk0zkIoSZ1XxhZzh+EnVtjetASQ59DXqhb+v7XXiD9msCOZf6aEExGmUXuBPtjFGnx7h0PD9gTaI1arej+wJfXpv8RHDtWnN4CdVYT/o4dT+I2ZGws6XX211xegkWkZGazWWYU0lORZGYHWTZGOJohv+dkoW7XMw2TNOvHS+FFBYY2IQCwterSCh+e5ZJKrLppeTJEpJzQFJxrOKO/bXMc0mYwzeuqMGsLqvlPIL3ZV8+zUbHbDWXEVPOK/KCKgITf/Yca+Gs0eWYZfioFmsanZl3pUERFhJRy2az65I6E20kMiWWIdcqMNFfXfFIE+zcHlotY8KOSUzydR7XmOBllgyhXVK8+OgCp0RQDfRA546c3W9Ik6MTyHKp4ykr9KJL9Un/WcHYtBxNpdYUXVefRiYWSPCWsiGs1p4zEOBbtV7ETaLsJ2rdMml4HtdU0Ptn0APpGT6sKHydz+tZ/8oteLBfK82bB2gUhNcssr540nQPKhpwH2mC/pBuG4tVsq1W6DM5bJ85aulsf2LYLpZorRDD3AMNVDotK+PBoGf8jwLQ0cn88pAbZ/MZmcI7ybPeN9X35OnvOuE2n77X8Z4eOehVZQdrhoIrfcMXH1mxknIpywVvKqB8IM9Hv212gPc6lhK/7hvvyJJdRrYAsjwNYssLASIjUGDHlKvoQGmrAI+/oNaCp7VWDGwAFliXrHhCr5femnHepCXn db2EWqJw 1abTYxfdhQ1e/aJjxZLhzfialDmO6m0Awgj/n89wJT4Xc6sRBjlifIc/kemv6w2KEkXtBVM5ZoAvB76y1KJBQylqRyCCe7HO7Rc3lR5nGzEyjQPH040hzuqt5h1tPmeHuvhNcErj4x5YCw10ol+eRrM5loFuysyhvOe2OgG2GJo/VvXPlDYceOEAT6sBCB2/priKclU9em5aYh52eNDvV4Gkqa7uwVTWnsk7hWthZ6KfVX/+yeIV5eTQnht/sLN2erRxA8YSoHQiSyy6mvsnK454ZlRFhV+X2EhrD1EfFtVQJ6VQqHh/uhPQyKLjxoYqgXviA4yXx1C0U12AyEF5/Ry/pDGkU8twhEaTZeIA+ucC4qrMMjSTTrMbBiIGZS+Wl56pqUkb9DyjjMbXnrPMxgl1pyRmd19s2bSIW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/01/02 23:40, Dave Martin wrote: > Hi, > > On Wed, Dec 25, 2024 at 03:46:44PM +0900, Akihiko Odaki wrote: >> NT_PRSTATUS note is also named "CORE". Correct the comment accordingly. >> >> Fixes: 00e19ceec80b ("ELF: Add ELF program property parsing support") >> Signed-off-by: Akihiko Odaki >> --- >> include/uapi/linux/elf.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/uapi/linux/elf.h b/include/uapi/linux/elf.h >> index b54b313bcf07..4f00cdca38b2 100644 >> --- a/include/uapi/linux/elf.h >> +++ b/include/uapi/linux/elf.h >> @@ -372,8 +372,8 @@ typedef struct elf64_shdr { >> * Notes used in ET_CORE. Architectures export some of the arch register sets >> * using the corresponding note types via the PTRACE_GETREGSET and >> * PTRACE_SETREGSET requests. >> - * The note name for these types is "LINUX", except NT_PRFPREG that is named >> - * "CORE". >> + * The note name for these types is "LINUX", except NT_PRSTATUS and NT_PRFPREG >> + * that are named "CORE". >> */ >> #define NT_PRSTATUS 1 >> #define NT_PRFPREG 2 > > [...] > > This still seems rather confusing. It's not clear which note types are > being referred to in "for these types". I think this statement was > supposed to refer only to the architectural regset notes. I'm not sure about the original intention, but this comment starts with "notes used in ET_CORE" so I think it should ideally describe all types used in ET_CORE. > > I guess "CORE" was for generic coredump notes goverened by common > specs, and LINUX was for Linux-specific stuff, but I suspect that this > distinction may have bitrotted. It looks like the ELF specs never > defined the core dump format, so the concept of non-OS-specific > coredump notes may not make much sense. > > The ELF specs _do_ explicitly say [1] that the note name must be taken > into account when identifying the type of a note, so the note name for > each kind if note should really be documented explicitly. > > Is it worth adding explicit #defines for the note name of each kind > of note, to make the ABI contract explicit? Maybe so. I don't have a particular idea how such #defines should be written though as I don't have actual code that may utilize them. Regards, Akihiko Odaki