Re: Re: [RFC][PATCH 1/14] memcg: unlimted root cgroup

[kamezawa.hiroyu@jp.fujitsu.com]

----- Original Message -----
>KAMEZAWA Hiroyuki wrote:
>> Make root cgroup of memory resource controller to have no limit.
>> 
>> By this, users cannot set limit to root group. This is for making root cgro
up
>> as a kind of trash-can.
>> 
>> For accounting pages which has no owner, which are created by force_empty,
>> we need some cgroup with no_limit. A patch for rewriting force_empty will
>> will follow this one.
>> 
>> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>> 
>> ---
>>  Documentation/controllers/memory.txt |    4 ++++
>>  mm/memcontrol.c                      |   12 ++++++++++++
>>  2 files changed, 16 insertions(+)
>> 
>> Index: mmtom-2.6.27-rc3+/mm/memcontrol.c
>> ===================================================================
>> --- mmtom-2.6.27-rc3+.orig/mm/memcontrol.c
>> +++ mmtom-2.6.27-rc3+/mm/memcontrol.c
>> @@ -133,6 +133,10 @@ struct mem_cgroup {
>>  	 * statistics.
>>  	 */
>>  	struct mem_cgroup_stat stat;
>> +	/*
>> +	 * special flags.
>> +	 */
>> +	int	no_limit;
>
>Is this a generic implementation to support no limits? If not, why not store 
the
>root memory controller pointer and see if someone is trying to set a limit on
 that?
>
Just because I designed this for supporting trash-box and changed my mind..
Sorry. If pointer comparison is better, I'll do that.

Thanks,
-Kame




--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>