Re: [PATCH 5/9 v2] SQUASHME: prd: Last fixes for partitions

[Ross Zwisler <ross.zwisler@linux.intel.com>]

On Tue, 2014-08-26 at 20:36 +0300, Boaz Harrosh wrote:
> Meanwhile without any explanations, these will come tomorrow, I'm attaching
> the most interesting bit which you have not seen before.
> 
> If you want you can inspect a preview of what's to come here:
> 	http://git.open-osd.org/gitweb.cgi?p=pmem.git;a=summary

Regarding the top patch "pmem: KISS, remove the all pmem_major registration",
I like that we're getting rid of lots of dead code.  The only issue I have is
that I'm pretty sure we aren't supposed to register our disks directly with a
major of BLOCK_EXT_MAJOR.  I think we still need to register our own major via
register_blkdev(), and use that.  I'm fine with getting rid of the module
parameter though, and always getting a major dynamically.

If you look at the other block devices that use the GENHD_FL_EXT_DEVT flag
(nvme, loop, md, etc.) they all register their own major.  You can't see this
major by doing 'ls -l' on the resulting devices in /dev, but you can see it by
looking at /proc/devices:

# ls -l /dev/pmem0
brw-rw---- 1 root disk 259, 0 Aug 26 12:37 /dev/pmem0

# grep pmem /proc/devices 
250 pmem

- Ross


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>