linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Jonathan Corbet <corbet@lwn.net>,
	Vlastimil Babka <vbabka@suse.cz>,
	David Rientjes <rientjes@google.com>,
	Christoph Lameter <cl@linux.com>
Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] mm, slab: add kerneldocs for common SLAB_ flags
Date: Wed, 9 Oct 2024 22:06:43 -0700	[thread overview]
Message-ID: <1406d498-84bf-49aa-9efd-6480ad618582@infradead.org> (raw)
In-Reply-To: <8b0c1bb9-4a9a-4f8e-87df-275994df739d@infradead.org>



On 10/9/24 3:02 PM, Randy Dunlap wrote:
> 
> 
> On 10/9/24 9:49 AM, Jonathan Corbet wrote:
>> Vlastimil Babka <vbabka@suse.cz> writes:
>>
>>> Thanks for the hints. I hope if we can agree that documenting the macros was
>>> intended to be supported, doesn't break the build (there are users already)
>>> and has only those minor rendering issues, it can be used?
>>
>> I'd totally forgotten that this was supposed to work.
>>
>> Yes it can be used... $WE just need to find a way to make it work
>> properly.
> 
> The code probably isn't expecting a macro on the right side. I'll take a look,
> but no promises.
> 
That would have been too simple.
I haven't found the problem yet. Ran out of time. Will continue on it tommorrow/Thursday.

>>
>> Every now and then I ponder rewriting kernel-doc in Rust, both to make
>> it more reasonable to modify and as a learning exercise.  But then I
>> come to my senses and go back to stuff that actually needs to get done.
> 
> That's a good way to lose helpers, although it might also gain you a few...
> 
> Yesh, I know, current is Perl.
> 

-- 
~Randy


  reply	other threads:[~2024-10-10  5:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 14:29 Vlastimil Babka
2024-10-09 15:08 ` Jonathan Corbet
2024-10-09 16:11   ` Vlastimil Babka
2024-10-09 16:49     ` Jonathan Corbet
2024-10-09 22:02       ` Randy Dunlap
2024-10-10  5:06         ` Randy Dunlap [this message]
2024-10-10 23:43           ` [partial fix] " Randy Dunlap
2024-10-10 23:54             ` Randy Dunlap
2024-10-11  3:07               ` Randy Dunlap
2024-10-11 22:16                 ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406d498-84bf-49aa-9efd-6480ad618582@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox