[PATCH] slab: fix the alias count(via sysfs) of slab cache

[PATCH] slab: fix the alias count(via sysfs) of slab cache

[Gu Zheng]

We mark some slabs(e.g. kmem_cache_node) as unmergeable via setting
refcount to -1, and their alias should be 0, not refcount-1, so correct
it here.

Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
---
 mm/slub.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index 7300480..ac1a20a 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -4509,7 +4509,7 @@ SLAB_ATTR_RO(ctor);
 
 static ssize_t aliases_show(struct kmem_cache *s, char *buf)
 {
-	return sprintf(buf, "%d\n", s->refcount - 1);
+	return sprintf(buf, "%d\n", s->refcount < 0 ? 0 : s->refcount - 1);
 }
 SLAB_ATTR_RO(aliases);
 
-- 
1.7.7

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] slab: fix the alias count(via sysfs) of slab cache

[David Rientjes]

On Wed, 23 Jul 2014, Gu Zheng wrote:

> We mark some slabs(e.g. kmem_cache_node) as unmergeable via setting
> refcount to -1, and their alias should be 0, not refcount-1, so correct
> it here.
> 
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>

Acked-by: David Rientjes <rientjes@google.com>

s/slabs/slab caches/

The two slab caches of interest are kmem_cache and kmem_cache_node.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>