From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E9D3C48BC3 for ; Mon, 19 Feb 2024 15:10:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 840856B0083; Mon, 19 Feb 2024 10:10:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C99C6B0085; Mon, 19 Feb 2024 10:10:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 643186B0087; Mon, 19 Feb 2024 10:10:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4EA976B0083 for ; Mon, 19 Feb 2024 10:10:58 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0342EA053D for ; Mon, 19 Feb 2024 15:10:57 +0000 (UTC) X-FDA: 81808890996.25.65C5C3B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 98B95100028 for ; Mon, 19 Feb 2024 15:10:54 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PHeFqz1Q; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708355454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KSqXWjK+LddXqIK8pJkcj8gOwnFmQLsFMFK0s1Et2YI=; b=HGWiaDGWFourSmkua4vLBOEc7TDUTybqeF2XMls+o60GOayGAXDdMyDawA2mDL739yy4KQ YzbbegbhT5AFr0m1OYvFSNkInirlSpNcyNI65j40USYvUsnbEGqq/m3RnYW6ZbKfPc4eDi XRDTaDYJCmXxI7Njw+NbrAIWlh3F6t0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PHeFqz1Q; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708355454; a=rsa-sha256; cv=none; b=SLGw5RHlbZ/1/Vlma/a+h+YA24K9QXhxahPFk/sf3NE5uGuaIuFnVL8SyFuBq/s5KpwKN4 ZMBfRp1B35tvMHSRTEiJkROO+AQ3IDvnPYyvTJnb95lIqEi4U2u4OhNP0DCCiQILqHxaUl 8TivNUsyL58XtY9oi6PzisxtRIe9458= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708355451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KSqXWjK+LddXqIK8pJkcj8gOwnFmQLsFMFK0s1Et2YI=; b=PHeFqz1QOKPIG+Cjl9/hzX5DZxxt6BpiPkRF7YpOCHdl9JS8Xe5W/GmWzr2CDqLXDBcqAF kWywxkQ9K4YELKCj67rDDgt4T5xgq6K0M96I08BH3Xn9wWAQPGvSRmR0/GhXMnCy7eCvHO Y9TuP3WfiDbKhRkFIxD5LejPTDPFQVs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-25-H-vk5ZXBOuiyEmjzhFTpBQ-1; Mon, 19 Feb 2024 10:10:48 -0500 X-MC-Unique: H-vk5ZXBOuiyEmjzhFTpBQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E7698881C87; Mon, 19 Feb 2024 15:10:46 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 014748077; Mon, 19 Feb 2024 15:10:44 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240209105947.GF1516992@kernel.org> References: <20240209105947.GF1516992@kernel.org> <20240205225726.3104808-1-dhowells@redhat.com> <20240205225726.3104808-10-dhowells@redhat.com> To: Simon Horman Cc: dhowells@redhat.com, Steve French , Jeff Layton , Matthew Wilcox , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Christian Brauner , netfs@lists.linux.dev, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Steve French , Shyam Prasad N , Rohith Surabattula Subject: Re: [PATCH v5 09/12] cifs: Cut over to using netfslib MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <140601.1708355444.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Mon, 19 Feb 2024 15:10:44 +0000 Message-ID: <140602.1708355444@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Rspamd-Queue-Id: 98B95100028 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: fuxfpmfzim63wd8htqsykq44txhbdz4h X-HE-Tag: 1708355454-439183 X-HE-Meta: U2FsdGVkX18IQuUs3Wt3pRGw6I7i0IMHf8lxOkQ25fnoQch090FzAnbWW+7Leu7yXn38B/zzXrum2ZISzzlUgZ/8bf9GevsD+PDS8lMxxMw2Rer1cnlaEwTW8GLvJN+OnQb+w9aLyh0KZyrf0HTczPsBREOv0Nlh+ckHGKdl982fAZ+JHjgZRRq+rGPcngFaQJtsVAA16pDyhrDLkwkN4HEqtOD7tRrj9VUZdUsE2WPc8Qmutw08RsIxBdpieHb3B8YWbeZzFlN3EwaZ9lZnxk9UDZ/8V1BxOAYmt56IWGP3u8eUz6CL/0UpWJ47tWS3/sGYb82Uy6QzXBmOpSHr9lrfWiDA+tRlY1q+6MFfwYf6pMm8pPamZNquVwo3mxCDpcN1zBHrwMBl3MrBQrW/dR1YwQ0rGDw4a5q18FMXmjJiuOn2w4ZaOtgVWWTZIlU3c0ccpBnGDJ9yH0KuNbZV5lwrDoBCjuglkOcUifP4M9/530yt3ni7GoMggZxI+oVF13efUjOxkPQSbWk0ckSUpaUqBXTijMqLJmhVm67SxKCqOEvEupG9VaHbu9ehIVBVlMqu5sTByls8rf8qHZoFoVi7IYpcJCKlkjyUj8qldY4t/HsC0HcUCLs0pW64GCPBCTCkA2vao0+Y2NUieGtxgRSO5GWOsbw94iCi1T91gqfhuwxTAVsJmceIyxfKH1417Z5+nQVDFK62mUUkVH9sPGO/hrVU50sy/FL1YZopuhZzB6HRyloaNqauugm977d+PNUF9qKwz3chwtD9c1Ttod7pB+dfGs+zF39BoF5F7mpv8Lqqg7zQgIC7Cb5jWWTPRFeAjdvVG66ReCfGSbFmzUhMQQ9oBpWbYcPxzyI1Zal+N2nThV6Q2c+n4VIxCo0svNF7Nn0S0EqOXtnjmECeXKCX638ql5mBBoaLTkJHEOdrZHfFSRKcTs9icbtAJSdxhbjt9FOTIeXUvmc/HFo DZUcTtjm uzUNfOtv/z+L8HNZb3QL+MLcShiAHZzpDF867JDe4mMLZuEiTogb1eHYKLJ42M9LQjYtKn5uEMNBrIRZLn8OoIZaAVBqxLLVRgJOas2fbhBVnzpmXkGZrQ7eoF7P+NexWVU4gtsu6By5rwXm0ZgkhQXloJYLUmMN3Tj+/y2KowZh1Q2ol0Qz4z10s/9jaWupOHCSJJgiqMjhGP5o5S9gS+vMLrwA6WknYqKKkbZSdr57anrTy0CLCTeEWNVnm1e1X71tWndPVMdr8BRBfBnCQ5No+eMpdJF2dl0F0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Simon Horman wrote: > > /* Functions related to files and directories */ > > +extern const struct netfs_request_ops cifs_req_ops; > > extern const struct file_operations cifs_file_ops; > > extern const struct file_operations cifs_file_direct_ops; /* if direc= tio mnt */ > > extern const struct file_operations cifs_file_strict_ops; /* if stric= tio mnt */ > = > Nit: this hunk would probably be better placed in the > patch at adds cifs_req_ops to fs/smb/client/file.c I'm not sure I understand what you mean. Is there a bit missing between "= at" and "adds" in that? David