linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Dave Hansen <dave.hansen@intel.com>,
	Hugh Dickins <hughd@google.com>,
	"Kirill A. Shutemov" <kirill@shutemov.name>,
	Jerome Marchand <jmarchan@redhat.com>,
	linux-kernel@vger.kernel.org,
	Naoya Horiguchi <nao.horiguchi@gmail.com>
Subject: [PATCH -mm v5 10/13] arch/powerpc/mm/subpage-prot.c: use walk->vma and walk_page_vma()
Date: Fri, 11 Jul 2014 14:35:46 -0400	[thread overview]
Message-ID: <1405103749-23506-11-git-send-email-n-horiguchi@ah.jp.nec.com> (raw)
In-Reply-To: <1405103749-23506-1-git-send-email-n-horiguchi@ah.jp.nec.com>

We don't have to use mm_walk->private to pass vma to the callback function
because of mm_walk->vma. And walk_page_vma() is useful if we walk over a
single vma.

Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
 arch/powerpc/mm/subpage-prot.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git mmotm-2014-07-09-17-08.orig/arch/powerpc/mm/subpage-prot.c mmotm-2014-07-09-17-08/arch/powerpc/mm/subpage-prot.c
index 6c0b1f5f8d2c..fa9fb5b4c66c 100644
--- mmotm-2014-07-09-17-08.orig/arch/powerpc/mm/subpage-prot.c
+++ mmotm-2014-07-09-17-08/arch/powerpc/mm/subpage-prot.c
@@ -134,7 +134,7 @@ static void subpage_prot_clear(unsigned long addr, unsigned long len)
 static int subpage_walk_pmd_entry(pmd_t *pmd, unsigned long addr,
 				  unsigned long end, struct mm_walk *walk)
 {
-	struct vm_area_struct *vma = walk->private;
+	struct vm_area_struct *vma = walk->vma;
 	split_huge_page_pmd(vma, addr, pmd);
 	return 0;
 }
@@ -163,9 +163,7 @@ static void subpage_mark_vma_nohuge(struct mm_struct *mm, unsigned long addr,
 		if (vma->vm_start >= (addr + len))
 			break;
 		vma->vm_flags |= VM_NOHUGEPAGE;
-		subpage_proto_walk.private = vma;
-		walk_page_range(vma->vm_start, vma->vm_end,
-				&subpage_proto_walk);
+		walk_page_vma(vma, &subpage_proto_walk);
 		vma = vma->vm_next;
 	}
 }
-- 
1.9.3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2014-07-11 18:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11 18:35 [PATCH -mm v5 00/13] pagewalk: improve vma handling, apply to new users Naoya Horiguchi
2014-07-11 18:35 ` [PATCH -mm v5 01/13] mm/pagewalk: remove pgd_entry() and pud_entry() Naoya Horiguchi
2014-07-11 18:35 ` [PATCH -mm v5 02/13] pagewalk: improve vma handling Naoya Horiguchi
2014-07-11 18:35 ` [PATCH -mm v5 03/13] pagewalk: add walk_page_vma() Naoya Horiguchi
2014-07-11 18:35 ` [PATCH -mm v5 04/13] smaps: remove mem_size_stats->vma and use walk_page_vma() Naoya Horiguchi
2014-07-11 18:35 ` [PATCH -mm v5 05/13] clear_refs: remove clear_refs_private->vma and introduce clear_refs_test_walk() Naoya Horiguchi
2014-07-11 18:35 ` [PATCH -mm v5 06/13] pagemap: use walk->vma instead of calling find_vma() Naoya Horiguchi
2014-07-11 18:35 ` [PATCH -mm v5 07/13] numa_maps: fix typo in gather_hugetbl_stats Naoya Horiguchi
2014-07-11 18:35 ` [PATCH -mm v5 08/13] numa_maps: remove numa_maps->vma Naoya Horiguchi
2014-07-11 18:35 ` [PATCH -mm v5 09/13] memcg: cleanup preparation for page table walk Naoya Horiguchi
2014-07-11 18:35 ` Naoya Horiguchi [this message]
2014-07-11 18:35 ` [PATCH -mm v5 11/13] mempolicy: apply page table walker on queue_pages_range() Naoya Horiguchi
2014-07-11 18:35 ` [PATCH -mm v5 12/13] mm: /proc/pid/clear_refs: avoid split_huge_page() Naoya Horiguchi
2014-07-14  6:40   ` Cyrill Gorcunov
2014-07-11 18:35 ` [PATCH -mm v5 13/13] mincore: apply page table walker on do_mincore() Naoya Horiguchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405103749-23506-11-git-send-email-n-horiguchi@ah.jp.nec.com \
    --to=n-horiguchi@ah.jp.nec.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=hughd@google.com \
    --cc=jmarchan@redhat.com \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nao.horiguchi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox