From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD44FC433B4 for ; Mon, 19 Apr 2021 16:18:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3A55461360 for ; Mon, 19 Apr 2021 16:18:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A55461360 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B87E16B006C; Mon, 19 Apr 2021 12:18:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B36886B006E; Mon, 19 Apr 2021 12:18:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 989866B0070; Mon, 19 Apr 2021 12:18:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id 7AA526B006C for ; Mon, 19 Apr 2021 12:18:37 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 249F6181AF5C2 for ; Mon, 19 Apr 2021 16:18:37 +0000 (UTC) X-FDA: 78049624674.18.D1065BA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 4B290C0007E0 for ; Mon, 19 Apr 2021 16:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618849116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fqJmgeuiMFVLhBvmQoDThETkhKCzy/6fbNKOoBifg+Y=; b=U83uGsTASycMduRhc0cTmyjdgLhMUpee/emH3UftwueJirYz9oBwHplPZUZLLEz5C5e4PZ x6CMM6K6wjL7JFT89NWnedRzLv1zVNnWg1Hm2Cj2m1YBvSujHFjAalEG8rY1DmDtH+XXiA dU55OY5G1L3GpJ4PeuVl+gnbJ0s+KIo= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-145-_cBcd7pXP2i0iQgJ7NMyxA-1; Mon, 19 Apr 2021 12:18:32 -0400 X-MC-Unique: _cBcd7pXP2i0iQgJ7NMyxA-1 Received: by mail-qk1-f200.google.com with SMTP id s10-20020a05620a030ab02902e061a1661fso5074888qkm.12 for ; Mon, 19 Apr 2021 09:18:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=fqJmgeuiMFVLhBvmQoDThETkhKCzy/6fbNKOoBifg+Y=; b=PbN97DUflwbLHhLpTzvzwr4dpWX6IaBjQFzcx7g4GSc4ScR7sZoyJGNmxNNRLQ+YsJ A+tVBNWNuBIgz/sN7umEmszOf2wEGEDdZhGg2aJEAaFQ4L7IqR99mkKzr//H93EA+UR1 UIhp9JIsixjToSZFRfH+N+/Ed0vb6UPinRMp3w/NL1d6iHuUEpFnT5YiVB5ph/IEbRPF I/Mhhzi4iF0Xr77Dn/nR+ETA8nXGSugtuP73maJwVS4CmuHYssTW22yJkbHLIz1yKZ04 Rh+bK2ra9wKnAP+4Vun4VqmDS+w1PxQXmMoaIvgDKg+4WoP6lm+nxkVtz55ziaC/Kh+K 4Q/g== X-Gm-Message-State: AOAM533RR+XzFM44JbLOtSEPcIYnE8O+P+9OVdpPmJCv3CImzWQaUIys yMtmdE5dmKRSjLCYVbQWjasHPSDkQFLgAlyxDpWVigjQzMfm7/B8Q7B9fPVs+gsApRLgbk66yN1 XvNKGHWNJpfM= X-Received: by 2002:a37:9cb:: with SMTP id 194mr5491928qkj.4.1618849111634; Mon, 19 Apr 2021 09:18:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJUxsMhOaiewnOvltNqxLcFgDmHVqmxsvQ037G7yq3H/F6qF/yWngPBHq6ZDy4Zx0BKbsUeQ== X-Received: by 2002:a37:9cb:: with SMTP id 194mr5491908qkj.4.1618849111409; Mon, 19 Apr 2021 09:18:31 -0700 (PDT) Received: from llong.remote.csb ([2601:191:8500:76c0::cdbc]) by smtp.gmail.com with ESMTPSA id f16sm10296757qkl.25.2021.04.19.09.18.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Apr 2021 09:18:30 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Subject: Re: [PATCH v4 1/5] mm/memcg: Move mod_objcg_state() to memcontrol.c To: Johannes Weiner Cc: Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Muchun Song , Alex Shi , Chris Down , Yafang Shao , Wei Yang , Masayoshi Mizuma , Xing Zhengjun , Matthew Wilcox References: <20210419000032.5432-1-longman@redhat.com> <20210419000032.5432-2-longman@redhat.com> Message-ID: <140444ea-14e7-b305-910f-f23fafe45488@redhat.com> Date: Mon, 19 Apr 2021 12:18:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=llong@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Queue-Id: 4B290C0007E0 X-Stat-Signature: hsxgfrt6ognduszardkop1u6r3tm8pc1 X-Rspamd-Server: rspam02 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618849119-347178 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/19/21 11:21 AM, Waiman Long wrote: > On 4/19/21 11:14 AM, Johannes Weiner wrote: >> On Sun, Apr 18, 2021 at 08:00:28PM -0400, Waiman Long wrote: >>> The mod_objcg_state() function is moved from mm/slab.h to=20 >>> mm/memcontrol.c >>> so that further optimization can be done to it in later patches witho= ut >>> exposing unnecessary details to other mm components. >>> >>> Signed-off-by: Waiman Long >>> --- >>> =C2=A0 mm/memcontrol.c | 13 +++++++++++++ >>> =C2=A0 mm/slab.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 16 ++---------= ----- >>> =C2=A0 2 files changed, 15 insertions(+), 14 deletions(-) >>> >>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >>> index e064ac0d850a..dc9032f28f2e 100644 >>> --- a/mm/memcontrol.c >>> +++ b/mm/memcontrol.c >>> @@ -3150,6 +3150,19 @@ void __memcg_kmem_uncharge_page(struct page=20 >>> *page, int order) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 css_put(&memcg->css); >>> =C2=A0 } >>> =C2=A0 +void mod_objcg_state(struct obj_cgroup *objcg, struct pglist_= data=20 >>> *pgdat, >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 enum node_stat_item idx, int nr) >>> +{ >>> +=C2=A0=C2=A0=C2=A0 struct mem_cgroup *memcg; >>> +=C2=A0=C2=A0=C2=A0 struct lruvec *lruvec =3D NULL; >>> + >>> +=C2=A0=C2=A0=C2=A0 rcu_read_lock(); >>> +=C2=A0=C2=A0=C2=A0 memcg =3D obj_cgroup_memcg(objcg); >>> +=C2=A0=C2=A0=C2=A0 lruvec =3D mem_cgroup_lruvec(memcg, pgdat); >>> +=C2=A0=C2=A0=C2=A0 mod_memcg_lruvec_state(lruvec, idx, nr); >>> +=C2=A0=C2=A0=C2=A0 rcu_read_unlock(); >>> +} >> It would be more naturally placed next to the others, e.g. below >> __mod_lruvec_kmem_state(). >> >> But no deal breaker if there isn't another revision. >> >> Acked-by: Johannes Weiner >> > Yes, there will be another revision by rebasing patch series on the=20 > linux-next. I will move the function then.=20 OK, it turns out that mod_objcg_state() is only defined if=20 CONFIG_MEMCG_KMEM. That was why I put it in the CONFIG_MEMCG_KMEM block=20 with the other obj_stock functions. I think I will keep it there. Thanks, Longman