From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED468C48BF8 for ; Mon, 19 Feb 2024 15:06:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C98A8D0003; Mon, 19 Feb 2024 10:06:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 779A88D0001; Mon, 19 Feb 2024 10:06:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 641E88D0003; Mon, 19 Feb 2024 10:06:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 525D78D0001 for ; Mon, 19 Feb 2024 10:06:49 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0D49A160452 for ; Mon, 19 Feb 2024 15:06:49 +0000 (UTC) X-FDA: 81808880538.24.77E69F4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 344E7C0021 for ; Mon, 19 Feb 2024 15:06:47 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ftF+O00V; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708355207; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vFCiJ6818JOoFEUYfbT4Q/AOpM96O17V3Tb55o233+4=; b=7uIZcx3HzJGZNDhdcsWL32c0lyY/8M2hgAuuEWponY2WcGX1YH1ZrsHOq8B7dJHGB6tssT +BV2plFCTkGV3tbfBs2FHXe5JoQ6bOJE6J5qgihioO0oCNJl+RcR1pmui0zU7V33JlUaG9 H8i8c8lyWsMa14B4WH4dyc+EsgUU2h8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ftF+O00V; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708355207; a=rsa-sha256; cv=none; b=OazAfxj777VG2VcD0TZaLARJiQNPyPvFNiIkC2QehWiBpn05dIG1Gk3Wsmv2A7J61oxYg0 v1k6HgPWTZflpomcfEC+1bWnPU9RZCjGTjgSf/5Ge7aqGD6k9Vrua5zOCafKT+1p4aFNUO MRX6bwEsMQCt4f3a/dSTVWLVmwH3x9g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708355206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vFCiJ6818JOoFEUYfbT4Q/AOpM96O17V3Tb55o233+4=; b=ftF+O00Vu2iwe+YiS6EgG8YY9BZzOGEdAV/jKKb0/0VDeRuPkzyYc2v2+94tVqsJZNhlZh yrf0OCR2c4CYmbuMkz1OsZTar+mmwAUDYEEp7oArFGLyHYgMFU4cXyxuEmiWTh9fYLe6i7 Le6V3Uiw8TwnBykoe2AW6AHBsyDv9S8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-eNmBTw3xMj6jNyDE7RWv_g-1; Mon, 19 Feb 2024 10:06:41 -0500 X-MC-Unique: eNmBTw3xMj6jNyDE7RWv_g-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3D214886460; Mon, 19 Feb 2024 15:06:40 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 319C0492BE2; Mon, 19 Feb 2024 15:06:38 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240209105251.GE1516992@kernel.org> References: <20240209105251.GE1516992@kernel.org> <20240205225726.3104808-1-dhowells@redhat.com> <20240205225726.3104808-10-dhowells@redhat.com> To: Simon Horman Cc: dhowells@redhat.com, Steve French , Jeff Layton , Matthew Wilcox , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Christian Brauner , netfs@lists.linux.dev, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Steve French , Shyam Prasad N , Rohith Surabattula Subject: Re: [PATCH v5 09/12] cifs: Cut over to using netfslib MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <140404.1708355197.1@warthog.procyon.org.uk> Date: Mon, 19 Feb 2024 15:06:37 +0000 Message-ID: <140405.1708355197@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 344E7C0021 X-Stat-Signature: f1zj4sm6cbgzbaz7dy6738aafojnjfei X-Rspam-User: X-HE-Tag: 1708355207-891109 X-HE-Meta: U2FsdGVkX1/k1WaaE27aNcG8Nl+7Y4AA2GPkQxX9s0LiOT1V4i8u93E8uEYS9QkcbabUok4ekqeLW4gv4B3BYs5JTkSjCaDD3sasSXjxBDGMVgQBeTysq/d9FtKl7VLC1xW3zqUWMnZFGQyw4TqFlJYbJ+d0ywVFOpLjVsuE+RvJB5dts+uBmJeVqnVLym3IUJkbzD0rkEKN4a1GItA6wnUD9tlRAYHlVBniq7Ss4/rvDUW87J79QpnK7TSabb+KF0qAITrYHoAlWEBnJAU2yxlHvOTagfI9c6aauSgNTbtAvtDFBF2QPtZfB2d3FXR1aQgowDF+OEtDQmJtT5SFe79EE8je+aKZX/DAbQarsQJ3SGVg9BuzPfHh1VHOCplNFweMhkNAylPNp1Aqn3UWiWtTK4pRV+mj7I27tb/Ws2Bi23AwgvisJeMiZT1TkgxbiKWt1uC+2fhleN3xa3zYWH0i5YdKvXU73mn7mV3PtOp2OC7vPil9YZM2VMPpm4xwkaZu15oSL7D5U5o7vOouEKHqCWMaLs2SxjSvOkMoAk+NClof3PxL8LLKysxfUHA+6gObhKIsUAF3w1VHwvYDZBMWvftQbu7njKjHzYJlndmNAbhReIUZzwLeUmABzr9R6ybEdcpjRqZgUFPDj1qq+PRsCcnqm0loXwcuamvsN8dSkXkBV/AP+jmLX6y616xnXjx8KSZMRi/ixDVS5AHIXdxs1QDr5MZp3TjqxEFoJkc5jHWmorFCOT+jKPfZ7VrQt6f0IRnsfDkg9dT8ykck/YHNR+Gv+2FKI7j95hTqd9Kcf7bjfURmfEvFuR/lCzWaFKe/st64JTN7E8RPaubspe+KcPqaM1xUSO5a7Fc622yIE+gmw2UfxUibKAiOts8vAdATN/Q1hfUgqUFNxqj8lAAdVyc6ZfqA7FB9l5tl5eo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Simon Horman wrote: > However, the code below this hunk, other than being guarded by > smb3_use_rdma_offload(io_parms), uses rdata unconditionally. Yeah - it does that even without my patches. SMB2_read() can call the function with rdata == NULL, but I'm unsure as to whether the RDMA branch will ever be used except for actual reads - in which case rdata will not be NULL at the "rdata->mr" point. David