linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.cz>, Hugh Dickins <hughd@google.com>,
	Tejun Heo <tj@kernel.org>,
	Vladimir Davydov <vdavydov@parallels.com>,
	cgroups@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [patch 04/10] mm: memcontrol: reclaim at least once for __GFP_NORETRY
Date: Thu, 29 May 2014 12:15:56 -0400	[thread overview]
Message-ID: <1401380162-24121-5-git-send-email-hannes@cmpxchg.org> (raw)
In-Reply-To: <1401380162-24121-1-git-send-email-hannes@cmpxchg.org>

Currently, __GFP_NORETRY tries charging once and gives up before even
trying to reclaim.  Bring the behavior on par with the page allocator
and reclaim at least once before giving up.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
---
 mm/memcontrol.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index e8d5075c081f..8957d6c945b8 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2614,13 +2614,13 @@ retry:
 	if (!(gfp_mask & __GFP_WAIT))
 		goto nomem;
 
-	if (gfp_mask & __GFP_NORETRY)
-		goto nomem;
-
 	nr_reclaimed = mem_cgroup_reclaim(mem_over_limit, gfp_mask, flags);
 
 	if (mem_cgroup_margin(mem_over_limit) >= batch)
 		goto retry;
+
+	if (gfp_mask & __GFP_NORETRY)
+		goto nomem;
 	/*
 	 * Even though the limit is exceeded at this point, reclaim
 	 * may have been able to free some pages.  Retry the charge
-- 
1.9.3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2014-05-29 16:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 16:15 [patch 0/9] mm: memcontrol: naturalize charge lifetime v2 Johannes Weiner
2014-05-29 16:15 ` [patch 01/10] mm: memcontrol: fold mem_cgroup_do_charge() Johannes Weiner
2014-06-03 12:38   ` Michal Hocko
2014-05-29 16:15 ` [patch 02/10] mm: memcontrol: rearrange charging fast path Johannes Weiner
2014-06-03 12:54   ` Michal Hocko
2014-05-29 16:15 ` [patch 03/10] mm: memcontrol: retry reclaim for oom-disabled and __GFP_NOFAIL charges Johannes Weiner
2014-06-03 13:20   ` Michal Hocko
2014-05-29 16:15 ` Johannes Weiner [this message]
2014-06-03 13:16   ` [patch 04/10] mm: memcontrol: reclaim at least once for __GFP_NORETRY Michal Hocko
2014-05-29 16:15 ` [patch 05/10] mm: memcontrol: catch root bypass in move precharge Johannes Weiner
2014-06-03 13:22   ` Michal Hocko
2014-05-29 16:15 ` [patch 06/10] mm: memcontrol: use root_mem_cgroup res_counter Johannes Weiner
2014-06-03 14:11   ` Michal Hocko
2014-05-29 16:15 ` [patch 07/10] mm: memcontrol: remove ordering between pc->mem_cgroup and PageCgroupUsed Johannes Weiner
2014-05-29 16:16 ` [patch 08/10] mm: memcontrol: do not acquire page_cgroup lock for kmem pages Johannes Weiner
2014-05-29 16:16 ` [patch 09/10] mm: memcontrol: rewrite charge API Johannes Weiner
2014-05-29 16:16 ` [patch 10/10] mm: memcontrol: rewrite uncharge API Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401380162-24121-5-git-send-email-hannes@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=tj@kernel.org \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox