From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DD8AC433E0 for ; Thu, 4 Feb 2021 22:20:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9691D64F58 for ; Thu, 4 Feb 2021 22:20:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9691D64F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D022B6B0006; Thu, 4 Feb 2021 17:20:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C8C9D6B006C; Thu, 4 Feb 2021 17:20:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B51ED6B006E; Thu, 4 Feb 2021 17:20:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id 983506B0006 for ; Thu, 4 Feb 2021 17:20:50 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 63C09181AEF0B for ; Thu, 4 Feb 2021 22:20:50 +0000 (UTC) X-FDA: 77782006260.17.3F286E1 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf07.hostedemail.com (Postfix) with ESMTP id 82978A0000F8 for ; Thu, 4 Feb 2021 22:20:49 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 42AD664E0F; Thu, 4 Feb 2021 22:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612477248; bh=srANFyFRjZWUNqLmRWYde2yLB0hjm8XnDjUMhIBivaA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=uXKII3KVqIM0KWZWfAoo2nXt1jcb0OXHPDihGTijgToz9tmaCzJhwQcvmlg9BBqM5 nQR5XjwW4SoF18hpz53DrVO4LNU+OA41fza2i7qi8mnLbtTBe+Zn06vcoOMZ2uWG8f bKnL5n2vPCc8dki0w7V3kCAoP7ZYpMKKQql6gtHpYzpEz4KCRO0eIZoUe99+dmX8/M 8EApnY+PDIg3pcpwMXk1WQE8bXAnp9YRUNrmmJVJV4ADTvW6YR8jms+gujpIragUlf OK0iWWkW5CkSXWKxbI3/JEMv1pNYOd6TnRdRUq1Lmn5sPUeMKomjtIca/Sn/NSP5bw /mzYm+E1bIOyg== Subject: Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed To: Kees Cook , Pavel Machek Cc: Steven Rostedt , Petr Mladek , Sergey Senozhatsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, roman.fietze@magna.com, john.ogness@linutronix.de, akinobu.mita@gmail.com References: <20210202201846.716915-1-timur@kernel.org> <20210204204835.GA7529@amd> <20210204155423.2864bf4f@gandalf.local.home> <20210204214944.GA13103@amd> <873d7e08-7a70-a1a3-f486-882d1d515965@kernel.org> <20210204221143.GB13103@amd> <202102041415.D9093ED6@keescook> From: Timur Tabi Message-ID: <13fdd006-3070-fb6a-cd99-7f845deb6843@kernel.org> Date: Thu, 4 Feb 2021 16:20:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <202102041415.D9093ED6@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: fqn9xz4a8sj7qnwokmxrgyu7t8j7znw6 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 82978A0000F8 Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1612477249-427650 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/4/21 4:17 PM, Kees Cook wrote: > It's just semantics. Printing addresses DOES weaken the security of a > system, especially when we know attackers have and do use stuff from dmesg > to tune their attacks. How about "reduces the security of your system"? I think we're bikeshedding now, but I can replace "compromise" with "reduce". "Kernel memory addresses are exposed, which may reduce the security of your system."