From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77DE3C433FE for ; Tue, 8 Dec 2020 16:56:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E3F7723B05 for ; Tue, 8 Dec 2020 16:56:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3F7723B05 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ndufresne.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EE9816B006C; Tue, 8 Dec 2020 11:56:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A506B0070; Tue, 8 Dec 2020 11:56:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D61B26B0071; Tue, 8 Dec 2020 11:56:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BD7976B006C for ; Tue, 8 Dec 2020 11:56:05 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6FB373623 for ; Tue, 8 Dec 2020 16:56:05 +0000 (UTC) X-FDA: 77570717490.18.fear41_330dc12273e8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 45E22100EDBCE for ; Tue, 8 Dec 2020 16:56:05 +0000 (UTC) X-HE-Tag: fear41_330dc12273e8 X-Filterd-Recvd-Size: 5877 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Dec 2020 16:56:04 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id z3so12365622qtw.9 for ; Tue, 08 Dec 2020 08:56:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=zJCFBWmnrCjIsCfIXtOANynWilFtdxBgWzL9qsHoBgk=; b=p+scvweiVtiWtaEakkIVG6rtVNVZdKC4xEMfsVUAkGkAs5h511JtSfYxxQKM14TDDZ fEfsaNp/p3BIDs6/X5JkgItrkLy28f8w/iXwVs8TOXGvhPzn4yLR4EEZGuAWgZpf7hxm oICvzMJUysvE4HibNIZDkAAh0EB5bEH7gm97HngzdHKm0EqEdUZC3jJJlDhbSGP+jrlQ i6flmV7bIH7Uj9jADLa2clZybJ4fkdv64UEfyWf+pYG3D/kAh+qY8Li8uChCQAf6Mi78 64m49oUhL9tAhdmz2zf54q2cz/TMbc7BXuA5mmIQNaBFG1KQeFg56u1CVDBfyUkSVxA2 DWTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=zJCFBWmnrCjIsCfIXtOANynWilFtdxBgWzL9qsHoBgk=; b=hfY3VcOC+unK/7Usi6OhNaOWDhRrGltjp8TN+iSHo07lXLTM1+IlEBl1/FQg1yFeTl NE0OkzMqc3rwJ5h1Oy4oNbfYbByQf08tB8wiXB/jrsgRyUjdgp4asM7F8+dS55fKhpa3 WwNKisZe5S7rKpyN3Dd5eLK0ivpwt7mEEjCGNqZHWhh53cifJgQ1Dh2DQn5duZqI/fDx 95ooSMIQGB7rIDrz4C0flGWtkA1pyn+8dge6AUGkRvFSdDY+Bmda4r+kZW65DMIgy7UN AkIWb+fKRlXWhV+eY9C6MqtOkU9FTiyh1WeQKJzNqu9g59tEbf0LM3/4WOzhkswn2bvw JzAA== X-Gm-Message-State: AOAM530C0K7xZdIjWlU27DT0qPtDGsQTXq5jEjKsKlZaaq+RFRHun83q T2VWHEXKKWXYKsVBe/HEv9x8Uw== X-Google-Smtp-Source: ABdhPJz6DEGfHZWtsRRNwbE8f3Jk7xHwzlJ8lJRqvWgr85V2qI9546FeZHjPEkuxohNdKuvO79ZOpw== X-Received: by 2002:ac8:76c7:: with SMTP id q7mr30486415qtr.317.1607446564196; Tue, 08 Dec 2020 08:56:04 -0800 (PST) Received: from nicolas-tpx395.lan (173-246-12-168.qc.cable.ebox.net. [173.246.12.168]) by smtp.gmail.com with ESMTPSA id y22sm4953552qkj.129.2020.12.08.08.56.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 08:56:03 -0800 (PST) Message-ID: <13e1fbc75080aada90fd92954ad1fea39f4c1c7a.camel@ndufresne.ca> Subject: Re: [PATCH 0/4] Chunk Heap Support on DMA-HEAP From: Nicolas Dufresne To: Minchan Kim , Andrew Morton Cc: LKML , linux-mm , hyesoo.yu@samsung.com, willy@infradead.org, david@redhat.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, surenb@google.com, pullip.cho@samsung.com, joaodias@google.com, hridya@google.com, sumit.semwal@linaro.org, john.stultz@linaro.org, Brian.Starkey@arm.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, robh@kernel.org, christian.koenig@amd.com, linaro-mm-sig@lists.linaro.org Date: Tue, 08 Dec 2020 11:56:01 -0500 In-Reply-To: <20201117181935.3613581-1-minchan@kernel.org> References: <20201117181935.3613581-1-minchan@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.1 (3.38.1-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le mardi 17 novembre 2020 =C3=A0 10:19 -0800, Minchan Kim a =C3=A9crit=C2= =A0: > This patchset introduces a new dma heap, chunk heap that makes it > easy to perform the bulk allocation of high order pages. > It has been created to help optimize the 4K/8K HDR video playback > with secure DRM HW to protect contents on memory. The HW needs > physically contiguous memory chunks up to several hundred MB memory. >=20 > The chunk heap is registered by device tree with alignment and memory > node of Contiguous Memory Allocator(CMA). Alignment defines chunk page = size. > For example, alignment 0x1_0000 means chunk page size is 64KB. > The phandle to memory node indicates contiguous memory allocator(CMA). > If device node doesn't have cma, the registration of chunk heap fails. >=20 > This patchset is against on next-20201110. I believe you have forgot to reference Open Source / Upstream code using = this. regards, Nicolas >=20 > The patchset includes the following: > =C2=A0- cma_alloc_bulk API > =C2=A0- export dma-heap API to register kernel module dma heap. > =C2=A0- add chunk heap implementation. > =C2=A0- devicetree >=20 > Hyesoo Yu (3): > =C2=A0 dma-buf: add export symbol for dma-heap > =C2=A0 dma-buf: heaps: add chunk heap to dmabuf heaps > =C2=A0 dma-heap: Devicetree binding for chunk heap >=20 > Minchan Kim (1): > =C2=A0 mm: introduce cma_alloc_bulk API >=20 > =C2=A0.../bindings/dma-buf/chunk_heap.yaml=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 52 ++ > =C2=A0drivers/dma-buf/dma-heap.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= |=C2=A0=C2=A0 2 + > =C2=A0drivers/dma-buf/heaps/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0= 9 + > =C2=A0drivers/dma-buf/heaps/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 1 + > =C2=A0drivers/dma-buf/heaps/chunk_heap.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 458 ++++++++++++++++++ > =C2=A0include/linux/cma.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 5 + > =C2=A0include/linux/page-isolation.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 1 + > =C2=A0mm/cma.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 | 129 ++++- > =C2=A0mm/page_alloc.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 19 +- > =C2=A0mm/page_isolation.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 +- > =C2=A010 files changed, 666 insertions(+), 13 deletions(-) > =C2=A0create mode 100644 Documentation/devicetree/bindings/dma-buf/chun= k_heap.yaml > =C2=A0create mode 100644 drivers/dma-buf/heaps/chunk_heap.c >=20