From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE2DAC77B7A for ; Fri, 26 May 2023 08:29:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 588F96B0072; Fri, 26 May 2023 04:29:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55FAF900005; Fri, 26 May 2023 04:29:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 426D0900003; Fri, 26 May 2023 04:29:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 31E9B6B0072 for ; Fri, 26 May 2023 04:29:51 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F35CEC0CDA for ; Fri, 26 May 2023 08:29:50 +0000 (UTC) X-FDA: 80831732940.04.9E355E5 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf11.hostedemail.com (Postfix) with ESMTP id 2521D4000C for ; Fri, 26 May 2023 08:29:48 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=L+kkDr2m; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685089789; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v1pa2Q0AfaiaqQI2ullEGnQjWj0U14Eq06qxiexcex8=; b=vIWz/NR0czp22XzKtlz4f9BqK0QIRls5oN2iXRajN9M43wF21Tg/09Ol7P3Ez+QVj2PwCJ 5DQ5u5/kTaOWJAh6d5tRPhaz1RDoi0JXQxZdV06w3j/gBRrTAHtG3h3Ht3W3r983g1+/vJ B1/RlPHrGAp6dpwWkyepWNmTVZKVrYM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=L+kkDr2m; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685089789; a=rsa-sha256; cv=none; b=Kzo7aicSxeH75/nei7NwBqLG7lFv3w7CHnBMAQD7ZyD9BKas51HD25DTTXoma1sQmianvB ngocCSjWvV1MMsLysvDg0xIQp8ty8DBgt3pC3xTuV3oa3yFEMS0+Em/Lcc6gCRr1MrVzJk YeF5CXTmhuqyPD9UqkK7KgYsGcvhGq4= Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-3f6094cb2ebso3124515e9.3 for ; Fri, 26 May 2023 01:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685089787; x=1687681787; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v1pa2Q0AfaiaqQI2ullEGnQjWj0U14Eq06qxiexcex8=; b=L+kkDr2ms492v9mk5G0ugQoPnpWpdza3e4dbO8KflEoaVvUqIKUqYhaKOJzFyjVYpN lHn1WaVkAYVNs7AgycnOXYBJwOsJGRMONcS4E59YMT42HsYDLgQtet9yAj7YTClTStrQ 2SAwUxP1q/2BfqKWbM7Ka+tJC5XKwK27qpRZ6nvivx6D5AsiWWtfAzyTsNCSKZbibqtU G61oSgbnGhT/FmmAvFt4FskW1UbbvB1e+Qv8gTkAcZUbJKbPvB32O6z7baabHAHVsml0 vjc+NkanO0+KwNgNr35fxxfRVBSRqiEsSUKv2qyHl+yxja7Rl/zhXiBsuA95jA7fhGfj b+Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685089787; x=1687681787; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v1pa2Q0AfaiaqQI2ullEGnQjWj0U14Eq06qxiexcex8=; b=G9fch16mq5MfNzmXflZihAz/pjSadkz4Zx24j8Tx+n3l3mFhcx3CvEhuNxnUZeWsvE jhkNdYCO2GWVBXsHgkEYHpJa5ETSnPWtD1qj7IMoyKkpgY9RQ8pHlyIbbWdfIcokentZ MNN/dWOkXCtiN2C5dNVglV2YpHqkImwZmi8fjuqvR3uH2/0sDuITkXQa9vMWEyM8SWa2 XkbJ8X0jEjPQW37rdl/fuQJTbd9VAbxUzpoeLRkux5nbaqyDXzbhudwxFX2ESx27X3Nb BcQd+TrVkLL85M9fDS9EZSREreWIU3t/NAMyZmWPy6UTPyA1vRuGn3RwpPasOR4huTMh AEIg== X-Gm-Message-State: AC+VfDz62J1pfx4mdwNGXpEqaBqkx8Zje2PYLnpmfLDmuLgyuN7RHtv6 U4cWJLGM6Xes91zEZPN/woQ= X-Google-Smtp-Source: ACHHUZ4irR/FYHS2vJzInP0aq/HsL1H6Oeax9jQfatuNaGEWy+dOAMSjKp0Rt+Qjz7gwlOFxrtEoCg== X-Received: by 2002:a05:600c:22d0:b0:3f6:f56:9ad with SMTP id 16-20020a05600c22d000b003f60f5609admr745456wmg.13.1685089787374; Fri, 26 May 2023 01:29:47 -0700 (PDT) Received: from localhost (host81-154-179-160.range81-154.btcentralplus.com. [81.154.179.160]) by smtp.gmail.com with ESMTPSA id z10-20020a7bc7ca000000b003f602e2b653sm8070980wmk.28.2023.05.26.01.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 01:29:46 -0700 (PDT) Date: Fri, 26 May 2023 09:27:37 +0100 From: Lorenzo Stoakes To: Christoph Hellwig Cc: David Howells , David Hildenbrand , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Subject: Re: [RFC PATCH v2 1/3] mm: Don't pin ZERO_PAGE in pin_user_pages() Message-ID: <13ddccb0-c045-4fd7-a495-b0ffe7796bbc@lucifer.local> References: <20230525223953.225496-1-dhowells@redhat.com> <20230525223953.225496-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2521D4000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 1n11xtj797hfcqhhi6awr4re54hkub7i X-HE-Tag: 1685089788-512053 X-HE-Meta: U2FsdGVkX1+RgBJRFW5yTIHG8YYW277wPwzv3uNqFLHWqT7KJJlUwz/1o1MnEtCJlri4yhHUcHIEm0ib6eZshkzToRn21vbAn+sH56OYggfDqZvOyu6xjGX2r9FSd6Q9jHYr+g1X3X1C+5HBrIp1Pkur1/sb+yUZIHSWx9lt01Y/V+O+r9K9NUzoyeu1u7suvSrcNNouP8bOYhTQAGzidZ3xqdP68E++o8GmYQVzMlhuRJ1rYyK5rVSsY25ZqHvofYoxdaA5DrbimzXbF2hKl0Y33yb9adW6KfiQ5l+3dl4CPdscZoCOBiq3D+C9Uk3ckdC4o6bthrLqFzem2vbJkrIY/bc1MXlxgPbz7c/B09Bons6mWsR1deRon/NGOcytlIvzHqTxUhZ902H0Nsth/v+LtYuWmP4nxdFIMCBSPgs3KEGDKyzLLDMERXwhHJNBr699pzLiUrIqaUhysxuI9kLcWmGLPk1QcV1A4z+6C9u42ptYEhYAYwvvW4r0yY2RbBwkH28vuVS1jMnG+wbXLDDdIHIp6XFKPR3IKEfhaazwVvPDDQxU9ZOaM3TiXqcXLK9jQqRp04ZjuE21Ppgqkc1WxxIqqQD9iqqylxhXQiEXiQZ67SlzsngvDDqOkhIZQPK1mPluXzNQWIBR32ECsLD3IgNjtYTdAaONq+kXK1qxhFGo8a46PycvIBCqlA0YpcEt6zM429Xtgqjxu827djboBet8S4snYQJK8JD2sQfzRjvdj4OaBzXrllCdmTfp/cPYPfx100AKrRtMNB/7x7VxM4Pj3MmQf8hwZ9uWdjIjVgpZukM6tr3r/zRdXij+AUfYPN+NzBa3Cf8UbVY8LxMXDURlI1PBI0oNyclLWmsGMQx0jHYd8VD3a7gf0VlTxY84hHUYYQG+2qWEd8IW9URFI/K4UXS6Tf+8VZ9vvhXBqyfNgumtYbPzV2kKmR3PaDrp5I1YYVhXp3hL06R xZznJbp8 x52Qm+yHOA3u4Mwm/jK/AK/wUszBGkKYf2rlupoztpjCgPR+J3EwqwiNO3IfBz3CBkQblMuUytGejLmgcRoFir93iQgXU5K0EwYjGER7KzC6ZvqtgAjqSSSTq8Crtujy97mBV47otvzx/+aR66LqhX0Tiw+oKa3oyALOd+STvMOtT2DoGEufI9pdBV5edkZ93ehtHLqFZRMcwEwILdi+NFX1J3KXHEszIyh2YR3pMbXkxHygD9o9harkH3xu90Jd9zQJpJqiiRFIo6ezG6Gqbzpn79odu/lJmLcPQTyMFZILYkyNAO6zXogOqV5BPSzKKn1sP5E86AhmO9kJPA+v7oi0nPIwYzfYXzI+JCPC4cR9l0O8nCox1UC997A3TTSxXy8I//pUCojhmG6BpdsOw9yW6DXoTLJq4/SjAkU2AktdIQ+Z8wsrzAOcolw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 26, 2023 at 01:22:54AM -0700, Christoph Hellwig wrote: > Shouldn't unpin_user_pages and bio_release_page also be updated to > skip a zero page here? > unpin_user_pages*() all call gup_put_folio() which already skips the zero page so we should be covered on that front.