From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85C57D32D84 for ; Tue, 12 Nov 2024 10:12:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC0BD6B00E7; Tue, 12 Nov 2024 05:12:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B49A56B00E8; Tue, 12 Nov 2024 05:12:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C1DC6B00E9; Tue, 12 Nov 2024 05:12:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 744D96B00E7 for ; Tue, 12 Nov 2024 05:12:29 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1E77BA0572 for ; Tue, 12 Nov 2024 10:12:29 +0000 (UTC) X-FDA: 82777026654.27.3320274 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf19.hostedemail.com (Postfix) with ESMTP id 0E9CF1A001E for ; Tue, 12 Nov 2024 10:11:34 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YA4CK1bk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of colin.i.king@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=colin.i.king@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731406260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pxM4gTQSQABswxwP+nf/NclermLnvfNjsT0wLCiH6gI=; b=nf/A2W4EJuoKt6S773Ppggx6S4GgSplSsGWhdaXTn8/n8V006SgbMGL+lGHF6FMn/+GQFE V3I2yHlXg+PeornXTPLCFop570XGFwjmj5HwEyTyYv2hv2Va1Azide4sI2YAwndXfGU4mk 0qeF/pHHubnBle2P2XmncjE7yjXHOjQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YA4CK1bk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of colin.i.king@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=colin.i.king@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731406260; a=rsa-sha256; cv=none; b=KRmmj4jSWGd+3wTlXt85X420zDFsz5VvUnf6WnYc8x8TOLWTY4oySrmMcG1a6j0RAq5Jvm qu6MMWr6K4htDD6c33lljb9+ri1w3WSHB7coxz5rrDCWh7yXJOAyHVoBPVs4rEE6GV6hLQ Si30lzRoqebB9Nli3krNY2z2UN2FLuQ= Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-37d6ff1cbe1so4201528f8f.3 for ; Tue, 12 Nov 2024 02:12:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731406346; x=1732011146; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pxM4gTQSQABswxwP+nf/NclermLnvfNjsT0wLCiH6gI=; b=YA4CK1bkcOU/AtwZizQKYlMqJeDNeWiPcNd03yJZoN/DVXJARjRZq3W2p71w+37ibD Cp98tPX3vu6P0XJhBjvCUKgwGXoaczCF0SzUJ0zwri5phvnjhDgTKI9+zsMIRm8iOxWj xlrxCEt0dqV9OVmz0Lrv5wIvyIvxFJrk9CRLJrOrAuTNa9vkrnCz0Rakk11kSE1lw/w1 xHJIByPZzTrhbWLsOTjl4aU/GoGLLgTTYWFEczv28VR7jAXyPYgEgPH0mByFHAD3+/TM 6WoooUIawGUOMz3X2nWOt/fBjh2o9qC0LlJ4G1oikKkMXgIzxbDsVBc4kqU5Xk2kGXzk AggA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731406346; x=1732011146; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pxM4gTQSQABswxwP+nf/NclermLnvfNjsT0wLCiH6gI=; b=uycT6U117u8iZ+8CtpAyaM3E9pk5f9/Q96rx63nOXJS7FpRjr8Wdiote4IWx/+hbJ/ 7gOv8Qxbq1ShqDJ2JpfMzm14tFMN79JldM5myhRduaF8k9+IcqH0uzhxh615yCLH0OE5 /EpK3QxXxsTXH5UU0O1Ao4RzTetRoJb5+gGGKuIHeZWMXLWUQDwjLHVMAfU9WXNnFGBG 3ABpFKXuMZ7YeoVyDi9byymvn4DJgRl35WUmkbSYcCXa4kBVlvK7pLEJzRLuP5POL3Vs 8W7lKYHGJWEnN2kHQQ9YZYExyds888UhpA16ODl7bD7+99OnqXTKq1JrgKfDLPQwlTH5 NLFA== X-Forwarded-Encrypted: i=1; AJvYcCW5WKrYViU1XllYULPJ4mKkGJQ4r7gYYbIM2LbQb0w1tffbltHI68R34JdELTwkxkMI3CUWCXQPYA==@kvack.org X-Gm-Message-State: AOJu0Yxn+F74jXahSVk3ZNZukFo/fP2y4Kio/J22GkzsAz/Z9NWjAONh RSoza9OwXljj/2RywIzeQS0wpu9/jwpTYR+hhEfeNk2T2PttyVUQXtcYe2PA4UM= X-Google-Smtp-Source: AGHT+IF2lKwcu2657ck5gxeudUjTWht1t6K5qHLNTn06ITYmACxEnF6yEezmxaFASANVfwEza7fpUw== X-Received: by 2002:a05:6000:1844:b0:368:3731:1613 with SMTP id ffacd0b85a97d-381f172108dmr11334219f8f.13.1731406345364; Tue, 12 Nov 2024 02:12:25 -0800 (PST) Received: from [192.168.1.248] ([194.120.133.65]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-432b0562ccdsm200920345e9.23.2024.11.12.02.12.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Nov 2024 02:12:25 -0800 (PST) Message-ID: <13db01a1-1c8b-4d56-ac2d-9f39082c2644@gmail.com> Date: Tue, 12 Nov 2024 10:12:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH][next] mm: shmem: Fix error checking on utf8_parse_version failures To: =?UTF-8?Q?Andr=C3=A9_Almeida?= Cc: Hugh Dickins , linux-mm@kvack.org, Christian Brauner , Gabriel Krisman Bertazi , Andrew Morton , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241112095449.461196-1-colin.i.king@gmail.com> <3b865b4a-5d82-4d11-a60c-f4bea6cd25c0@igalia.com> Content-Language: en-US From: "Colin King (gmail)" In-Reply-To: <3b865b4a-5d82-4d11-a60c-f4bea6cd25c0@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0E9CF1A001E X-Stat-Signature: he6xh9b553tjdre5webqi99datrmtxme X-HE-Tag: 1731406294-712758 X-HE-Meta: U2FsdGVkX1/x5oruWCuvhY88x0dp40adBeRzJ+pXa+lHKQZ3lfG1IMaETn97IPMc4p7jTWKH40eXTj3jVfsxKI7KIS9vzz910BIHnixwetk2BlUNjloPkgOLsok7lI6SjgP5DudEAgujQbKsKUCy5EfoN1jAh/TUkzJ+wAM4eEWLsiBivCGQYCc72piWb6OIOWihEWky6fA9e/j22GXCSWqE9YVLwxDpCbqE3ZTOmxlnXA8//z8gRkmlZ0NeoJwdCKIFGdj8DtQwzSRnabgO3zwZvE9QCH57xxV9nV6ch5Yv2qKysaSWjTwJdO598IX+1XnN2xtS2aCPHm9+Fu/nSIBz/Xvg0zUkfa1ouObSvUV0HUNIOiGT8mQXgpG1OHP1jBtVZrCxVp+G/72zrsv7s1h9ViVJpXciISvXc9NRelC7eGPbiq1S4e5Q8HznKvIjsf7rlHf9zcLmqJgd4nPwMUCYJyYrxIsRoG0GdGBAL6JYof8plBIXm5zFeh5FbMcC3x4hECNvd5O7g3YKlo4Yu59aFSAxt3+0WMhdY3ae4yeicQJ8VtzNfCjnovAfgM99fgDNzybmDYAQDnzAvKOam3RjihG15M4SsutZ18mY+FTyGDmopjk3Sw1Ck1R2vzeP8KEkUKPT9kZ+4+H9sv6tKgQe/qWUYLqaGWlnkHz7yyZDMTr1BLJ2F2ZTxRgvq9gNIDkIK1o2TNy59NTq2a55NWlZGgtZM01V6O+x1QLiTurQPlwUMZeFYY/fCD198En+/oLTBN2vuExweREXsBqrTo2KJgz+yJxfr8PbIcbiTx5jP0iRQ/FdvrM/OVQTY/OJC7aHjG3IO0l0Y5UTX3J8gOdPlVjwbH0iXSDmVPRmiVXbq7kVZudPD3WOYq40I7yvwRzS8ve7vD+UNcPNwqjpOrjQD0S39uOcwar7OXU47MaupdjMncJ5+mFTyng53RYOvXXQOd8wBupe6H7JcS0 Wdt+XlCo op34B0693BbxY3GrXzPpxlGF+27q042kqUI+/YsilTaOE04e1V0R/ZdfveELeEWqMaaNWaslT7T2npr9Gunwb/UsJd6d9pAbAGJx0ZJHGizVuYq90bop0js/G/KDczsvd6iYT28/9FaS3uqvBJGXRPfvsOnex/VkQSpoRM7ykVAd5QXecIf6EcELTKMQyvd21n4kAATg5GCpDbayx1oi2KszjmhdvJVN4TTvw9TT4743zZDbabGwhglsQGj2H1TrLuQFuXklKOkBHl5tS81D7E/QmDufXijnVinUJBPr+xhqyVGjoAI4LhptpOIenwcUsuyn6jTMuVhwwh78UasAS2d8ZX06j0Y5vkAXyX0Xz5sgHGRL/OSCXhGPL24xft/0YPt6E9XRMq4S6fTtmnT1bTclFg9VOycxuxslQKAGxagB6hnp8YWmQSukSMstMi/A6kg/Vw/b+f0UnB33tTivAHTIGotI0raP93EfMLOCex/edxNXUmDGi+zqnrQl4LtbBGtHk+BmxgdKevJhbqfVedJzue7MlGmhAUU4qje6OB4miit0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/11/2024 10:06, André Almeida wrote: > Hi Colin, > > Em 12/11/2024 06:54, Colin Ian King escreveu: >> Currently the error check on the call to utf8_parse_version is always >> false because version is an unsigned int and this can never be less >> than zero. Because version is required to be an unsigned int, fix the >> issue by casting it to int just for the error check. > > Why is it required to be an unsigned int? It's being passed to various functions that expect unsigned int, so I presume it was intended to be of that type. Colin > >> >> Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support") >> Signed-off-by: Colin Ian King > > Another fix was already sent: https://lore.kernel.org/lkml/20241111- > unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com/