From: Nikita Kalyazin <kalyazin@amazon.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: <linux-mm@kvack.org>, Andrea Arcangeli <aarcange@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
David Hildenbrand <david@redhat.com>,
Hugh Dickins <hughd@google.com>,
"James Houghton" <jthoughton@google.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Michal Hocko <mhocko@suse.com>,
Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Shuah Khan <shuah@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@suse.cz>, <linux-kernel@vger.kernel.org>,
<kvm@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v2 4/5] guest_memfd: add support for userfaultfd minor mode
Date: Thu, 27 Nov 2025 11:19:35 +0000 [thread overview]
Message-ID: <13d3a7a4-5cf8-4fbe-8dba-d565525a71c6@amazon.com> (raw)
In-Reply-To: <aSgpo1_ZSmxf84-p@kernel.org>
On 27/11/2025 10:36, Mike Rapoport wrote:
> On Wed, Nov 26, 2025 at 04:49:31PM +0000, Nikita Kalyazin wrote:
>> On 25/11/2025 18:38, Mike Rapoport wrote:
>>> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>>>
>>> +#ifdef CONFIG_USERFAULTFD
>>> +static struct folio *kvm_gmem_get_folio(struct inode *inode, pgoff_t pgoff)
>>
>> We have to name it differently, otherwise it clashes with the existing one
>> in this file.
>
> It's all David's fault! ;-P
> How about kvm_gmem_get_prepared_folio() ?
I'm afraid it may not be ideal due to preparedness tracking being
removed from guest_memfd at some point [1]. Would it be too bad to add
an indication to userfaultfd in the name somehow given that it's already
guarded by the config?
[1]
https://lore.kernel.org/linux-coco/20251113230759.1562024-1-michael.roth@amd.com
>
> --
> Sincerely yours,
> Mike.
next prev parent reply other threads:[~2025-11-27 11:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 18:38 [PATCH v2 0/5] mm, kvm: add guest_memfd support for uffd minor faults Mike Rapoport
2025-11-25 18:38 ` [PATCH v2 1/5] userfaultfd: move vma_can_userfault out of line Mike Rapoport
2025-11-26 15:05 ` Liam R. Howlett
2025-11-25 18:38 ` [PATCH v2 2/5] userfaultfd, shmem: use a VMA callback to handle UFFDIO_CONTINUE Mike Rapoport
2025-11-26 10:21 ` David Hildenbrand (Red Hat)
2025-11-26 15:11 ` Liam R. Howlett
2025-11-25 18:38 ` [PATCH v2 3/5] mm: introduce VM_FAULT_UFFD_MINOR fault reason Mike Rapoport
2025-11-25 19:21 ` Peter Xu
2025-11-27 11:18 ` Mike Rapoport
2025-11-27 14:10 ` Peter Xu
2025-11-30 11:05 ` Mike Rapoport
2025-11-26 10:19 ` David Hildenbrand (Red Hat)
2025-11-26 15:19 ` Liam R. Howlett
2025-11-26 16:49 ` Nikita Kalyazin
2025-11-25 18:38 ` [PATCH v2 4/5] guest_memfd: add support for userfaultfd minor mode Mike Rapoport
2025-11-26 10:25 ` David Hildenbrand (Red Hat)
2025-11-26 15:22 ` Liam R. Howlett
2025-11-26 16:49 ` Nikita Kalyazin
2025-11-27 10:36 ` Mike Rapoport
2025-11-27 11:19 ` Nikita Kalyazin [this message]
2025-11-27 19:04 ` Mike Rapoport
2025-11-28 12:15 ` Nikita Kalyazin
2025-11-27 11:27 ` David Hildenbrand (Red Hat)
2025-11-25 18:38 ` [PATCH v2 5/5] KVM: selftests: test userfaultfd minor for guest_memfd Mike Rapoport
2025-11-26 15:23 ` Liam R. Howlett
2025-11-26 16:49 ` Nikita Kalyazin
2025-11-27 10:39 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13d3a7a4-5cf8-4fbe-8dba-d565525a71c6@amazon.com \
--to=kalyazin@amazon.com \
--cc=Liam.Howlett@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jthoughton@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox