From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52D7FC83F27 for ; Wed, 16 Jul 2025 08:20:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7E2B6B009B; Wed, 16 Jul 2025 04:20:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E55C96B009D; Wed, 16 Jul 2025 04:20:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D44206B00A1; Wed, 16 Jul 2025 04:20:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C22776B009B for ; Wed, 16 Jul 2025 04:20:34 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 95DE21A029C for ; Wed, 16 Jul 2025 08:20:34 +0000 (UTC) X-FDA: 83669431188.29.80AB611 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 4E65AC000D for ; Wed, 16 Jul 2025 08:20:32 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RCZVmql2; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752654032; a=rsa-sha256; cv=none; b=7N3dSUjLmKqlIE02VeWcF9/mhDNxIu3YeSwX5fTvu5XxfeEl2vHDHDHjYZLwfde27bJp0T uV0q5b77AsmJQ0S4g9D+2Z42+WRKKpqqIt6hqy2bPD2dlxXutsb3ewERk+SRS7kcLDqkBb mOUS1VPKLYY914XYW8m5i6Xf/aBvWc4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RCZVmql2; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752654032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hKPb3FYVzFfrjo/nSEr903PTnJ+H6/4JdqXYfPo/qsQ=; b=iHvRK5xsBz5zxj/CCpzeDOToIzuGb7QPPFQ/LCF8NZCtVmPwNdiMNEWVJHFqB90/vJTypb PJNsaV8XYwnLS8KrSpxs6CJ8U4ZRSLWnMN0Raqx8HzN3eQgvdSYXmbx996sszAYd3xiCJh 0GGGErDt7FpQN9rbrDLBGE4ByFc65io= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752654031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hKPb3FYVzFfrjo/nSEr903PTnJ+H6/4JdqXYfPo/qsQ=; b=RCZVmql2VSbCJKJmB+5GM5gRK2nlYjhZWaChQb/kvsUwEoP5nD6jFojNCTmoODsAuZUwBQ +B/XMQP3pw+BQi+TM0ah62IcdIpFaLgtUOUSZfOYRXn4IE6qw5mMAuSTgYOBCr/3lDAxes shZZZk3lvYdPTT53wbOgTuko/jhJy8I= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-434-0-P-sOyRPnK8Zq6bZLP2jw-1; Wed, 16 Jul 2025 04:20:30 -0400 X-MC-Unique: 0-P-sOyRPnK8Zq6bZLP2jw-1 X-Mimecast-MFC-AGG-ID: 0-P-sOyRPnK8Zq6bZLP2jw_1752654029 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4562985ac6aso14053075e9.3 for ; Wed, 16 Jul 2025 01:20:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752654029; x=1753258829; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hKPb3FYVzFfrjo/nSEr903PTnJ+H6/4JdqXYfPo/qsQ=; b=VfGohmPSv13rGXiHKyXwDkTqCtcCw6AIIQAAvg0x/liWxZmGTOunZR2u9ri6T25uHg X1iCBs2J4t/BaB6/Gal+xSfB3cwexZERDOOIoes/gypbTa34ftuIqDzguHN+VUNAfzsJ cgoyu+lS1e1Y5NoEmHsOopdR3rYZG/6oOOiBra3C014Y8MkFW5KCV3TD5TwpjxRKh0BB ESRP3D3v3YfOP4n26F5HBEz2s08y0OLF6cyh8xP2IbEhrjhXyHyD+gqq4yofiLcbtYca QUCcymoNM6Jxqe4T6dxu7A3s84XZNYxSGvAKc/1MrkXjS4M0rJxW7DAyDk2sGjKgoabk IhJw== X-Gm-Message-State: AOJu0Yzb104k0J0xyvRo5PkW5c8TntF1p1mEHZb2witAg6jOinBIxlXA hD/Vwn5OqtYFKVtStyoeW2x/7JHhhhPiE5F8nI6ADhScswEUBZZDUiQEZADtXYpwYINeeQi7+oM 9mtGln0fKZdSd7cK3vNKewX2O8j3VgYwh1UcPlR6An16ckm8/YKSF X-Gm-Gg: ASbGncsMDC94nWdYA/e+7gHN0hraJbt+pylaekoNz1coPxohUTAqGQS/YdM2070bEEF l1kZYV32xlxrIOwMgfAZFWYbdkyJ6Xm4pRBAXoeG0fblJ3ClaIT4SGjte+T21SzOFK8ELsxT6iN DjmlJ8K/VbyFKVM++4FHfwNOfwE4DiaSlCbP601s7Lgb4/IForTVN+QgiqcOCWybOsIsccEBMUQ UKsMMYZQPqFmFnj99cy8o/oDkIQbC356icY+V8WLfK4/RKzqos3jE6CjcN24Le5KOJipnu6bm56 53kqKNARFQz2x46KQV8dlK9pCKIguoqQ3qcTf+WetT8H9H5z3H33ImYNfbZZboq3Qnzv3W/6MDv YfisNI5O0IUeUnSoBN/JjKaku/4M0mguH14kS3xYmX/+qyGF5BARvI1FOy9qn09YC8C8= X-Received: by 2002:a05:600c:5025:b0:441:b698:3431 with SMTP id 5b1f17b1804b1-4562ee4428amr8903675e9.28.1752654029179; Wed, 16 Jul 2025 01:20:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPfO/crUSbh/p7Bf2c82O3FOkImgy2tCspzCYogys8HSUj89hQEyYWP4/UInuKY3Ru8/ZdfA== X-Received: by 2002:a05:600c:5025:b0:441:b698:3431 with SMTP id 5b1f17b1804b1-4562ee4428amr8903515e9.28.1752654028755; Wed, 16 Jul 2025 01:20:28 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1d:ed00:1769:dd7c:7208:eb33? (p200300d82f1ded001769dd7c7208eb33.dip0.t-ipconnect.de. [2003:d8:2f1d:ed00:1769:dd7c:7208:eb33]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4562e886113sm13312585e9.23.2025.07.16.01.20.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 01:20:28 -0700 (PDT) Message-ID: <13d1fe66-9f34-47d3-b174-516ffb706aa1@redhat.com> Date: Wed, 16 Jul 2025 10:20:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] sparc64: remove hugetlb_free_pgd_range() To: Anthony Yznaga , davem@davemloft.net, andreas@gaisler.com, arnd@arndb.de, muchun.song@linux.dev, osalvador@suse.de, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com Cc: linux-mm@kvack.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, alexghiti@rivosinc.com, agordeev@linux.ibm.com, anshuman.khandual@arm.com, christophe.leroy@csgroup.eu, ryan.roberts@arm.com, will@kernel.org References: <20250716012611.10369-1-anthony.yznaga@oracle.com> <20250716012611.10369-2-anthony.yznaga@oracle.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20250716012611.10369-2-anthony.yznaga@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PrQfRPslTk1hjmXWgNKeV3fhG-VtfYrAmcYVV-XS3xc_1752654029 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4E65AC000D X-Stat-Signature: m1wy91h58qqkzb5fc68ys7wguqoncwnm X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1752654032-964731 X-HE-Meta: U2FsdGVkX196GbBEa3PHA7coN5HYnBCCxvw7esjpDcB0JOJG6/SIvDTR96Eu5awqNMpo9Yvx04N3Pz5iCZ8nzLe51cJD4+JaXT8Cv+F0YHd0aB73b/aKmQd4rtJpIngJp3nsKhE9hEVCzyo3CiqhLp5sV6EOvztrYZW51sieOugv6dzq1V92Fkj4n+Z7iX5ATpxT0Ei9nrXt13DQ74gWyNpTix0wXO/aTcppgiCW/kQ4Q8s1UhbdfBdW9sVJGw1Vb70kh5OOC3OXgX696wkG5cffvE5rFcTqAa7o0SVo/BJjwwGbalRrARv+30nNRO7+UAV0gbhIGay+ptDPdzUWWcxzajc2TTpjqoTIOImwPjdqBiVI3bNV7Q12+UbVR0R0YwzVZNvHRVNm4cGAdUjCwA7BWcesZCJd2R4txu9xanrLBEMBrQfELK3RM6OQc7aEYMg989Gv11SkKntpkQNZK+cTI0zHd/KDXa9iOfoqlt5HGgq5uFngd1U4/H/T5DjWXKhMUgn20GLL6UnMO/OEFRvyagJBS5PjVn13FoUBn34QO12GPZKzWkx1Y9d4f9uTBAdPOHDIL5Ix0b0bY8OR5MvVCLiKTd9QlCrXZ8kCfHUG2fP/UIiK94Nm3z/6DG/7xX2Y1PuxFLBr7/ui6QU9SGj2kxvgjY74XBiEy3ko00MfgZpz3M+JWDbH70bO9lVk3/xjIUyYFa1RGCc3Yo0XkWafxa68FVBiyNm37//wRufCwKQ+fCMtNPyWIFIT8o0l1iW9cBmI6XQTWlz5IJBi5A2ML6SgLzsgKF6vQAbREgmPBc1CDj6Rrm60a3c1ciHRKMb/YFIZFQ+gzgz4LFt3ScEiQFvm0Csg24I80crxR6xpK/u76JrL78s07s4P9uuqta4kfDA/QRpZuFYLdI2RNEICV1AH0oVpLXXJAQO+nhHVqIKfNzRDSDuK8Ue/TFAJ1X/Ji59sAAoytlhEv9T /vhGGrs+ hiSAutSyXAUvkh7yxJCAXpujFsZPuqtsHzmtUeX0tSxpwRfB1SPLrgRNE7GKQ+V9xopK5ATszY8AVClHZDIjFU2KoykdnO42hIDwWPLjO0FcL6Ajpk18xFIbfoheu+0BubBvHAeDvoKFBZBINp/9vnxGvXlfqUhFV0b/owHYtE1V/hfwh0oGWDduTP5BjAHe4dvxGUTHQ2k3iv4gg3GYVzPXBDU6lO4SvH1/MddVg1QwpD7puxNPO6WPzEXo+FjIG2Q0vdDtWlXTXkIeS2vWpHDpPZ9McZjX4b/6oPyfyyunfFQ1WewJ/CkD6uby5Qyol4EYFxYQEGDTkftv8nFhFS+5I5sfvm2CS7eyRCJbEZ7VaUf3++A7NxFEnDYhltjY/50w8dyL5i7uEzFCdjKW4QTpbrOpFNNSu4JaGeuBbwdWfbZww6b/mcFt15fHhoUQMqzQ+gRnQHArhdwprICmSRMjwW77TIcQjzT+/CzCo7Lu2IVEMIEfQbiccqQPfOy2N5v8x59Af3L1KRmXHcv01M3BzfqA17UOZHDkV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.07.25 03:26, Anthony Yznaga wrote: > The sparc implementation of hugetlb_free_pgd_range() is identical > to free_pgd_range() with the exception of checking for and skipping > possible leaf entries at the PUD and PMD levels. And the pgd loop was optimized out, because probably not applicable. > These checks are > unnecessary because any huge pages have been freed and their PTEs > cleared by the time page tables needed to map them are freed. Do we know why that handling was added in the first place, and why it no longer applies? These is_hugetlb_pmd/is_hugetlb_pud are rather weird on the code path. Looks like a very nice cleanup. -- Cheers, David / dhildenb