From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8131FC43217 for ; Wed, 2 Nov 2022 09:14:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 149488E0002; Wed, 2 Nov 2022 05:14:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F9988E0001; Wed, 2 Nov 2022 05:14:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F04AD8E0002; Wed, 2 Nov 2022 05:14:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E1CB58E0001 for ; Wed, 2 Nov 2022 05:14:46 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A8CB14118A for ; Wed, 2 Nov 2022 09:14:46 +0000 (UTC) X-FDA: 80087942172.06.17EBB6C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 51796140005 for ; Wed, 2 Nov 2022 09:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667380485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XFG3X5y9S7va/OVhuAw/JvhOPfXEnrd2/y2bVN5C4mk=; b=ElYy6pSM1Zn/Sdy/7r88Z4EZfMJomRJaM+YUSmfmudN8NB+qq4N6wVHEWBnYraQ6SgKR5H X7lJJZfLl6Ne2jYaj1rQCXbLkrq83FLyx+23iKpsVfRkVKoPitDEoGY1nsP95nYYb5Ux+d BOzEpUGV/g9jEUeBS8MKj5RBQ9S+8eA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-163-DNwhhDxQN4S0tP7h2Yjn4Q-1; Wed, 02 Nov 2022 05:14:37 -0400 X-MC-Unique: DNwhhDxQN4S0tP7h2Yjn4Q-1 Received: by mail-wr1-f71.google.com with SMTP id d10-20020adfa34a000000b00236616a168bso4621681wrb.18 for ; Wed, 02 Nov 2022 02:14:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XFG3X5y9S7va/OVhuAw/JvhOPfXEnrd2/y2bVN5C4mk=; b=ybgoGf6H+mjy0URYQZFYbH1DV4hadgKm7G/dt4BcQZf22gmP3Hy5HlAikWNQTg1wr7 PCHlE4LE5PJEH3RPUKbo07O4PCue11GYDS78ZVAafiJwKdkev+BrqPhMAUQyjFOkFeWv cOY8i748Zb4nEs1yBQ7dZ/uHA27X7pqkmPkuuvec5CMzKacEgw4TWd9CORYmRSiA4QH6 DDNHtisLQJiZENpk16wgmgQI84vL7/2q+PFYTdDOdyEL5NM5IXzYl93xmCkxEvizLkce 0sr8uONWnGirgdsXUwZ8KKLcnTk0l64GtBPFimzaEpiFAX/cLQKg1uMJ2dhDkOj8USxw FXkA== X-Gm-Message-State: ACrzQf1ONeKulPVdc1eouLj1F6GUxcAnbUqVnWICaw1OC2Xb7VXfgHVB dcmfez/e6Tr5eiYl/V3QuC/Jcryxwb2wmbaoFQAAaY/OEoB9NsOuV6W1DXozS8hObdDKJKXES8j EXmwvKjrJMsw= X-Received: by 2002:a5d:67cf:0:b0:236:6f36:6029 with SMTP id n15-20020a5d67cf000000b002366f366029mr14216095wrw.224.1667380475875; Wed, 02 Nov 2022 02:14:35 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5yHT6EACT7euGAbQbbD1Ul7ttmBJSp82YcXjpsu9Gih7KBgsTkA/cMIhPwxyCfSuN3zvrMMw== X-Received: by 2002:a5d:67cf:0:b0:236:6f36:6029 with SMTP id n15-20020a5d67cf000000b002366f366029mr14216067wrw.224.1667380475623; Wed, 02 Nov 2022 02:14:35 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:f100:af38:1d1f:66f4:48c7? (p200300cbc705f100af381d1f66f448c7.dip0.t-ipconnect.de. [2003:cb:c705:f100:af38:1d1f:66f4:48c7]) by smtp.gmail.com with ESMTPSA id h17-20020a5d6e11000000b002356c051b9csm12188701wrz.66.2022.11.02.02.14.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:14:35 -0700 (PDT) Message-ID: <13c0caee-82e9-c295-b1b4-6d2bff132b72@redhat.com> Date: Wed, 2 Nov 2022 10:14:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 To: Jason Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mike Kravetz , Peter Xu , John Hubbard , syzbot+f0b97304ef90f0d0b1dc@syzkaller.appspotmail.com References: <20221031152524.173644-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v1] mm/gup: disallow FOLL_FORCE|FOLL_WRITE on hugetlb mappings In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667380486; a=rsa-sha256; cv=none; b=Ef+ztZzzN5wEGsaICtSE/YnqwHG/PzQ1o3HWbVvk63SjBsD1k4izRjG1I77iqnAfnfsLFo ROhXz8oKlqQpmOFSzkmLHi6phxgJOZRYJkX1wXCwjw13mFlowggUgEvoumVuiFtcGl65o7 +QrnW3JvOxWSotuoPedXcNKqZywT1js= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ElYy6pSM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667380486; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XFG3X5y9S7va/OVhuAw/JvhOPfXEnrd2/y2bVN5C4mk=; b=1yndhfk8yDnh1YSTAUTaxUqe6EOpOJp5PkkGOYqq/bRQrmDVQwqNnN9dxAaBfwKF51mFKX V5GuOxv2Nl44nADGnzpR1O1Mov8TkKIcqYB3rsTxs57Ab00nhSNTixtbHPOPW+j/a095GS nlQAJFspUFnhrNNgQ4P6NAkni4bWUnM= X-Stat-Signature: xjdocjfypmgs1st84m6uoiegadft1jwg X-Rspamd-Queue-Id: 51796140005 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ElYy6pSM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1667380486-302774 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.10.22 17:14, Jason Gunthorpe wrote: > On Mon, Oct 31, 2022 at 04:25:24PM +0100, David Hildenbrand wrote: >> Cc: Andrew Morton >> Cc: Mike Kravetz >> Cc: Peter Xu >> Cc: John Hubbard >> Cc: Jason Gunthorpe >> Reported-by: syzbot+f0b97304ef90f0d0b1dc@syzkaller.appspotmail.com >> Signed-off-by: David Hildenbrand >> --- >> >> I assume this has been broken at least since 2014, when mm/gup.c came to >> life. I failed to come up with a suitable Fixes tag quickly. > > I'm worried this would break RDMA over hugetlbfs maps - which is a > real thing people do. > > MikeK do you have test cases? This patch here only silences the warning. The warning+failing is already in 6.0, and so far nobody (besides syzbot) complained. RDMA (due to FOLL_FORCE) would now fail (instead of doing something wrong) on MAP_PRIVATE hugetlb mappings that are R/O. Do we have any actual examples of such RDMA usage? I was able to understand why this case (MAP_PRIVATE, PROT_READ) is important for !hugetlb, but I don't immediately see under which situations this would apply to hugetlb. While we could implement FOLL_FORCE for hugetlb, at least for RDMA we will be moving away from FOLL_FORCE instead --- I'll be posting these patches shortly. So considering upcoming changes, at least RDMA is rather a bad excuse for more widespread FOLL_FORCE support. -- Thanks, David / dhildenb