From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAA30C001B0 for ; Tue, 27 Jun 2023 05:47:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EBB48D0002; Tue, 27 Jun 2023 01:47:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89B238D0001; Tue, 27 Jun 2023 01:47:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 762038D0002; Tue, 27 Jun 2023 01:47:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 65E808D0001 for ; Tue, 27 Jun 2023 01:47:54 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 276DA4087A for ; Tue, 27 Jun 2023 05:47:54 +0000 (UTC) X-FDA: 80947446468.08.AC2B069 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 3BCBDC001B for ; Tue, 27 Jun 2023 05:47:52 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=CKCXCuWl; spf=pass (imf22.hostedemail.com: domain of groeck7@gmail.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687844872; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bjTPMlxWt9nC/sXrGsrew1h8LID7KP4FRrxfXfknacs=; b=AzGNQK4CjGKraEzH1qj0beebpmXneYddnTkRF+1qozN4UE/BO0ObYBbishIieyCwqn0ARE I7mlpbiA2bGsf+iG6EuUn+CqfYXsB4A5vqEuAStKtxLUhO5LbhF97Rv0faWl4B95pC8lmw lXTr2C+/LOn26pEufT1WX27Kp8dbnBo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687844872; a=rsa-sha256; cv=none; b=G3te1zhTitC3UGjTnBwcPoV2PbnqCJ+EvyvZXuely5F8MRbRuQswJUhoX9BEQuSVGTmV5M 3yzZhTWzLmdHvYJlWUsFyvo76rH2BbKB7XuII8jaoEKAN3IBiTFyXLjkB6FX+1kPmvAn4M rFXMyiCr7lpFNKyxZEkqPWEbNzHrKEk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=CKCXCuWl; spf=pass (imf22.hostedemail.com: domain of groeck7@gmail.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-55767141512so1767489a12.3 for ; Mon, 26 Jun 2023 22:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687844871; x=1690436871; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=bjTPMlxWt9nC/sXrGsrew1h8LID7KP4FRrxfXfknacs=; b=CKCXCuWl0gYpQ4q8YGqBYIHt4kiR1AhHpEiDPYQrq6u+C1EcCN199Rf+TEI2yZgN+R yHF4vksLQaZZNCW1AKLUCeBUhO/zz1T+Q9/6Dn0kQ15ZW6K5TqPmtUB9rSpHUKgxZgiA HSTUVKDZ4xM6L9+zGQEVzY8EH5rZJBCsvXHjcbbzvbKrE2StJxwwReSDEN5b3GfPvLfH eqtt0xPcEOboGwjNakJZJtyOpw0n8CltvqJLvaWUUnjMuBH5yNe38AlJDiG6mzZTOhDy hB/teSyin+eBzVwUgFatWumtP7LykGuBvZNNj+IJUNFfPVWNZBZUcFVQKEBMH4tHKOww HTig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687844871; x=1690436871; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bjTPMlxWt9nC/sXrGsrew1h8LID7KP4FRrxfXfknacs=; b=CoQdicF8Tqe7WQYGGOA0o/1ZV9c4vbUDkX2CcawdxBTwUfIWqRoV7q53naWxqD1u05 HQRzwJgsZEl4rRUodk4uNnQ15kNJVUvZVdD9L5xZ4pTmBs+UwLStb4s+TaqxOPd1uGgT 62AddHUSZC86yu9aRjWYYNNUgMp1vXMrLP1u83XtchZbyaVtXEGCzXK+6bh/GDNiW06D 8HEneYK5hiPpLhiSiMFC23rPpwTdXaNCkXZhEfOGVcfBYv/NLG2q+hrEvixYSj00VITX a/S8PCvOu7wt9fFFnVFt4bwnSY16b4rLbAdgfqRfn/6b8LVuF0/JCSsGAiHyX9C74SpD CLig== X-Gm-Message-State: AC+VfDxzkXVBaNsDAGwbfhMsWxQ8c5hBaVNNnP9Ii70K2IvVxJiNoQHL fxRhLE4zMz+iEe6rndoBFTk= X-Google-Smtp-Source: ACHHUZ7JjW8b6fgOe+JthCsQbs9/NjABXgCew6ba8g3n2m02um8mxuD9LeyNll8XOwuywhMwRgh5kw== X-Received: by 2002:a05:6a20:7491:b0:126:8ddd:d786 with SMTP id p17-20020a056a20749100b001268dddd786mr5575003pzd.46.1687844870738; Mon, 26 Jun 2023 22:47:50 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id je5-20020a170903264500b001b8004ff609sm3033756plb.270.2023.06.26.22.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 22:47:50 -0700 (PDT) Date: Mon, 26 Jun 2023 22:47:49 -0700 From: Guenter Roeck To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , Dinh Nguyen , Mike Rapoport Subject: Re: [PATCH v5 26/33] nios2: Convert __pte_free_tlb() to use ptdescs Message-ID: <13bab37c-0f0a-431a-8b67-4379bf4dc541@roeck-us.net> References: <20230622205745.79707-1-vishal.moola@gmail.com> <20230622205745.79707-27-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230622205745.79707-27-vishal.moola@gmail.com> X-Stat-Signature: igz5pscxr3yisd9bmhoyeozysbchfmgs X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3BCBDC001B X-Rspam-User: X-HE-Tag: 1687844872-975502 X-HE-Meta: U2FsdGVkX19ncNeASiEb9983p57T8/O/psGFkjUR+FK2+Vj/6dc4FRPjIqfXg01Nao13ExqErzG6UR8HQzmflbCm0OKMZZ0x6LltN2kPEXkpRH/8EbSpdqXPl4L8H1zu8OklDGi3U5Pwq/DHVkcq2l8/JvJe6LvzTCjuuiLI12jJx8z0VwkhROX3MuTxDV7tsMCU2YkfbW+D33klCFcCmQrC7oHPHre7RLKlC5M610I08bL/awCfd6QQHuk2d2hBC6AkMe/WfP7Awo5Dh4G8RDl9FL4WxghPkst8nJgUm26JDm6lkaKhwqSPqS9eYJ2c93+xllXrrV5qHu2IP6Q/Mau42tzQO5BxlsF3zs6IJ7mmaKd/Op5ycsDuzQLpIF48QD8Bl0IxhD2a3TP/ZSjx3cCbq9AfxSbpwB0PUG+dNX5L8bSJWKUUcBbiUDYEjlUW0npA+qIYGlIEm7Fkfo9sjTjHl4HyHDbQbEHZVof1DoYv10gMRbxEzp0p9LlNZqjuin3bzdktFLCrgKiE9znqBYNDaSMU90keSCJ/jliK9cXrUGhKCy7trxXeAeffJs17bIiJ3akA9tA0rH3cFGiM8LDkrtyauW1q2pl/63b3tZyAlmhXx5C6xYmoh9jLe+h6cbtOtQT0vcStP5pdVN8gjWy+PKWBub+N1dXXWWH/PPtt/xkeDvrMC4guxkZQ6DiwBsth8/IKJGcX4s2adMtnpjzMWmsLq5gEstF7n2u4ZXVy+dI9Cis6lje+vAKD0V67gVf/LVT2XQ7lTXKisyCGEczeOrcepSBYz+rC0ut9EezBJBgfQ3pfbfEKdv7EwmK1dUfa4MF/PxzaETtGSMiyCEpuTn8xl6qDd5USMUcF26MoxNhU2iCRPpDdFB2f0hfXoJn7XumtGuAU46vpHELE2PDZorHtFKjhh4BDgB5FdHn4CJEJvHRvp5PK5WtXrgnJKPC3QUdRQq64haLfQvG txau7tzg 0kGf+fEsR+Q+ox9HVTNVtO9Il/2c+RJxROsJphQDXHuKwyp6UizTtFG1znsBQrf/qIbLwsaMPIaHBivqQGx1qin3MY0C9CsakgskZQJj+QTIfzDjCjfIJbWW+1p7KmzhCaGsFX4YsxMEUV/eq0OsySHRsFrufBMmkigbGu7VfqICm23wHkf0V162AUbYnCfR+zA3DU1uZjC/K/uk4+TTZY9A++go3piHnERfgjEhBtOLeFeFeS2abel1GDstVvIf//MpcbpebGXgpeh8sUMI2LVHHcsFraGXos+5I0G5klRA6xLtTOAoVIKrqbOWHzKaXYXRToPRpdEJqvG5ClN18MDMH6ssa2WDzlZ7KZDPc/o9ucykhxiTcWDa9i9H9fgxHwzPwhVTE7dfuZTJT8MRyJIWFrAr5GFWow4a6K8kJKBHJs5s+dc/FvXLmZq3vyOyRvBLNHdujpb/rlNrx1dIiI41U8bcQb8Z7tU0DWYPhkZtKSBgppqr1TWCqxhbzPCS3CZzqUHk/JdZE1v5vjb3o5Gtva6XapTAQwhqhAhefxJ4dtyAt1IVXVbq+Cipn72PYnBmmrXy3k/UzU94KGuKm4JngrTIqPNCFwihohDzFRxWUTGxKD/vmVb10yQz1HFgSIlQjQEEWM1h85DoHiG5IKKv71PzHxleFvB9d46HfnH2Bce8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 22, 2023 at 01:57:38PM -0700, Vishal Moola (Oracle) wrote: > Part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents. > > Signed-off-by: Vishal Moola (Oracle) > Acked-by: Mike Rapoport (IBM) This patch causes all nios2 builds to fail. Building nios2:allnoconfig ... failed -------------- Error log: :1519:2: warning: #warning syscall clone3 not implemented [-Wcpp] In file included from mm/memory.c:85: mm/memory.c: In function 'free_pte_range': arch/nios2/include/asm/pgalloc.h:33:17: error: implicit declaration of function 'pagetable_pte_dtor'; did you mean 'pgtable_pte_page_dtor'? [-Werror=implicit-function-declaration] 33 | pagetable_pte_dtor(page_ptdesc(pte)); \ | ^~~~~~~~~~~~~~~~~~ include/asm-generic/tlb.h:666:17: note: in expansion of macro '__pte_free_tlb' 666 | __pte_free_tlb(tlb, ptep, address); \ | ^~~~~~~~~~~~~~ mm/memory.c:193:9: note: in expansion of macro 'pte_free_tlb' 193 | pte_free_tlb(tlb, token, addr); | ^~~~~~~~~~~~ arch/nios2/include/asm/pgalloc.h:33:36: error: implicit declaration of function 'page_ptdesc' [-Werror=implicit-function-declaration] 33 | pagetable_pte_dtor(page_ptdesc(pte)); \ | ^~~~~~~~~~~ include/asm-generic/tlb.h:666:17: note: in expansion of macro '__pte_free_tlb' 666 | __pte_free_tlb(tlb, ptep, address); \ | ^~~~~~~~~~~~~~ mm/memory.c:193:9: note: in expansion of macro 'pte_free_tlb' 193 | pte_free_tlb(tlb, token, addr); | ^~~~~~~~~~~~ arch/nios2/include/asm/pgalloc.h:34:17: error: implicit declaration of function 'tlb_remove_page_ptdesc'; did you mean 'tlb_remove_page_size'? [-Werror=implicit-function-declaration] 34 | tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ | ^~~~~~~~~~~~~~~~~~~~~~ include/asm-generic/tlb.h:666:17: note: in expansion of macro '__pte_free_tlb' 666 | __pte_free_tlb(tlb, ptep, address); \ | ^~~~~~~~~~~~~~ mm/memory.c:193:9: note: in expansion of macro 'pte_free_tlb' 193 | pte_free_tlb(tlb, token, addr); > --- > arch/nios2/include/asm/pgalloc.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/nios2/include/asm/pgalloc.h b/arch/nios2/include/asm/pgalloc.h > index ecd1657bb2ce..ce6bb8e74271 100644 > --- a/arch/nios2/include/asm/pgalloc.h > +++ b/arch/nios2/include/asm/pgalloc.h > @@ -28,10 +28,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, > > extern pgd_t *pgd_alloc(struct mm_struct *mm); > > -#define __pte_free_tlb(tlb, pte, addr) \ > - do { \ > - pgtable_pte_page_dtor(pte); \ > - tlb_remove_page((tlb), (pte)); \ > +#define __pte_free_tlb(tlb, pte, addr) \ > + do { \ > + pagetable_pte_dtor(page_ptdesc(pte)); \ > + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ > } while (0) > > #endif /* _ASM_NIOS2_PGALLOC_H */ > -- > 2.40.1 > >