From: Daniel Sedlak <daniel.sedlak@cdn77.com>
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Neal Cardwell" <ncardwell@google.com>,
"Kuniyuki Iwashima" <kuniyu@google.com>,
"David Ahern" <dsahern@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Yosry Ahmed" <yosry.ahmed@linux.dev>,
linux-mm@kvack.org, netdev@vger.kernel.org,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Muchun Song" <muchun.song@linux.dev>,
cgroups@vger.kernel.org, "Tejun Heo" <tj@kernel.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Matyas Hurtik" <matyas.hurtik@cdn77.com>
Subject: Re: [PATCH v5] memcg: expose socket memory pressure in a cgroup
Date: Thu, 9 Oct 2025 16:44:04 +0200 [thread overview]
Message-ID: <13b5aeb6-ee0a-4b5b-a33a-e1d1d6f7f60e@cdn77.com> (raw)
In-Reply-To: <87qzvdqkyh.fsf@linux.dev>
Hi Roman,
On 10/8/25 8:58 PM, Roman Gushchin wrote:
>> This patch exposes a new file for each cgroup in sysfs which is a
>> read-only single value file showing how many microseconds this cgroup
>> contributed to throttling the throughput of network sockets. The file is
>> accessible in the following path.
>>
>> /sys/fs/cgroup/**/<cgroup name>/memory.net.throttled_usec
>
> Hi Daniel!
>
> How this value is going to be used? In other words, do you need an
> exact number or something like memory.events::net_throttled would be
> enough for your case?
Just incrementing a counter each time the vmpressure() happens IMO
provides bad semantics of what is actually happening, because it can
hide important details, mainly the _time_ for how long the network
traffic was slowed down.
For example, when memory.events::net_throttled=1000, it can mean that
the network was slowed down for 1 second or 1000 seconds or something
between, and the memory.net.throttled_usec proposed by this patch
disambiguates it.
In addition, v1/v2 of this series started that way, then from v3 we
rewrote it to calculate the duration instead, which proved to be better
information for debugging, as it is easier to understand implications.
Thanks!
Daniel
next prev parent reply other threads:[~2025-10-09 14:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 12:50 Daniel Sedlak
2025-10-07 20:01 ` Tejun Heo
2025-10-08 12:46 ` Matyas Hurtik
2025-10-08 18:17 ` Tejun Heo
2025-10-08 18:58 ` Roman Gushchin
2025-10-09 14:44 ` Daniel Sedlak [this message]
2025-10-09 15:32 ` Roman Gushchin
2025-10-09 16:06 ` Shakeel Butt
2025-10-09 17:58 ` Roman Gushchin
2025-10-09 18:32 ` Shakeel Butt
2025-10-09 19:02 ` Roman Gushchin
2025-10-13 14:30 ` Daniel Sedlak
2025-10-14 1:43 ` Roman Gushchin
2025-10-14 13:58 ` Daniel Sedlak
2025-10-14 20:32 ` Shakeel Butt
2025-10-15 13:57 ` Daniel Sedlak
2025-10-15 18:36 ` Shakeel Butt
2025-10-15 18:21 ` Kuniyuki Iwashima
2025-10-15 18:39 ` Shakeel Butt
2025-10-15 18:58 ` Kuniyuki Iwashima
2025-10-15 20:17 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13b5aeb6-ee0a-4b5b-a33a-e1d1d6f7f60e@cdn77.com \
--to=daniel.sedlak@cdn77.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=hannes@cmpxchg.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-mm@kvack.org \
--cc=matyas.hurtik@cdn77.com \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox