From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E08EEC433EF for ; Fri, 1 Jul 2022 08:01:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D9BF6B0071; Fri, 1 Jul 2022 04:01:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08AB26B0073; Fri, 1 Jul 2022 04:01:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBA6B6B0074; Fri, 1 Jul 2022 04:01:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DB8BE6B0071 for ; Fri, 1 Jul 2022 04:01:00 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A3A2E60E63 for ; Fri, 1 Jul 2022 08:01:00 +0000 (UTC) X-FDA: 79637785080.30.2151048 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by imf19.hostedemail.com (Postfix) with ESMTP id A2A931A0005 for ; Fri, 1 Jul 2022 08:00:58 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VI.Tio9_1656662454; Received: from 30.97.48.59(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VI.Tio9_1656662454) by smtp.aliyun-inc.com; Fri, 01 Jul 2022 16:00:54 +0800 Message-ID: <13b2cc16-fb1a-eeb8-7a15-d20f4ba42a48@linux.alibaba.com> Date: Fri, 1 Jul 2022 16:00:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [RFC PATCH v3 1/3] mm: Factor out the pagetable pages account into new helper function To: Mike Rapoport Cc: akpm@linux-foundation.org, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <9c527d4d2eb1f457306e575ce16c6acdd8141e02.1656586863.git.baolin.wang@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656662460; a=rsa-sha256; cv=none; b=LWLjBvV7ffQdivNFeS9/kbOmiMZExNRJUrj+r8laMCzUy4QJDO3Yej5W68oF6jk2HMXg4S +16dhL+ZiB0jUdYvawUv2twi+tWlhTDNo5vz5guKUt+QEXNnwfu0+PDr/N/+XJLI18HEW8 WyT8Cd3c6hADvTC8iTlDNIc+itFhMSA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.43 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656662460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NXENSC66aOa8HH3Z4I90cM9NDOdCFwxEVvKdvmo/pPo=; b=vm6SjaYIpunw8sQMtk3D1T3ZlO2vOHRZ3Pk+MedW2jhXmcLWCNvJfNejITCGi9nv+W42Gt bFz/wlmHi77mWyKNANg6SHkJ/LOb4d6Wra2doqC67pm9pnjcJFUzszrClKqcJOTuA/j8x9 czPAom58/ewG++xaMWVwfnTkygTh51E= X-Stat-Signature: y4sa5kxfr6p55xorac6j7wkf735srtjp X-Rspamd-Queue-Id: A2A931A0005 Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.43 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1656662458-128279 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/30/2022 10:11 PM, Mike Rapoport wrote: > On Thu, Jun 30, 2022 at 07:11:14PM +0800, Baolin Wang wrote: >> Factor out the pagetable pages account into new helper functions to avoid >> duplicated code. Meanwhile these helper functions also will be used to >> account pagetable pages which do not need split pagetale lock. >> >> Meanwhile convert to use mod_lruvec_page_state() in case of non-order-0 >> page table allocation. > > These are *very* rare. I think only parisc may have non-order-0 pmd and pud > tables. s390 also has non-order-0 page table allocation, but they both do not use the generic page table allocation now. > With that, I'd suggest making use of compound_nr() build time opt-in. After more thinking, I'd prefer to change back to use inc_lruvec_page_state()/dec_lruvec_page_state(), since now no architecures will need non-order-0 page table allocation. After this patchset, I plan to convert parisc and s390 to use generic pagetable allocation, then I will add non-order-0 page table allocation support. Like Matthew suggested, maybe I need change the API to pass the number of pages. >> Signed-off-by: Baolin Wang >> --- >> include/linux/mm.h | 24 ++++++++++++++++-------- >> 1 file changed, 16 insertions(+), 8 deletions(-) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index a2270e3..3be6d2c 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -2353,20 +2353,30 @@ static inline void pgtable_init(void) >> pgtable_cache_init(); >> } >> >> +static inline void pgtable_page_inc(struct page *page) >> +{ >> + __SetPageTable(page); >> + mod_lruvec_page_state(page, NR_PAGETABLE, compound_nr(page)); >> +} >> + >> +static inline void pgtable_page_dec(struct page *page) >> +{ >> + __ClearPageTable(page); >> + mod_lruvec_page_state(page, NR_PAGETABLE, -compound_nr(page)); >> +} >> + >> static inline bool pgtable_pte_page_ctor(struct page *page) >> { >> if (!ptlock_init(page)) >> return false; >> - __SetPageTable(page); >> - inc_lruvec_page_state(page, NR_PAGETABLE); >> + pgtable_page_inc(page); >> return true; >> } >> >> static inline void pgtable_pte_page_dtor(struct page *page) >> { >> ptlock_free(page); >> - __ClearPageTable(page); >> - dec_lruvec_page_state(page, NR_PAGETABLE); >> + pgtable_page_dec(page); >> } >> >> #define pte_offset_map_lock(mm, pmd, address, ptlp) \ >> @@ -2452,16 +2462,14 @@ static inline bool pgtable_pmd_page_ctor(struct page *page) >> { >> if (!pmd_ptlock_init(page)) >> return false; >> - __SetPageTable(page); >> - inc_lruvec_page_state(page, NR_PAGETABLE); >> + pgtable_page_inc(page); >> return true; >> } >> >> static inline void pgtable_pmd_page_dtor(struct page *page) >> { >> pmd_ptlock_free(page); >> - __ClearPageTable(page); >> - dec_lruvec_page_state(page, NR_PAGETABLE); >> + pgtable_page_dec(page); >> } >> >> /* >> -- >> 1.8.3.1 >> >