From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DBF6C46CA3 for ; Mon, 27 Nov 2023 14:51:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B716E6B02CA; Mon, 27 Nov 2023 09:51:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B20D56B02CB; Mon, 27 Nov 2023 09:51:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99AD86B02CC; Mon, 27 Nov 2023 09:51:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 894196B02CA for ; Mon, 27 Nov 2023 09:51:00 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 43C10C026C for ; Mon, 27 Nov 2023 14:51:00 +0000 (UTC) X-FDA: 81504021480.29.43B4CDD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 7350810000A for ; Mon, 27 Nov 2023 14:50:56 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I11BgyI2; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701096656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=73FvtKggjoyMfKbC/ZYzZT6bKl1Kg/bdJcdhd9AKrNs=; b=4Y5MsoYM7nqZuKQ1Q3Dd/pyJrH5g47VV3fyT2QpYx8JfCR3mHb+JCsfQ0rqZpvT/2Pa/+b RK8pU8tMpQu87O33Ex9Nv8zhVutPDm9qbSOdIy0IERAcPQdAk7om5QoX/Nckbs27k92xft oXST0RRkT6UjiCDD3oaBgqci6UGzjW8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701096656; a=rsa-sha256; cv=none; b=etbULRtqoMD0Iz4gFqrtDk1VOlK6h5PWzF6vzT01pX++sEv/MyWfGo6K0ZrZOKqKIYGqH9 dWFCOXJTAwldXOSQC7zbZqemmqtiYxrgKK8yExE17XchZvhtjv3OL2KPKt8UdkGERMhjdb t+LmHOnCGXKHeM7y3JIomvvGQJeqESM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I11BgyI2; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701096655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=73FvtKggjoyMfKbC/ZYzZT6bKl1Kg/bdJcdhd9AKrNs=; b=I11BgyI2yNfKR9ILe61HqUh10nkMYVsyNM0XuJnmuNuxwVagkwjq7/wzaAkVvF9V6bFyZJ VUYuHwg5jOiVCJLLLFD4UBhcamx5w/wPkWbzVtgio+urQN2ZYGbqE2P9/HotVmR9qQHpyb Ln6s/U9WmwwBHZ51jSZ5yeWBaQ5Rthw= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-207-6kXqEOAUOAyTzz8IXtFokQ-1; Mon, 27 Nov 2023 09:50:51 -0500 X-MC-Unique: 6kXqEOAUOAyTzz8IXtFokQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-50ab7b85b6eso4560990e87.3 for ; Mon, 27 Nov 2023 06:50:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701096649; x=1701701449; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=73FvtKggjoyMfKbC/ZYzZT6bKl1Kg/bdJcdhd9AKrNs=; b=v6EG0kudEGtJx7srp2ukgO0PLAHkWWck1TIx3iqA5AAAUdbdPdnUTRBzZCpXCjLxhx LCZLHQDEFxGxnZPjaZy4yB3osXwVpTkgJm2a1JYYzO9uUOipOtK+ephNq1Sqlgov2FEF bdDZOEBIO4znWquNbJSBb4TTnLg5iz2lHRP6RWSt4Kbn4PL9hAnI0MA3BW8aU8JtGvvt FbW3+RSln5kNxJ3Vs3oM42WD8xASmG3WsTpHWccw6/iDhrix0qkbqhdZKSA7d/SochTk FvnevhvrQPGUZTLMzo7EnAxXV++NWthOajWGVl1ramSzHotdrok4suNFfbJwkT7HarWr iulg== X-Gm-Message-State: AOJu0Yxe1L2hzpPZ43lxbYUQEpPHONQcG1pOYyqXh7FTtK5SE+cxeSmP B5MzB96hJCRWvoMl1p5Ldnf3ouN51yqJwSfJiQMOVwekEWYFvBVxDI3c/h3GBGh8bzie3Ku4reb 3qZF5rBMe1G0= X-Received: by 2002:ac2:4346:0:b0:50a:93f9:d09f with SMTP id o6-20020ac24346000000b0050a93f9d09fmr7046853lfl.62.1701096649531; Mon, 27 Nov 2023 06:50:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IGaEPDDSC6UEFhTnN/EmILYfQnxYUKO7/scqotzhaeDU1Eagj8lom90aNnSOn6VPZA6pZhdzA== X-Received: by 2002:ac2:4346:0:b0:50a:93f9:d09f with SMTP id o6-20020ac24346000000b0050a93f9d09fmr7046841lfl.62.1701096649123; Mon, 27 Nov 2023 06:50:49 -0800 (PST) Received: from ?IPV6:2003:cb:c745:2a00:d74a:a8c5:20b6:3ec3? (p200300cbc7452a00d74aa8c520b63ec3.dip0.t-ipconnect.de. [2003:cb:c745:2a00:d74a:a8c5:20b6:3ec3]) by smtp.gmail.com with ESMTPSA id i16-20020a056512341000b00507cf5f9299sm1518485lfr.125.2023.11.27.06.50.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Nov 2023 06:50:48 -0800 (PST) Message-ID: <13a2ce75-b1c0-4930-8911-36ded0b428a7@redhat.com> Date: Mon, 27 Nov 2023 15:50:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH v7 10/10] selftests/mm/cow: Add tests for anonymous small-sized THP To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20231122162950.3854897-1-ryan.roberts@arm.com> <20231122162950.3854897-11-ryan.roberts@arm.com> <8dd0f52c-d261-4541-930f-bd4e5921be5b@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8dd0f52c-d261-4541-930f-bd4e5921be5b@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7350810000A X-Rspam-User: X-Stat-Signature: fp7df79jcxffh9qeefnqk43n9cbhci6n X-Rspamd-Server: rspam03 X-HE-Tag: 1701096656-182239 X-HE-Meta: U2FsdGVkX180q6eU2jByTp99U+/AYYluz7nB8Ax6pNo3SKy4imaJ3VN9Zxvcp4I9Q2Si1oKeEXAU6fM7hf03RGWYhmyOUwpUi6f6MMeUDRNNXcexlmkbmJ7F/pCs3j+ZuzlBMm7hYtOvWvSVscw7KfX2GqHbKVB8VAHO2/fZnQcNmwVDjGgKwOIInjWj6V5/0EwrBqb1c2WYWP2AuHwActit9ENYrPzsdUcB8SEK383EmGOFfqZOa8E127ZkdfqVo3c0YC1FGt+m6KT7RgPAUcyfoCeUuiSNmDLMFUy4dgsQt7ppfFHmmmz62zhaomKjamX7cKfNc6OD+Kl3lw/oRU5pgb0cPl4pjMuC6XiZa2kQND7dn8fN7cVb9a0GpEEsB4OSsnRoBdKxeZEYqYJPmv7DpSq4o+kBQIKX+iRZ3rIaNdyRfL/rjghbWrURiNYm4G+KWxbpvJUkfsEGN4eoeinazhx0hG+RnTpMx8xbQ1IGkPyuYzkHn9mj+zPmbKbkxsu5/1TIJYPp6B/0KYFa7kf/PHtbmri5xhp0GwHOha/nGXgj2G+9Ay9ttPfjXO9RZ3ZqPjacy6QU2vEhzDyFWNxXU9kV3uRYBYtSDsHo6/na0wNPxOvcgGmJJjwh1JJJftyN2ngqOAjkQX2FPRY+Ze/MEvkq8gdGAhctbMC0c+Yo1kMXcxQ+Z675249NYYMBO3/898EcO/PUkQ4NPsMOj4wzizN+tnr6pMD/r6SApxVfTzKU9bj3CPSnVI3rC3pt7I9YwdfllYsLdQVbr6RLnDnxnVixsMAbWDSKeISJbkgs3wwdhPlWs3TPIAyhHHOEXibNGZ9ZRCujWP0/Su0h7lxIRgpS4tHB2dTT1zWjZlcb87EsmMgf0OWa3g8fXa3i9hiIN57IfC4O8hdCH6qQZfXcZFMC/3UqTmT3MPjkPOS9xCmtFBYCQabOJBCpixCEkuG8f1fASxRfazWLwBT RpmcKqgZ 6dN4i/a3lgcDtyleRqSUXKG0OauxOE3osMM/dY8BZtwUkwHj890RlLbScFunS1XktIzSdq9gLzhcIuh+1aap+ygehRB0+U+9RKNqlFc2SBXm3BS9XmxUM+nD0ozMi7dCs/0W/Jv0CoLVZxLEh6RI1U0WDsaIYDXYlsnwJLzzGjrUMgpbIgyOh/tILS60iKQDxA4pGEp09CxPaaMndevj6r3p2g+rCB9jFlRLIMXgllKOyB1Nvczw5f3yguwwc/nuDhoKgJvkej4ryOFbh//U75171Q7YVge4kz9SzrSJNR0kqLoAo+V2uRPrUqyuBKpvqqWeSzqGqlBWsB525TPr+HdqXDRMao7qgRK7Qe2EQ+Up5kw9PqDGnZNeQiPFGFYSIXoSzHJsAZozRXpx4NSwnpep3rth6mI/38PuGgZtmtmbV7LOAc0oZpYoSkJj3sE9afHuwf9cnS6EymmhdMKYdJMhqebhocRAELsnSHnOklLPMcVCD/c6s59vks3YrztTyuEceJS+S7P3ePBKY23biKWSfp+S/bBB6u4I4UtE8O0vqHh8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.11.23 15:02, Ryan Roberts wrote: > On 22/11/2023 16:29, Ryan Roberts wrote: >> Add tests similar to the existing PMD-sized THP tests, but which operate >> on memory backed by (PTE-mapped) small-sized THP. This reuses all the >> existing infrastructure. If the test suite detects that small-sized THP >> is not supported by the kernel, the new tests are skipped. >> >> Signed-off-by: Ryan Roberts >> --- >> tools/testing/selftests/mm/cow.c | 71 +++++++++++++++++++++++++++++++- >> 1 file changed, 70 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c >> index d03c453cfd5c..3efc395c7077 100644 >> --- a/tools/testing/selftests/mm/cow.c >> +++ b/tools/testing/selftests/mm/cow.c >> @@ -29,15 +29,49 @@ >> #include "../../../../mm/gup_test.h" >> #include "../kselftest.h" >> #include "vm_util.h" >> +#include "thp_settings.h" >> >> static size_t pagesize; >> static int pagemap_fd; >> static size_t pmdsize; >> +static int nr_thpsmallsizes; >> +static size_t thpsmallsizes[20]; > > Off the back of some comments David made againt the previous patch [1], I'm > proposing to rework this a bit so that ALL thp sizes are stored in this array, > not just the non-PMD-sized sizes. This makes the changes overall a bit smaller > and easier to understand, I think... > >> static int nr_hugetlbsizes; >> static size_t hugetlbsizes[10]; >> static int gup_fd; >> static bool has_huge_zeropage; >> >> +static int sz2ord(size_t size) >> +{ >> + return __builtin_ctzll(size / pagesize); >> +} >> + >> +static int detect_smallthp_sizes(size_t sizes[], int max) > > This changes to detect_thp_sizes() and deposits all sizes in sizes[] Just what I wanted to propose :) Makes it simpler by removing the "small" terminology and just detecting thp sizes. -- Cheers, David / dhildenb