From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B7E3C83F22 for ; Wed, 16 Jul 2025 10:42:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17DDA8D0002; Wed, 16 Jul 2025 06:42:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12F138D0001; Wed, 16 Jul 2025 06:42:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F38958D0002; Wed, 16 Jul 2025 06:42:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E075D8D0001 for ; Wed, 16 Jul 2025 06:42:05 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 632D2B8688 for ; Wed, 16 Jul 2025 10:42:05 +0000 (UTC) X-FDA: 83669787810.27.4227756 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id DFAAE100005 for ; Wed, 16 Jul 2025 10:42:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ORJW5SIO; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752662522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KZvGvSA7aEFcJN8ESUaEjxX/jyrkl9OEvc1HbXBJCbA=; b=R2TBhuPYzTHoizYMxOnpgLQ6ZwT1NxscVY6YVgwfMkpSnE7630jw0vkqptVLTRhvOGmdDt J94m9ajKBxFHTeChY3YxqTwmPv/SgK86xtMjQvfHkTBfiKncJqFotsGkuCfSM0vpTXxc7W GuhvosiF+mLUvWWtJzsEVhCwLqKdENg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752662522; a=rsa-sha256; cv=none; b=zVq7OuNLo7ooAZfUK1aaWO09iKzG19lXT78rIpInrf9uGalUStahSxap89/gDLKnKH2s1x ACNDN63utBkRBWChGn2Ax6B7RY9CA5RAvRkIS9C511z27jX2R3k4LZ+QvEGtFiJwbN8iQV lKHuPxmw1e98uBJB7sIwA9a8iM4C6G8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ORJW5SIO; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752662521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KZvGvSA7aEFcJN8ESUaEjxX/jyrkl9OEvc1HbXBJCbA=; b=ORJW5SIOvqfj7QUIz6GOoquZwEq8OZggRAPQDEkCa1HNv+z6tCVgfQuxFni2z8YgremFdm u7GyszaeVXFx75o7HC+PDihzaPYsVnpKRs2HLIKjVaEXDom0ZvTW+kTfa8mUv8zk3lrpRp yg35c+DWL9rd1EZ9/z4vvKLSidR3eq4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-IdmO-lRTN36Z9KeIISVaWQ-1; Wed, 16 Jul 2025 06:42:00 -0400 X-MC-Unique: IdmO-lRTN36Z9KeIISVaWQ-1 X-Mimecast-MFC-AGG-ID: IdmO-lRTN36Z9KeIISVaWQ_1752662519 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45617e7b82fso17906215e9.3 for ; Wed, 16 Jul 2025 03:41:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752662519; x=1753267319; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=KZvGvSA7aEFcJN8ESUaEjxX/jyrkl9OEvc1HbXBJCbA=; b=dGPBK/nGR0CtFwT8UnoY3mlHO4Uqxb32ijiVmz3GPvBCPz/Mi3QMDXQAL+rf8/UPTV ORXE4us4Jlnkc2HEbW2VQU2UMMhGOg6BaBLDeAjCK9CJtRn6gco77qRx/J355IJ1D6vA GF0hSUaU55GJXIf+UJc7rFjbJcDbpGHJs+k3A1xE08ztkSe9Cxdnc3q1GJo4Lo6NNHs4 xugfXsLvGizRaXBb9yLtX0gSNgXiIdNwWRXKmjf9/hcM4BHhEHGBrazmODfzy/ygpzmv O12GPy053KrrxB3eWpTcX7FrsT8TjKtRhkMlM3CTF9GFEj9Imn2J5B4j3OKXITJ5dsEi Ad5A== X-Forwarded-Encrypted: i=1; AJvYcCXtuPS/l/K4zu43aDVrcq7HDfNMF+C5Xz8a8hQ4Tq6Qjl6gSxE/cyKFqTXmqzk4w9hzuckzNw/4XA==@kvack.org X-Gm-Message-State: AOJu0YzNb2tR+m1WLkoQ77TZ4qB0aB4Ib42kdgfS2FuGhpx7XxGCZHjB 32kspyt4SOITy+M1aInruXlnnoeCMhT2dmogmXNook90VmVBhui+OKX55KkWRGZlpPZhFJjOtEz RYX7KKuLLPfBYxE1cZFq6D0JT1mokrBPPCA/8bh14zugH+tFe1HRp X-Gm-Gg: ASbGncuUEPohhG2OJ5Vq4yIbI5TOIaI4z38UNCSESC2OyoJoPRSl49lryRs7tFmRBFP r5o55/HnldoXWlqhihlrddb27RASC4oI1fd6AeZpn836orxiiiZtybe8T2FPqkvmLmqWK6xxXzU WqkyG6rvTh2GYC/f2pMTmmSg6p7aoZJR3RHkXWF6zU10OMrqxWmmRVQsjRukFMp+VEWQZnc8Tn0 8aN3J0akr5JzffR3Uechcthc/6S+zI2GEBhhNo1nZViZX1p24Qqpe00cj9uFO1EbOoF1YzSb1vx YvJaVKLf5yJ4+gUj3mmDnt5EPwmkX+sySz4+FNlyiGgaUosI5DMnDCZM/8G2Az8l4QUJtpv32lu eGo74yfkIdiA1ZJJ0/sWbCyPz44XOl/qvEHz66oe3KOGpejUbWQBWkhFxG1alwtK/8Z0= X-Received: by 2002:a5d:6f15:0:b0:3a5:3b56:974e with SMTP id ffacd0b85a97d-3b60e4c51admr1372872f8f.6.1752662518795; Wed, 16 Jul 2025 03:41:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHjjhAa5WDswEwk0O9wV4JS64Gunk3AYrtcQlTaN7TDrrKomRBIYR6DAIAzxO0Qptve83NGNQ== X-Received: by 2002:a5d:6f15:0:b0:3a5:3b56:974e with SMTP id ffacd0b85a97d-3b60e4c51admr1372841f8f.6.1752662518390; Wed, 16 Jul 2025 03:41:58 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1d:ed00:1769:dd7c:7208:eb33? (p200300d82f1ded001769dd7c7208eb33.dip0.t-ipconnect.de. [2003:d8:2f1d:ed00:1769:dd7c:7208:eb33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e0dbddsm17753487f8f.63.2025.07.16.03.41.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 03:41:57 -0700 (PDT) Message-ID: <13a09edb-4fba-4887-a809-acd0745dc261@redhat.com> Date: Wed, 16 Jul 2025 12:41:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 6/7] fs/proc/task_mmu: remove conversion of seq_file position to unsigned To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, tjmercier@google.com, kaleshsingh@google.com, aha310510@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20250716030557.1547501-1-surenb@google.com> <20250716030557.1547501-7-surenb@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250716030557.1547501-7-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AhppTRUb_2m2R9nwvmecUvdZeyb1bKa3P2-7I-qe6BI_1752662519 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DFAAE100005 X-Stat-Signature: 43ps98e1kf8kpuuaap8i7gryig8545kn X-Rspam-User: X-HE-Tag: 1752662521-64511 X-HE-Meta: U2FsdGVkX1/QTDpaU8zhanBVIRoSamXcGoEat/N6RYoWVJqowXBB1JK6A9YUC+Qoi86QNkgg3mQ7dN9GhKQGg7J+8juFgV4YnD4aV7dmcQTTKHpFYsjawETCFCb4sbmVysMUzsXntfi3ldq83idHk9/1NUjxO+r/0IG9y8NUbqiCxq8/PXrmjlZwWTaEobFrg+TeNBOsfj/Ta1AjWJYsjLAAdDqrMKoV0I/Kk1VU14cU71VNFPey9qh4LKgCn+PH5N/HH9qkqeuvTlWXap/Sq8huphGJioWLsAY8IIHjEkjJG0w6Yvq057xdYdGilgcvASaT/gy/IgMXLRdvrb18+UZWDw3IUjszzAP2ude9JoaViOuQfcXK3Q4ujKCRZoh+A3ePTbgQFeX3NMSVPNrVmQn9/PzIS33ALQ6gqa1ylrBu12JEdJbpuMG27l/9QAS9n7I9f4bOFk6E/mWlZK+7T9433lEtRfVis+FzrhKHKSgqo23iBhRAu9oXYiCh1UiflE4RSS3JutjE/uvNn/VH0OxR5PM3nP8uxiA7sfJfMbNeS24Hb99BmtRfDCmbf1fdBh5BibyMvUO/JyBt0dRy70Z51hz8qmw99gO//Kc2DU6XIDQQT6mn3IFllWWkGbn5bcNy59rLDTeJXnavHd8HnpVUQxktyPAV3SfcGe+wJsX6KuapWGImhFZfetCab+4vGXcbKJbpXhm2nSlorzE5e/x0RcM4QZOF7+sVqMOrJoOzyfp66yzFK0WkXVnun2iCnar7sfwv9eKeEReqUWbatuNsE6E4xYU4GSMNcIG3NIBaAd7K9Bzvt+QpTFFvWLw9WNld3MCt7PHWvD0FSLGKUV9RucZ6Ni1BM+Ujt9ZsOyEGDX7gT6J9ixZ90I+q6iwFCPyNt39P8J39kbRozIxtL+WHWLg7vbqeRy0HW1RiEjh+UPGqQ88qXNQ7HSfei7dh22rCVOBkZP12zD3mhP0 1bRGanfY pb4l9vRoW80cSX7qld7AnLk5qqOvQdrgGSkOTLtSPCGg7qDAGE1mmQPKEMVEryOYTutIafufwxGoiyPfiM70DPRJtzDoTSu5fW8PcInKbuWVu67U9k7+Of98wnSFmjSDdk1ezvFV1QIcgqLjpfIA6ilGgTAk4e1+ashb408IneAUYuATpPiEDnycTmnmlyqn2DUhq23Ct7s4i1eNQp2U2Kq+r4A+RrJBBOpdW7ZoB6dz36/cAoI2G8lhIwXABVxytEdq1ZWc6CCKfsPbXkdg87s8pxJ/N3hQRPvqC0OMlEBCDPoKfO1mvM8JjF0VsqUZw0+PhG8vpgAh3Tg7KprSxEQc/yDnYettmHvxp82lr4aphFXUbuvW4oNO845sJI81CftU2TbLuXfeRv3AAN7LbVHfdpKliHyXKs8SPQKbsZMz68KGPE8K/UkJ189TZG8YJ6uh2LJpUmZaUkfMEpNTi5rrJV06jKzVMR/XYuX08KWR27em/RApYVP9dvZZOgnh1Io1s X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.07.25 05:05, Suren Baghdasaryan wrote: > Back in 2.6 era, last_addr used to be stored in seq_file->version > variable, which was unsigned long. As a result, sentinels to represent > gate vma and end of all vmas used unsigned values. In more recent > kernels we don't used seq_file->version anymore and therefore conversion > from loff_t into unsigned type is not needed. Similarly, sentinel values > don't need to be unsigned. Remove type conversion for set_file position > and change sentinel values to signed. > > Signed-off-by: Suren Baghdasaryan > Reviewed-by: Lorenzo Stoakes > Reviewed-by: Vlastimil Babka > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb