From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yh0-f47.google.com (mail-yh0-f47.google.com [209.85.213.47]) by kanga.kvack.org (Postfix) with ESMTP id 3B4FE6B0035 for ; Tue, 6 May 2014 16:43:35 -0400 (EDT) Received: by mail-yh0-f47.google.com with SMTP id a41so29239yho.34 for ; Tue, 06 May 2014 13:43:34 -0700 (PDT) Received: from g5t1627.atlanta.hp.com (g5t1627.atlanta.hp.com. [15.192.137.10]) by mx.google.com with ESMTPS id w3si17011574yhb.168.2014.05.06.13.43.34 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 06 May 2014 13:43:34 -0700 (PDT) Message-ID: <1399409007.13799.24.camel@buesod1.americas.hpqcorp.net> Subject: Re: [PATCH 0/4] ipc/shm.c: increase the limits for SHMMAX, SHMALL From: Davidlohr Bueso Date: Tue, 06 May 2014 13:43:27 -0700 In-Reply-To: <1399406800.13799.20.camel@buesod1.americas.hpqcorp.net> References: <1398090397-2397-1-git-send-email-manfred@colorfullife.com> <1399406800.13799.20.camel@buesod1.americas.hpqcorp.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: mtk.manpages@gmail.com Cc: Manfred Spraul , Davidlohr Bueso , Martin Schwidefsky , LKML , Andrew Morton , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Greg Thelen , aswin@hp.com, "linux-mm@kvack.org" On Tue, 2014-05-06 at 13:06 -0700, Davidlohr Bueso wrote: > On Fri, 2014-05-02 at 15:16 +0200, Michael Kerrisk (man-pages) wrote: > > Hi Manfred, > > > > On Mon, Apr 21, 2014 at 4:26 PM, Manfred Spraul > > wrote: > > > Hi all, > > > > > > the increase of SHMMAX/SHMALL is now a 4 patch series. > > > I don't have ideas how to improve it further. > > > > On the assumption that your patches are heading to mainline, could you > > send me a man-pages patch for the changes? > > Btw, I think that the code could still use some love wrt documentation. > Andrew, please consider this for -next if folks agree. Thanks. > > 8<---------------------------------------------------------- > > From: Davidlohr Bueso > Subject: [PATCH] ipc,shm: document new limits in the uapi header > > This is useful in the future and allows users to > better understand the reasoning behind the changes. > > Also use UL as we're dealing with it anyways. > > Signed-off-by: Davidlohr Bueso > --- > include/uapi/linux/shm.h | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/include/uapi/linux/shm.h b/include/uapi/linux/shm.h > index 74e786d..e37fb08 100644 > --- a/include/uapi/linux/shm.h > +++ b/include/uapi/linux/shm.h > @@ -8,17 +8,19 @@ > #endif > > /* > - * SHMMAX, SHMMNI and SHMALL are upper limits are defaults which can > - * be modified by sysctl. > + * SHMMNI, SHMMAX and SHMALL are the default upper limits which can be > + * modified by sysctl. Both SHMMAX and SHMALL have their default values > + * to the maximum limit which is as large as it can be without helping > + * userspace overflow the values. There is really nothing the kernel > + * can do to avoid this any variables. It is therefore not advised to ^^^^^^^^^^ should be 'further', sorry. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org