From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f169.google.com (mail-we0-f169.google.com [74.125.82.169]) by kanga.kvack.org (Postfix) with ESMTP id 1C3996B00D4 for ; Wed, 2 Apr 2014 14:09:15 -0400 (EDT) Received: by mail-we0-f169.google.com with SMTP id w62so643714wes.28 for ; Wed, 02 Apr 2014 11:09:13 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTP id k9si6388211wiw.87.2014.04.02.11.09.11 for ; Wed, 02 Apr 2014 11:09:12 -0700 (PDT) From: Luiz Capitulino Subject: [PATCH 2/4] hugetlb: update_and_free_page(): don't clear PG_reserved bit Date: Wed, 2 Apr 2014 14:08:46 -0400 Message-Id: <1396462128-32626-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1396462128-32626-1-git-send-email-lcapitulino@redhat.com> References: <1396462128-32626-1-git-send-email-lcapitulino@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, mtosatti@redhat.com, aarcange@redhat.com, mgorman@suse.de, akpm@linux-foundation.org, andi@firstfloor.org, davidlohr@hp.com, rientjes@google.com, isimatu.yasuaki@jp.fujitsu.com, yinghai@kernel.org, riel@redhat.com Hugepages pages never get the PG_reserved bit set, so don't clear it. But add a warning just in case. Signed-off-by: Luiz Capitulino --- mm/hugetlb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 8c50547..7e07e47 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -581,8 +581,9 @@ static void update_and_free_page(struct hstate *h, struct page *page) for (i = 0; i < pages_per_huge_page(h); i++) { page[i].flags &= ~(1 << PG_locked | 1 << PG_error | 1 << PG_referenced | 1 << PG_dirty | - 1 << PG_active | 1 << PG_reserved | - 1 << PG_private | 1 << PG_writeback); + 1 << PG_active | 1 << PG_private | + 1 << PG_writeback); + WARN_ON(PageReserved(&page[i])); } VM_BUG_ON_PAGE(hugetlb_cgroup_from_page(page), page); set_compound_page_dtor(page, NULL); -- 1.8.1.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org