From: Davidlohr Bueso <davidlohr@hp.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Michel Lespinasse <walken@google.com>,
Rik van Riel <riel@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: mm: mmap_sem lock assertion failure in __mlock_vma_pages_range
Date: Tue, 11 Mar 2014 13:47:24 -0700 [thread overview]
Message-ID: <1394570844.2786.42.camel@buesod1.americas.hpqcorp.net> (raw)
In-Reply-To: <531F75D1.3060909@oracle.com>
On Tue, 2014-03-11 at 16:45 -0400, Sasha Levin wrote:
> On 03/11/2014 04:30 PM, Andrew Morton wrote:
> > All I can think is that find_vma() went and returned a vma from a
> > different mm, which would be odd. How about I toss this in there?
> >
> > --- a/mm/vmacache.c~a
> > +++ a/mm/vmacache.c
> > @@ -72,8 +72,10 @@ struct vm_area_struct *vmacache_find(str
> > for (i = 0; i < VMACACHE_SIZE; i++) {
> > struct vm_area_struct *vma = current->vmacache[i];
> >
> > - if (vma && vma->vm_start <= addr && vma->vm_end > addr)
> > + if (vma && vma->vm_start <= addr && vma->vm_end > addr) {
> > + BUG_ON(vma->vm_mm != mm);
> > return vma;
> > + }
> > }
> >
> > return NULL;
>
> Bingo! With the above patch:
>
> [ 243.565794] kernel BUG at mm/vmacache.c:76!
> [ 243.566720] invalid opcode: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC
> [ 243.568048] Dumping ftrace buffer:
> [ 243.568740] (ftrace buffer empty)
> [ 243.569481] Modules linked in:
> [ 243.570203] CPU: 10 PID: 10073 Comm: trinity-c332 Tainted: G W 3.14.0-rc5-next-20140307-sasha-00010-g1f812cb-dirty #143
and this is also part of the DEBUG_PAGEALLOC + trinity combo! I suspect
the root cause it the same as Fengguang's report.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-03-11 20:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 19:39 Sasha Levin
2014-03-11 20:07 ` Davidlohr Bueso
2014-03-11 20:12 ` Sasha Levin
2014-03-11 20:21 ` Davidlohr Bueso
2014-03-11 20:30 ` Andrew Morton
2014-03-11 20:35 ` Sasha Levin
2014-03-11 20:42 ` Davidlohr Bueso
2014-03-11 20:45 ` Sasha Levin
2014-03-11 20:47 ` Davidlohr Bueso [this message]
2014-03-11 20:57 ` Dave Jones
2014-03-11 21:02 ` Sasha Levin
2014-03-11 21:45 ` Davidlohr Bueso
2014-03-11 22:20 ` Sasha Levin
2014-03-13 19:00 ` Davidlohr Bueso
2014-03-13 20:57 ` Hugh Dickins
2014-03-14 16:14 ` Sasha Levin
2014-03-11 21:59 ` Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394570844.2786.42.camel@buesod1.americas.hpqcorp.net \
--to=davidlohr@hp.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox