From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8B18C433DF for ; Wed, 8 Jul 2020 02:07:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6BCF720708 for ; Wed, 8 Jul 2020 02:07:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="wnBdaEiA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BCF720708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E39ED6B00CC; Tue, 7 Jul 2020 22:07:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E104F6B00CE; Tue, 7 Jul 2020 22:07:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D27076B00CF; Tue, 7 Jul 2020 22:07:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id C0F366B00CC for ; Tue, 7 Jul 2020 22:07:05 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 77DB6180AD807 for ; Wed, 8 Jul 2020 02:07:05 +0000 (UTC) X-FDA: 77013270810.16.trail65_50099ec26eb9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 4CE5E100E690B for ; Wed, 8 Jul 2020 02:07:05 +0000 (UTC) X-HE-Tag: trail65_50099ec26eb9 X-Filterd-Recvd-Size: 8379 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Wed, 8 Jul 2020 02:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=oZ1wi+7uHNuUUIBU7goeg2UU39JnVBSO8YHVEy7NPfE=; b=wnBdaEiAPmmeWlboDbZ15587bF ag/SDQFJChoE6vL6twLTGH9Bh7dQmFughFdlxevIYwCn08/BRhcMN7x3OqFs0ZAoKXTrLXq3ZyG6J N8GmJ+nsMpk9JbXGRwlBZ5xpWeMoVTDwcZHqhW6ieRfgErorzAYYKwlZ7FUr8s1dhdBQDvuvevZFb i6w6W/p4lc2zpVXE9w8erokwO1Xrpo4D4x5gbUJiMp7EZqQdi4CZc95lOV3XDgbGh7hRtoQto5ARb 7S1XzDAozY5UlZgmaV6KnywMJGjRcmHlhmwclMKRHBi0UvKBcOV6oJsKBGhioHsuUrIm/DQgfMPz5 +VgyWB+A==; Received: from [2601:1c0:6280:3f0:897c:6038:c71d:ecac] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jszU9-0003Vd-66; Wed, 08 Jul 2020 02:06:57 +0000 Subject: Re: [PATCH -next] Documentation/vm: fix tables in arch_pgtable_helpers To: Anshuman Khandual , Linux MM , LKML , Andrew Morton , "linux-doc@vger.kernel.org" , Jonathan Corbet Cc: Mike Rapoport , "linux-arch@vger.kernel.org" References: <02ee60d0-e836-2237-4881-5c57ccac5551@infradead.org> From: Randy Dunlap Message-ID: <13943665-f1c8-dc34-37cc-a1f56ae57a5b@infradead.org> Date: Tue, 7 Jul 2020 19:06:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4CE5E100E690B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/7/20 6:22 PM, Anshuman Khandual wrote: > > > On 07/08/2020 06:37 AM, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Make the tables be presented as tables in the generated output files >> (the line drawing did not present well). >> >> Signed-off-by: Randy Dunlap >> Cc: Jonathan Corbet >> Cc: linux-doc@vger.kernel.org >> Cc: Anshuman Khandual >> Cc: Mike Rapoport >> Cc: linux-arch@vger.kernel.org >> Cc: linux-mm@kvack.org >> Cc: Andrew Morton >> --- >> Documentation/vm/arch_pgtable_helpers.rst | 333 ++++++-------------- >> 1 file changed, 116 insertions(+), 217 deletions(-) > > Do you have a git URL some where to see these new output ? This > documentation is also useful when reading from a terminal where > these manual line drawing tables make sense. > No, I don't have a git URL. You can go to https://drive.google.com/file/d/1FO6lCRKldzESwLdylvY8tw10dOBvwz84/view?usp=sharing I had to Download the file and then view it locally. I couldn't get Google Drive to display it for me as html (only as text). I understand about reading tables at a terminal. This file could have been a txt file for that, but it's not. It's a RsT file. If you want to leave it as is, please fix these warnings: Documentation/vm/arch_pgtable_helpers.rst:24: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:28: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:32: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:36: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:40: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:44: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:48: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:52: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:56: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:60: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:64: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:68: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:72: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:76: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:88: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:92: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:96: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:100: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:104: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:108: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:112: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:116: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:120: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:124: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:128: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:132: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:136: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:140: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:144: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:148: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:152: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:162: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:166: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:170: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:174: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:178: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:182: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:186: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:190: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:194: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:198: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:202: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:206: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:218: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:222: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:226: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:230: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:234: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:244: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:248: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:252: WARNING: Line block ends without a blank line. Documentation/vm/arch_pgtable_helpers.rst:256: WARNING: Line block ends without a blank line. thanks. -- ~Randy