From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by kanga.kvack.org (Postfix) with ESMTP id E894F6B0038 for ; Fri, 14 Feb 2014 01:54:09 -0500 (EST) Received: by mail-pa0-f46.google.com with SMTP id rd3so11941518pab.33 for ; Thu, 13 Feb 2014 22:54:09 -0800 (PST) Received: from LGEAMRELO02.lge.com (lgeamrelo02.lge.com. [156.147.1.126]) by mx.google.com with ESMTP id qx4si4648280pbc.105.2014.02.13.22.54.08 for ; Thu, 13 Feb 2014 22:54:09 -0800 (PST) From: Joonsoo Kim Subject: [PATCH v2 5/5] mm/compaction: clean-up code on success of ballon isolation Date: Fri, 14 Feb 2014 15:54:03 +0900 Message-Id: <1392360843-22261-6-git-send-email-iamjoonsoo.kim@lge.com> In-Reply-To: <1392360843-22261-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1392360843-22261-1-git-send-email-iamjoonsoo.kim@lge.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Mel Gorman , Vlastimil Babka , Joonsoo Kim , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim It is just for clean-up to reduce code size and improve readability. There is no functional change. Acked-by: Vlastimil Babka Signed-off-by: Joonsoo Kim diff --git a/mm/compaction.c b/mm/compaction.c index 56536d3..a1a9270 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -553,11 +553,7 @@ isolate_migratepages_range(struct zone *zone, struct compact_control *cc, if (unlikely(balloon_page_movable(page))) { if (locked && balloon_page_isolate(page)) { /* Successfully isolated */ - cc->finished_update_migrate = true; - list_add(&page->lru, migratelist); - cc->nr_migratepages++; - nr_isolated++; - goto check_compact_cluster; + goto isolate_success; } } continue; @@ -609,13 +605,14 @@ isolate_migratepages_range(struct zone *zone, struct compact_control *cc, VM_BUG_ON(PageTransCompound(page)); /* Successfully isolated */ - cc->finished_update_migrate = true; del_page_from_lru_list(page, lruvec, page_lru(page)); + +isolate_success: + cc->finished_update_migrate = true; list_add(&page->lru, migratelist); cc->nr_migratepages++; nr_isolated++; -check_compact_cluster: /* Avoid isolating too much */ if (cc->nr_migratepages == COMPACT_CLUSTER_MAX) { ++low_pfn; -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org