From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [patch 5/8] memcg: remove unnecessary !mm check from try_get_mem_cgroup_from_mm()
Date: Fri, 7 Feb 2014 12:04:22 -0500 [thread overview]
Message-ID: <1391792665-21678-6-git-send-email-hannes@cmpxchg.org> (raw)
In-Reply-To: <1391792665-21678-1-git-send-email-hannes@cmpxchg.org>
Users pass either a mm that has been established under task lock, or
use a verified current->mm, which means the task can't be exiting.
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
---
mm/memcontrol.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index e1d7f33227e4..689fffdee471 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1075,13 +1075,6 @@ struct mem_cgroup *try_get_mem_cgroup_from_mm(struct mm_struct *mm)
{
struct mem_cgroup *memcg = NULL;
- if (!mm)
- return NULL;
- /*
- * Because we have no locks, mm->owner's may be being moved to other
- * cgroup. We use css_tryget() here even if this looks
- * pessimistic (rather than adding locks here).
- */
rcu_read_lock();
do {
memcg = mem_cgroup_from_task(rcu_dereference(mm->owner));
--
1.8.5.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-02-07 17:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 17:04 [patch 0/8] memcg: charge path cleanups Johannes Weiner
2014-02-07 17:04 ` [patch 1/8] mm: memcg: remove unnecessary preemption disabling Johannes Weiner
2014-02-10 14:17 ` Michal Hocko
2014-02-07 17:04 ` [patch 2/8] mm: memcg: remove mem_cgroup_move_account_page_stat() Johannes Weiner
2014-02-10 14:19 ` Michal Hocko
2014-02-07 17:04 ` [patch 3/8] memcg: update comment about charge reparenting on cgroup exit Johannes Weiner
2014-02-10 14:23 ` Michal Hocko
2014-02-10 20:12 ` Hugh Dickins
2014-02-11 18:48 ` Johannes Weiner
2014-02-07 17:04 ` [patch 4/8] memcg: !memcg && !mm is not allowed for __mem_cgroup_try_charge Johannes Weiner
2014-02-07 17:04 ` Johannes Weiner [this message]
2014-02-10 14:29 ` [patch 5/8] memcg: remove unnecessary !mm check from try_get_mem_cgroup_from_mm() Michal Hocko
2014-02-07 17:04 ` [patch 6/8] memcg: get_mem_cgroup_from_mm() Johannes Weiner
2014-02-10 14:41 ` Michal Hocko
2014-02-07 17:04 ` [patch 7/8] memcg: do not replicate get_mem_cgroup_from_mm in __mem_cgroup_try_charge Johannes Weiner
2014-02-07 17:04 ` [patch 8/8] memcg: sanitize __mem_cgroup_try_charge() call protocol Johannes Weiner
2014-02-10 15:28 ` Michal Hocko
2014-02-07 17:07 ` [patch 0/8] memcg: charge path cleanups Michal Hocko
2014-03-10 15:55 ` Michal Hocko
2014-03-12 1:28 Johannes Weiner
2014-03-12 1:28 ` [patch 5/8] memcg: remove unnecessary !mm check from try_get_mem_cgroup_from_mm() Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391792665-21678-6-git-send-email-hannes@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox