From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f179.google.com (mail-ig0-f179.google.com [209.85.213.179]) by kanga.kvack.org (Postfix) with ESMTP id A3EFD6B0039 for ; Fri, 31 Jan 2014 13:24:39 -0500 (EST) Received: by mail-ig0-f179.google.com with SMTP id c10so10047184igq.0 for ; Fri, 31 Jan 2014 10:24:39 -0800 (PST) Received: from relay.sgi.com (relay2.sgi.com. [192.48.179.30]) by mx.google.com with ESMTP id mk2si16267440igb.39.2014.01.31.10.24.01 for ; Fri, 31 Jan 2014 10:24:01 -0800 (PST) From: Alex Thorlton Subject: [PATCH 3/3] exec: kill the unnecessary mm->def_flags setting in load_elf_binary() Date: Fri, 31 Jan 2014 12:23:47 -0600 Message-Id: <1391192628-113858-7-git-send-email-athorlton@sgi.com> In-Reply-To: <1391192628-113858-1-git-send-email-athorlton@sgi.com> References: <1391192628-113858-1-git-send-email-athorlton@sgi.com> Sender: owner-linux-mm@kvack.org List-ID: To: linux-kernel@vger.kernel.org Cc: Alex Thorlton , Alexander Viro , Oleg Nesterov , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org load_elf_binary() sets current->mm->def_flags = def_flags and def_flags is always zero. Not only this looks strange, this is unnecessary because mm_init() has already set ->def_flags = 0. Signed-off-by: Alex Thorlton Suggested-by: Oleg Nesterov Cc: Alexander Viro Cc: Oleg Nesterov Cc: linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org --- fs/binfmt_elf.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 67be295..d09bd9c 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -579,7 +579,6 @@ static int load_elf_binary(struct linux_binprm *bprm) unsigned long start_code, end_code, start_data, end_data; unsigned long reloc_func_desc __maybe_unused = 0; int executable_stack = EXSTACK_DEFAULT; - unsigned long def_flags = 0; struct pt_regs *regs = current_pt_regs(); struct { struct elfhdr elf_ex; @@ -719,9 +718,6 @@ static int load_elf_binary(struct linux_binprm *bprm) if (retval) goto out_free_dentry; - /* OK, This is the point of no return */ - current->mm->def_flags = def_flags; - /* Do this immediately, since STACK_TOP as used in setup_arg_pages may depend on the personality. */ SET_PERSONALITY(loc->elf_ex); -- 1.7.12.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org