From: Tim Chen <tim.c.chen@linux.intel.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Paul E.McKenney" <paulmck@linux.vnet.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Waiman Long <waiman.long@hp.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Alex Shi <alex.shi@linaro.org>, Andi Kleen <andi@firstfloor.org>,
Michel Lespinasse <walken@google.com>,
Davidlohr Bueso <davidlohr.bueso@hp.com>,
Matthew R Wilcox <matthew.r.wilcox@intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Rik van Riel <riel@redhat.com>,
Peter Hurley <peter@hurleysoftware.com>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
George Spelvin <linux@horizon.com>,
"H. Peter Anvin" <hpa@zytor.com>, Arnd Bergmann <arnd@arndb.de>,
Aswin Chandramouleeswaran <aswin@hp.com>,
Scott J Norton <scott.norton@hp.com>,
"Figo.zhang" <figo1802@gmail.com>
Subject: Re: [PATCH v7 5/6] MCS Lock: allow architectures to hook in to contended paths
Date: Mon, 20 Jan 2014 08:43:45 -0800 [thread overview]
Message-ID: <1390236225.3138.21.camel@schen9-DESK> (raw)
In-Reply-To: <20140120141157.GC9868@mudshark.cambridge.arm.com>
On Mon, 2014-01-20 at 14:11 +0000, Will Deacon wrote:
> On Mon, Jan 20, 2014 at 12:19:48PM +0000, Peter Zijlstra wrote:
> > On Thu, Jan 16, 2014 at 04:08:31PM -0800, Tim Chen wrote:
> > > +#ifndef arch_mcs_spin_lock_contended
> > > +/*
> > > + * Using smp_load_acquire() provides a memory barrier that ensures
> > > + * subsequent operations happen after the lock is acquired.
> > > + */
> > > +#define arch_mcs_spin_lock_contended(l) \
> > > + while (!(smp_load_acquire(l))) { \
> > > + arch_mutex_cpu_relax(); \
> > > + }
> > > +#endif
> >
> > I think that wants to be:
> >
> > #define arch_mcs_spin_lock_contended(l) \
> > do { \
> > while (!smp_load_acquire(l)) \
> > arch_mutex_cpu_relax(); \
> > } while (0)
> >
> > So that we properly eat the ';' in: arch_mcs_spin_lock_contended(l);.
>
> Yeah, that's better.
>
> Tim: are you happy making that change please?
>
> Will
Sure, will do.
Tim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-20 16:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1389890175.git.tim.c.chen@linux.intel.com>
2014-01-17 0:08 ` [PATCH v7 0/6] MCS Lock: MCS lock code cleanup and optimizations Tim Chen
2014-01-20 13:58 ` Peter Zijlstra
2014-01-20 14:22 ` Ingo Molnar
2014-01-17 0:08 ` [PATCH v7 1/6] MCS Lock: Restructure the MCS lock defines and locking code into its own file Tim Chen
2014-01-20 2:28 ` Paul E. McKenney
2014-01-20 12:07 ` Peter Zijlstra
2014-01-20 19:31 ` Tim Chen
2014-01-17 0:08 ` [PATCH v7 2/6] MCS Lock: optimizations and extra comments Tim Chen
2014-01-20 2:29 ` Paul E. McKenney
2014-01-20 13:58 ` Peter Zijlstra
2014-01-20 19:11 ` Tim Chen
2014-01-17 0:08 ` [PATCH v7 3/6] MCS Lock: Move mcs_lock/unlock function into its own file Tim Chen
2014-01-20 2:32 ` Paul E. McKenney
2014-01-20 12:15 ` Peter Zijlstra
2014-01-17 0:08 ` [PATCH v7 4/6] MCS Lock: Barrier corrections Tim Chen
2014-01-20 2:33 ` Paul E. McKenney
2014-01-20 7:09 ` Ingo Molnar
2014-01-17 0:08 ` [PATCH v7 5/6] MCS Lock: allow architectures to hook in to contended paths Tim Chen
2014-01-20 2:34 ` Paul E. McKenney
2014-01-20 12:19 ` Peter Zijlstra
2014-01-20 14:11 ` Will Deacon
2014-01-20 16:43 ` Tim Chen [this message]
2014-01-17 0:08 ` [PATCH v7 6/6] MCS Lock: add Kconfig entries to allow arch-specific hooks Tim Chen
2014-01-20 2:35 ` Paul E. McKenney
2014-01-20 12:30 ` Peter Zijlstra
2014-01-20 12:35 ` Geert Uytterhoeven
2014-01-20 12:36 ` Peter Zijlstra
2014-01-20 12:38 ` Ingo Molnar
2014-01-20 13:17 ` Peter Zijlstra
2014-01-20 23:31 ` Tim Chen
2014-01-21 9:47 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390236225.3138.21.camel@schen9-DESK \
--to=tim.c.chen@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linaro.org \
--cc=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=aswin@hp.com \
--cc=dave.hansen@intel.com \
--cc=davidlohr.bueso@hp.com \
--cc=figo1802@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@horizon.com \
--cc=matthew.r.wilcox@intel.com \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peter@hurleysoftware.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=waiman.long@hp.com \
--cc=walken@google.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox