From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by kanga.kvack.org (Postfix) with ESMTP id 017926B0031 for ; Tue, 14 Jan 2014 10:37:28 -0500 (EST) Received: by mail-pa0-f49.google.com with SMTP id bj1so5338358pad.22 for ; Tue, 14 Jan 2014 07:37:28 -0800 (PST) Received: from g1t0029.austin.hp.com (g1t0029.austin.hp.com. [15.216.28.36]) by mx.google.com with ESMTPS id ot3si838966pac.137.2014.01.14.07.37.26 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 14 Jan 2014 07:37:27 -0800 (PST) Message-ID: <1389713482.1792.281.camel@misato.fc.hp.com> Subject: Re: [PATCH] x86, acpi memory hotplug, add parameter to disable memory hotplug From: Toshi Kani Date: Tue, 14 Jan 2014 08:31:22 -0700 In-Reply-To: <20140114152627.GD3096@redhat.com> References: <1389650161-13292-1-git-send-email-prarit@redhat.com> <52D47999.5080905@redhat.com> <52D48EC4.5070400@jp.fujitsu.com> <1389663689.1792.268.camel@misato.fc.hp.com> <52D519EB.3040709@redhat.com> <20140114152627.GD3096@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Vivek Goyal Cc: Prarit Bhargava , Yasuaki Ishimatsu , KOSAKI Motohiro , LKML , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , Len Brown , "Rafael J. Wysocki" , Linn Crosetto , Pekka Enberg , Yinghai Lu , Andrew Morton , Tang Chen , Wen Congyang , Dave Young , linux-acpi@vger.kernel.org, "linux-mm@kvack.org" On Tue, 2014-01-14 at 10:26 -0500, Vivek Goyal wrote: > On Tue, Jan 14, 2014 at 06:05:15AM -0500, Prarit Bhargava wrote: > > [..] > > >>> As mentioned, self-NAK. I have seen a system that I needed to specify > > >>> memmap=exactmap & had hotplug memory. I will only keep the acpi_no_memhotplug > > >>> option in the next version of the patch. > > >> > > >> > > >> Your following first patch is simply and makes sense. > > >> > > >> http://marc.info/?l=linux-acpi&m=138922019607796&w=2 > > >> > > > > > > In this option, it also requires changing kexec-tools to specify the new > > > option for kdump. It won't be simpler. > > > > It will be simpler for the kernel and those of us who have to debug busted e820 > > maps ;) > > > > Unfortunately I may not be able to give you the automatic disable. I did > > contemplate adding a !is_kdump_kernel() to the ACPI memory hotplug init call, > > but it seems like that is unacceptable as well. > > I think everybody agrees that there has to be a stand alone command line > option to disable memory hotplug. > > Whether to tie it into memmap=exactmap and mem=X is the contentious bit. > So I would suggest that just post a patch to disable memory hotplut using > a command line and later more patches can go in if people strongly feel > the need to tie it into memmap=exactmap. > > In the mean time, we will modify /etc/sysconfig/kdump to pass > acpi_no_memhotplug so that user does not have to worry about passing this > parameter and kexec-tools will not have to be modified either. Fine by me. Thanks for modifying /etc/sysconfig/kdump file. -Toshi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org