From: Toshi Kani <toshi.kani@hp.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Prarit Bhargava <prarit@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Bodo Eggert <7eggert@gmx.de>, LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
the arch/x86 maintainers <x86@kernel.org>,
Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linn Crosetto <linn@hp.com>, Pekka Enberg <penberg@kernel.org>,
Yinghai Lu <yinghai@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tang Chen <tangchen@cn.fujitsu.com>,
Wen Congyang <wency@cn.fujitsu.com>,
Vivek Goyal <vgoyal@redhat.com>,
dyoung@redhat.com, linux-acpi@vger.kernel.org,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 2/2] x86, e820 disable ACPI Memory Hotplug if memory mapping is specified by user [v2]
Date: Mon, 13 Jan 2014 18:09:06 -0700 [thread overview]
Message-ID: <1389661746.1792.254.camel@misato.fc.hp.com> (raw)
In-Reply-To: <52D48A9D.7000003@zytor.com>
On Mon, 2014-01-13 at 16:53 -0800, H. Peter Anvin wrote:
> On 01/13/2014 04:33 PM, Toshi Kani wrote:
> >
> > I do not think it makes sense. You needed memmap=exactmap as a
> > workaround because the kernel did not boot with the firmware's memory
> > info. So, it's broken, and you requested the kernel to ignore the
> > firmware info.
> >
> > Why do you think memory hotplug needs to be supported under such
> > condition, which has to use the broken firmware info?
> >
>
> Even more than memory hotplug: what do we do with NUMA? Since we have
> already told the kernel "the firmware is bogus" it would seem that any
> NUMA optimizations would be a bit ... cantankerous at best, no?
Agreed that NUMA info can be bogus in this case, but is probably not
critical.
In majority of the cases, memmap=exactmap is used for kdump and the
firmware info is sane. So, I think we should keep NUMA enabled since it
could be useful when multiple CPUs are enabled for kdump.
Thanks,
-Toshi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-14 1:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 19:04 [PATCH 0/2] Add option to disable ACPI Memory Hotplug [v2] Prarit Bhargava
2014-01-10 19:04 ` [PATCH 0/2] Add option to disable ACPI Memory Hotplug Prarit Bhargava
2014-01-10 19:04 ` [PATCH 1/2] acpi memory hotplug, add parameter to disable memory hotplug [v2] Prarit Bhargava
2014-01-10 21:34 ` Toshi Kani
2014-01-10 19:04 ` [PATCH 2/2] x86, e820 disable ACPI Memory Hotplug if memory mapping is specified by user [v2] Prarit Bhargava
2014-01-10 21:12 ` Vivek Goyal
2014-01-10 21:34 ` Toshi Kani
2014-01-11 16:35 ` 7eggert
2014-01-12 23:46 ` Prarit Bhargava
2014-01-13 20:31 ` KOSAKI Motohiro
2014-01-13 23:39 ` Prarit Bhargava
2014-01-14 0:33 ` Toshi Kani
2014-01-14 0:53 ` H. Peter Anvin
2014-01-14 1:09 ` Toshi Kani [this message]
2014-01-14 1:29 ` H. Peter Anvin
2014-01-14 1:40 ` Toshi Kani
2014-01-14 1:52 ` Dave Young
2014-01-14 1:47 ` Toshi Kani
2014-01-14 11:02 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389661746.1792.254.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=7eggert@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=kosaki.motohiro@gmail.com \
--cc=lenb@kernel.org \
--cc=linn@hp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=penberg@kernel.org \
--cc=prarit@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tangchen@cn.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=wency@cn.fujitsu.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox