From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 693E3C7EE2E for ; Mon, 12 Jun 2023 00:12:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 752A26B0072; Sun, 11 Jun 2023 20:11:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 701E26B0074; Sun, 11 Jun 2023 20:11:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CB3B6B0075; Sun, 11 Jun 2023 20:11:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 43C066B0072 for ; Sun, 11 Jun 2023 20:11:59 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 069C8AEDB4 for ; Mon, 12 Jun 2023 00:11:59 +0000 (UTC) X-FDA: 80892167958.26.35816F4 Received: from domac.alu.hr (domac.alu.unizg.hr [161.53.235.3]) by imf14.hostedemail.com (Postfix) with ESMTP id 9A3F1100004 for ; Mon, 12 Jun 2023 00:11:55 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=alu.unizg.hr header.s=mail header.b=HuEUu4XS; dkim=pass header.d=alu.unizg.hr header.s=mail header.b=Rppk12Df; dmarc=pass (policy=none) header.from=alu.unizg.hr; spf=pass (imf14.hostedemail.com: domain of mirsad.todorovac@alu.unizg.hr designates 161.53.235.3 as permitted sender) smtp.mailfrom=mirsad.todorovac@alu.unizg.hr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686528716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fIjo1Prn9bU2r0DRDGozMHITsrU3sXLVmPxA7JrjSj4=; b=me+Fy3BrfnqNk4qgbgzSXSoPd/IC89wO6pyarYztCXNsJs8mARsmkt/smU6L10DoGLEuSt fRmhlfHgnQO535Xqvx3zf1zZSW4iWEaTl5L36lq6fNtyHtQKARfqeFRI2vbeSdFpxNxX4q suaYbg7W4409TiLposdnPZau+fujBtA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=alu.unizg.hr header.s=mail header.b=HuEUu4XS; dkim=pass header.d=alu.unizg.hr header.s=mail header.b=Rppk12Df; dmarc=pass (policy=none) header.from=alu.unizg.hr; spf=pass (imf14.hostedemail.com: domain of mirsad.todorovac@alu.unizg.hr designates 161.53.235.3 as permitted sender) smtp.mailfrom=mirsad.todorovac@alu.unizg.hr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686528716; a=rsa-sha256; cv=none; b=evCA2IAd/mFXFXVB50gBKaH/+jCg7jsW/cAXhWniHJxglCmym0doomITeFMiHSJrMO0e9F RjpVcDL18UYoDWrEVsZXGqyYC/4P9g0dddQ133YZ3KlBlb0D6ASPrBodQ/wycKCQ8Jt69X yxRxAmH1oq5CrUc7Bipkxh4qGEi0LeE= Received: from localhost (localhost [127.0.0.1]) by domac.alu.hr (Postfix) with ESMTP id B1CE960161; Mon, 12 Jun 2023 02:11:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=alu.unizg.hr; s=mail; t=1686528712; bh=J+LxLsYNe9+MQixJ9S8fEV+WIm5vUBkxw/4ZmHH4Cys=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HuEUu4XSSvXt9QT/kjvtws8LUgDOjhp+LxTofdBruk1jOH8Izp5Ir3uXi+amHe3v4 iZD1ePzT2VI+NZLQoWe8UR7VMWNkwkruKo+fD5RasljCXBc4ba6Y02ejVOTlZPzRDj iZonxq2lKA9kwZa6t/MwJ+qkP8+rFtsqXa2GB4sBPpM5kyYw9Xb1k66amtrF1Tv5ak PdRt/Nyz8JNzGLOZwuNfyVPwHQbZMt/otXd+9085uWv2MK2pmdlbTDZc85m9pO/j/S +goZemIYOLYn4iq3Ros4/uuYlL1KC55QvQ2WbgdzJ9LflIkZy6O4CiIImeBJgAd4mv /zURFyYXEN6kg== X-Virus-Scanned: Debian amavisd-new at domac.alu.hr Received: from domac.alu.hr ([127.0.0.1]) by localhost (domac.alu.hr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5qrJgMNOROOU; Mon, 12 Jun 2023 02:11:50 +0200 (CEST) Received: from [192.168.1.6] (unknown [94.250.191.183]) by domac.alu.hr (Postfix) with ESMTPSA id F0FB86015F; Mon, 12 Jun 2023 02:11:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=alu.unizg.hr; s=mail; t=1686528710; bh=J+LxLsYNe9+MQixJ9S8fEV+WIm5vUBkxw/4ZmHH4Cys=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Rppk12DfYRXTRe2hymowdjRWTQcHPgrL/p4Iw/PFOpAT4dcX3rplQeeMLspxHYrQw rr/3jomcIDhyUqz+dIMKkgbbC0JWKx8xFNMG+fherShRpvKMMzxfqKskhnNxwlTKyp MKaoXam7VJPJCyRRBilBjSiFyX93RbQgzdHGv6JXAlz2t4B9I15E4m5RHtfG//JXdy 5ICZLsw3mavUMHrvpWwpQjlrIb6TJY500YYe3ISNCzsBXNT7tqdFLG2mu29SaLJuTT 60Qn3jfq2ryUWhjFW9G8aWVIuQ4K1zul8EljqT8flJ1dqw6riafCEdiqeGfFHgIUht stMapo8M686Hg== Message-ID: <138905be-3963-cd67-c217-7aa561372293@alu.unizg.hr> Date: Mon, 12 Jun 2023 02:11:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 1/1] selftests: mm: uufd-unit-tests: remove a format warning in printf Content-Language: en-US To: Muhammad Usama Anjum Cc: Shuah Khan , linux-kernel@vger.kernel.org, Peter Xu , Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20230610235016.438460-1-mirsad.todorovac@alu.unizg.hr> <109d9c47-9c0e-e8ca-2bc1-cb741bc45a1b@collabora.com> From: Mirsad Goran Todorovac In-Reply-To: <109d9c47-9c0e-e8ca-2bc1-cb741bc45a1b@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9A3F1100004 X-Stat-Signature: saa41agyoetr1he1m8z8xswohquu5uz8 X-Rspam-User: X-HE-Tag: 1686528715-756321 X-HE-Meta: U2FsdGVkX1+PZtJOkpft8hCZvIt++exepX8BJdRVYN/9T2xQnzCfAZ8F5BatpNGobH703fMsKbjOLOhK30iaEK5rQJ6O4E0OZsRnn2ah9UQYHIcwxQ0eGzpE+u7kqnuT/VrOERuxLj/YnBlTnQzWFJo9Et/4pPglNxMs27HkliMQsMPBoZviWu6Q2Wiwqa5kt6Gu1gdu8m1/Jd8c2BfrhbInelPU/NSVTDtFYl1G+Xs73KMdG+Xy2dGgze1q+anX7OsHKayytsTvjpwrpRn3ptZn3fUJ+jc+q1ctGP+uNBtVTFxkFYMbW9gmnTarr3XL3lmAuY6nBM/qzvoWzOaf2wjKdk0Sizgv2wf/FWeaW22+0QF9q0B51Q91Ai7EiUIw8Jj727WWinlODvaix+XfalMbAyURD794qP7S5ujP9JdWE1HbQqecH6Kx9wUema6JW6HyInyYiSMoqtlWyRUYkJyZKyyQBR4QqfwqU5OUpGT7h5ch4eLJ+unpY0Pc5FXiPuZgtgLlOWHpW5X5p+Fl5u+B8mZHa8t0NmubNDZp0a5qomHy8moQxDFhxnPqYId80pYvTDQhaAZWLndvOOC8V1G4XYLp0k1vdYNEqte8RpIcwvLwJ+KP8o8IqDxw+oRNLKP7ratVAReHkSDaq0lb5x/j6ReAE9/iniSNJF8llZoVdx+TDMkZBXXvayldQ6xzufVakQOMaHkfEYLuSNatDsnchm/EXOkAm0EQOQBzZDhtDy3LWxNDC9zVTm/G4axr0WwKizAgyYlax30GT8U7i4BWRmJR7blm2SDhlcjS3oLaG9iIuniY/OWw3HttmMP592bJ/HFwvRVvF3RJSkX7yK/J4I1Wsu9pzVQ0MqeBstTz63du4mKW2McHDVfEGQR1GEsd/jZyaPzvYg8DHBPN10hHxN49nvJyguZ4VdGSqPw35qp14OGYqKp5jM0UzC2IvbhdlRPH7UAB2V2bfmq hT2BTdKX LaxEoNEhYcLszIvcZj59AOn/GcfgFxg7+iUgbJdh9MjlRiUc3EuKgajMUVMflOMRzelqkO0ARkYHGgzv2GgRT5VZ6YKvHQr9rkvUxnuvcrALe41b8z1cg6j97aEeUjfIlhE5zS0eNQQe3q6qBdirzxpFChNlzTrsiuBrSeIP6k4870OU9wGiTObRBFV7vBuKfmst30EvlATFDVHqGLZFLWiFx/ApRjbqVtv7fFb5iLsAugR5IoD2Or3gLFw/lNSCNe/dY62qHSM0a7j0DDxXaqo4tT6cWZKNuVUChBdwxSXCNiUyEEp9qq+ljrg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Apologies Muhammad then, didn't follow that branch. Regards, Mirsad On 6/11/23 14:30, Muhammad Usama Anjum wrote: > The fix has already been picked up by Andew in mm unstable: > > https://lore.kernel.org/all/20230607023727.0E011C433D2@smtp.kernel.org > > On 6/11/23 4:50 AM, Mirsad Todorovac wrote: >> GCC 11.3.0 issued warnings about macros and types of arguments [edited]: >> >> gcc -Wall -I ../tools/testing/selftests/../../.. \ >> -I ../tools/testing/selftests/../../../tools/include/uapi \ >> -isystem ../usr/include -no-pie uffd-unit-tests.c vm_util.c \ >> uffd-common.c -lrt -lpthread -o \ >> ../tools/testing/selftests/mm/uffd-unit-tests >> uffd-unit-tests.c: In function ‘main’: >> uffd-unit-tests.c:1198:41: warning: format not a string literal and no \ >> format arguments [-Wformat-security] >> 1198 | uffd_test_start(test_name); >> | ^~~~~~~~~ >> uffd-unit-tests.c:100:24: note: in definition of macro ‘uffd_test_start’ >> 100 | printf(__VA_ARGS__); \ >> | ^~~~~~~~~~~ >> uffd-unit-tests.c:1205:33: warning: format not a string literal and no \ >> format arguments [-Wformat-security] >> 1205 | uffd_test_skip(errmsg); >> | ^~~~~~~~~~~~~~ >> >> The macros are defined as: >> >> #define uffd_test_start(...) do { \ >> printf("Testing "); \ >> printf(__VA_ARGS__); \ >> printf("... "); \ >> fflush(stdout); \ >> } while (0) >> >> #define uffd_test_skip(...) do { \ >> printf("skipped [reason: "); \ >> printf(__VA_ARGS__); \ >> printf("]\n"); \ >> ksft_inc_xskip_cnt(); \ >> } while (0) >> >> Minor workaround, adding "%s" first argument to macro expansion calls seems >> to be the easiest way to eliminate the warnings. >> >> Cc: Peter Xu >> Cc: linux-mm@kvack.org >> Cc: linux-kselftest@vger.kernel.org >> Fixes: 43759d44dc34 ("selftests/mm: add uffdio register ioctls test") >> Fixes: 16a45b57cbf2 ("selftests/mm: add framework for uffd-unit-test") >> Signed-off-by: Mirsad Todorovac >> --- >> tools/testing/selftests/mm/uffd-unit-tests.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c >> index 269c86768a02..d356dd271c84 100644 >> --- a/tools/testing/selftests/mm/uffd-unit-tests.c >> +++ b/tools/testing/selftests/mm/uffd-unit-tests.c >> @@ -1195,14 +1195,14 @@ int main(int argc, char *argv[]) >> snprintf(test_name, sizeof(test_name), >> "%s on %s", test->name, mem_type->name); >> >> - uffd_test_start(test_name); >> + uffd_test_start("%s", test_name); >> if (!uffd_feature_supported(test)) { >> uffd_test_skip("feature missing"); >> continue; >> } >> if (uffd_setup_environment(&args, test, mem_type, >> &errmsg)) { >> - uffd_test_skip(errmsg); >> + uffd_test_skip("%s", errmsg); >> continue; >> } >> test->uffd_fn(&args); >