From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qc0-f177.google.com (mail-qc0-f177.google.com [209.85.216.177]) by kanga.kvack.org (Postfix) with ESMTP id AA7996B0036 for ; Mon, 6 Jan 2014 10:30:49 -0500 (EST) Received: by mail-qc0-f177.google.com with SMTP id m20so17369162qcx.22 for ; Mon, 06 Jan 2014 07:30:49 -0800 (PST) Received: from mail-qe0-x230.google.com (mail-qe0-x230.google.com [2607:f8b0:400d:c02::230]) by mx.google.com with ESMTPS id hj7si72027381qeb.78.2014.01.06.07.30.48 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 06 Jan 2014 07:30:49 -0800 (PST) Received: by mail-qe0-f48.google.com with SMTP id gc15so18606944qeb.35 for ; Mon, 06 Jan 2014 07:30:48 -0800 (PST) From: William Roberts Subject: [RFC][PATCH 2/3] proc: Update get proc_pid_cmdline() to use mm.h helpers Date: Mon, 6 Jan 2014 07:30:29 -0800 Message-Id: <1389022230-24664-2-git-send-email-wroberts@tresys.com> In-Reply-To: <1389022230-24664-1-git-send-email-wroberts@tresys.com> References: <1389022230-24664-1-git-send-email-wroberts@tresys.com> Sender: owner-linux-mm@kvack.org List-ID: To: linux-audit@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rgb@redhat.com, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, sds@tycho.nsa.gov Cc: William Roberts Re-factor proc_pid_cmdline() to use get_cmdline() helper from mm.h. Signed-off-by: William Roberts --- fs/proc/base.c | 36 ++---------------------------------- 1 file changed, 2 insertions(+), 34 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index 03c8d74..cfd178d 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -200,41 +200,9 @@ static int proc_root_link(struct dentry *dentry, struct path *path) return result; } -static int proc_pid_cmdline(struct task_struct *task, char * buffer) +static int proc_pid_cmdline(struct task_struct *task, char *buffer) { - int res = 0; - unsigned int len; - struct mm_struct *mm = get_task_mm(task); - if (!mm) - goto out; - if (!mm->arg_end) - goto out_mm; /* Shh! No looking before we're done */ - - len = mm->arg_end - mm->arg_start; - - if (len > PAGE_SIZE) - len = PAGE_SIZE; - - res = access_process_vm(task, mm->arg_start, buffer, len, 0); - - // If the nul at the end of args has been overwritten, then - // assume application is using setproctitle(3). - if (res > 0 && buffer[res-1] != '\0' && len < PAGE_SIZE) { - len = strnlen(buffer, res); - if (len < res) { - res = len; - } else { - len = mm->env_end - mm->env_start; - if (len > PAGE_SIZE - res) - len = PAGE_SIZE - res; - res += access_process_vm(task, mm->env_start, buffer+res, len, 0); - res = strnlen(buffer, res); - } - } -out_mm: - mmput(mm); -out: - return res; + return get_cmdline(task, buffer, PAGE_SIZE); } static int proc_pid_auxv(struct task_struct *task, char *buffer) -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org