From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>, Rik van Riel <riel@redhat.com>,
Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 10/12] sched/numa: fix record hinting faults check
Date: Tue, 10 Dec 2013 02:01:09 -0500 [thread overview]
Message-ID: <1386658869-2gttr64d-mutt-n-horiguchi@ah.jp.nec.com> (raw)
In-Reply-To: <1386483293-15354-10-git-send-email-liwanp@linux.vnet.ibm.com>
On Sun, Dec 08, 2013 at 02:14:51PM +0800, Wanpeng Li wrote:
> Adjust numa_scan_period in task_numa_placement, depending on how much useful
> work the numa code can do. The local faults and remote faults should be used
> to check if there is record hinting faults instead of local faults and shared
> faults. This patch fix it.
>
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Looks good to me.
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> ---
> kernel/sched/fair.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index b077f1b3..942e67b 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -1322,7 +1322,7 @@ static void update_task_scan_period(struct task_struct *p,
> * completely idle or all activity is areas that are not of interest
> * to automatic numa balancing. Scan slower
> */
> - if (local + shared == 0) {
> + if (local + remote == 0) {
> p->numa_scan_period = min(p->numa_scan_period_max,
> p->numa_scan_period << 1);
>
> --
> 1.7.5.4
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-12-10 7:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-08 6:14 [PATCH v3 01/12] sched/numa: fix set cpupid on page migration twice against thp Wanpeng Li
2013-12-08 6:14 ` [PATCH v3 02/12] sched/numa: drop idx field of task_numa_env struct Wanpeng Li
2013-12-08 6:14 ` [PATCH v3 03/12] sched/numa: drop sysctl_numa_balancing_settle_count sysctl Wanpeng Li
2013-12-08 6:14 ` [PATCH v3 04/12] sched/numa: use wrapper function task_node to get node which task is on Wanpeng Li
2013-12-08 6:14 ` [PATCH v3 05/12] sched/numa: make numamigrate_isolate_page static Wanpeng Li
2013-12-08 6:14 ` [PATCH v3 06/12] sched/numa: make numamigrate_update_ratelimit static Wanpeng Li
2013-12-08 6:14 ` [PATCH v3 07/12] sched/numa: fix set cpupid on page migration twice against normal page Wanpeng Li
2013-12-08 6:14 ` [PATCH v3 08/12] sched/numa: use wrapper function task_faults_idx to calculate index in group_faults Wanpeng Li
2013-12-08 6:14 ` [PATCH v3 09/12] sched/numa: fix task scan rate adjustment Wanpeng Li
2013-12-10 6:44 ` Naoya Horiguchi
2013-12-10 6:51 ` Wanpeng Li
2013-12-10 8:27 ` Mel Gorman
2013-12-10 8:49 ` Wanpeng Li
2013-12-08 6:14 ` [PATCH v3 10/12] sched/numa: fix record hinting faults check Wanpeng Li
2013-12-10 7:01 ` Naoya Horiguchi [this message]
2013-12-08 6:14 ` [PATCH v3 11/12] sched/numa: drop unnecessary variable in task_weight Wanpeng Li
2013-12-10 7:11 ` Naoya Horiguchi
2013-12-08 6:14 ` [PATCH v3 12/12] sched/numa: drop local 'ret' in task_numa_migrate() Wanpeng Li
2013-12-10 7:12 ` Naoya Horiguchi
2013-12-10 7:17 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386658869-2gttr64d-mutt-n-horiguchi@ah.jp.nec.com \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox