From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
Rafael Aquini <aquini@redhat.com>,
Christoph Lameter <cl@linux.com>, Joonsoo Kim <js1304@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Vlastimil Babka <vbabka@suse.cz>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Subject: Re: [PATCH v2 6/7] mm/migrate: remove unused function, fail_migrate_page()
Date: Mon, 09 Dec 2013 12:07:26 -0500 [thread overview]
Message-ID: <1386608846-opj9f7ee-mutt-n-horiguchi@ah.jp.nec.com> (raw)
In-Reply-To: <1386580248-22431-7-git-send-email-iamjoonsoo.kim@lge.com>
On Mon, Dec 09, 2013 at 06:10:47PM +0900, Joonsoo Kim wrote:
> fail_migrate_page() isn't used anywhere, so remove it.
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> diff --git a/include/linux/migrate.h b/include/linux/migrate.h
> index e4671f9..4308018 100644
> --- a/include/linux/migrate.h
> +++ b/include/linux/migrate.h
> @@ -41,9 +41,6 @@ extern int migrate_page(struct address_space *,
> extern int migrate_pages(struct list_head *l, new_page_t x,
> unsigned long private, enum migrate_mode mode, int reason);
>
> -extern int fail_migrate_page(struct address_space *,
> - struct page *, struct page *);
> -
> extern int migrate_prep(void);
> extern int migrate_prep_local(void);
> extern int migrate_vmas(struct mm_struct *mm,
> @@ -83,7 +80,6 @@ static inline int migrate_huge_page_move_mapping(struct address_space *mapping,
>
> /* Possible settings for the migrate_page() method in address_operations */
> #define migrate_page NULL
> -#define fail_migrate_page NULL
>
> #endif /* CONFIG_MIGRATION */
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index cdafdc0..b595f89 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -550,14 +550,6 @@ void migrate_page_copy(struct page *newpage, struct page *page)
> * Migration functions
> ***********************************************************/
>
> -/* Always fail migration. Used for mappings that are not movable */
> -int fail_migrate_page(struct address_space *mapping,
> - struct page *newpage, struct page *page)
> -{
> - return -EIO;
> -}
> -EXPORT_SYMBOL(fail_migrate_page);
> -
> /*
> * Common logic to directly migrate a single page suitable for
> * pages that do not use PagePrivate/PagePrivate2.
> --
> 1.7.9.5
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-12-09 17:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 9:10 [PATCH v2 0/7] correct and clean-up migration related stuff Joonsoo Kim
2013-12-09 9:10 ` [PATCH v2 1/7] mm/migrate: add comment about permanent failure path Joonsoo Kim
2013-12-10 1:42 ` Wanpeng Li
2013-12-09 9:10 ` [PATCH v2 2/7] mm/migrate: correct failure handling if !hugepage_migration_support() Joonsoo Kim
2013-12-09 16:17 ` Christoph Lameter
2013-12-10 8:38 ` Joonsoo Kim
2013-12-10 2:17 ` Wanpeng Li
2013-12-10 8:45 ` Joonsoo Kim
2013-12-10 9:27 ` Wanpeng Li
2013-12-09 9:10 ` [PATCH v2 3/7] mm/mempolicy: correct putback method for isolate pages if failed Joonsoo Kim
2013-12-09 16:41 ` Rafael Aquini
2013-12-10 2:22 ` Wanpeng Li
2013-12-09 9:10 ` [PATCH v2 4/7] mm/migrate: remove putback_lru_pages, fix comment on putback_movable_pages Joonsoo Kim
2013-12-10 2:33 ` Wanpeng Li
2013-12-10 8:51 ` Joonsoo Kim
2013-12-10 9:00 ` Joonsoo Kim
2013-12-09 9:10 ` [PATCH v2 5/7] mm/compaction: respect ignore_skip_hint in update_pageblock_skip Joonsoo Kim
2013-12-10 2:50 ` Wanpeng Li
2013-12-09 9:10 ` [PATCH v2 6/7] mm/migrate: remove unused function, fail_migrate_page() Joonsoo Kim
2013-12-09 16:20 ` Christoph Lameter
2013-12-09 17:07 ` Naoya Horiguchi [this message]
2013-12-10 2:36 ` Wanpeng Li
2013-12-09 9:10 ` [PATCH v2 7/7] mm/migrate: remove result argument on page allocation function for migration Joonsoo Kim
2013-12-09 16:40 ` Christoph Lameter
2013-12-10 3:22 ` Wanpeng Li
2013-12-11 8:47 ` Joonsoo Kim
2013-12-11 16:00 ` Christoph Lameter
2013-12-12 0:07 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386608846-opj9f7ee-mutt-n-horiguchi@ah.jp.nec.com \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
--cc=vbabka@suse.cz \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox