From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f41.google.com (mail-pb0-f41.google.com [209.85.160.41]) by kanga.kvack.org (Postfix) with ESMTP id 4378E6B007B for ; Mon, 9 Dec 2013 04:08:06 -0500 (EST) Received: by mail-pb0-f41.google.com with SMTP id jt11so5061634pbb.28 for ; Mon, 09 Dec 2013 01:08:05 -0800 (PST) Received: from LGEAMRELO01.lge.com (lgeamrelo01.lge.com. [156.147.1.125]) by mx.google.com with ESMTP id n8si6655856pax.247.2013.12.09.01.08.03 for ; Mon, 09 Dec 2013 01:08:05 -0800 (PST) From: Joonsoo Kim Subject: [PATCH v2 5/7] mm/compaction: respect ignore_skip_hint in update_pageblock_skip Date: Mon, 9 Dec 2013 18:10:46 +0900 Message-Id: <1386580248-22431-6-git-send-email-iamjoonsoo.kim@lge.com> In-Reply-To: <1386580248-22431-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1386580248-22431-1-git-send-email-iamjoonsoo.kim@lge.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Mel Gorman , Rik van Riel , Rafael Aquini , Naoya Horiguchi , Christoph Lameter , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Zhang Yanfei , Joonsoo Kim update_pageblock_skip() only fits to compaction which tries to isolate by pageblock unit. If isolate_migratepages_range() is called by CMA, it try to isolate regardless of pageblock unit and it don't reference get_pageblock_skip() by ignore_skip_hint. We should also respect it on update_pageblock_skip() to prevent from setting the wrong information. Cc: # 3.7+ Acked-by: Vlastimil Babka Reviewed-by: Naoya Horiguchi Signed-off-by: Joonsoo Kim diff --git a/mm/compaction.c b/mm/compaction.c index 805165b..f58bcd0 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -134,6 +134,10 @@ static void update_pageblock_skip(struct compact_control *cc, bool migrate_scanner) { struct zone *zone = cc->zone; + + if (cc->ignore_skip_hint) + return; + if (!page) return; -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org