From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f51.google.com (mail-pb0-f51.google.com [209.85.160.51]) by kanga.kvack.org (Postfix) with ESMTP id 720206B0071 for ; Mon, 9 Dec 2013 04:08:02 -0500 (EST) Received: by mail-pb0-f51.google.com with SMTP id up15so5056298pbc.38 for ; Mon, 09 Dec 2013 01:08:02 -0800 (PST) Received: from LGEAMRELO01.lge.com (lgeamrelo01.lge.com. [156.147.1.125]) by mx.google.com with ESMTP id sw1si6670475pbc.222.2013.12.09.01.08.00 for ; Mon, 09 Dec 2013 01:08:01 -0800 (PST) From: Joonsoo Kim Subject: [PATCH v2 1/7] mm/migrate: add comment about permanent failure path Date: Mon, 9 Dec 2013 18:10:42 +0900 Message-Id: <1386580248-22431-2-git-send-email-iamjoonsoo.kim@lge.com> In-Reply-To: <1386580248-22431-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1386580248-22431-1-git-send-email-iamjoonsoo.kim@lge.com> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Mel Gorman , Rik van Riel , Rafael Aquini , Naoya Horiguchi , Christoph Lameter , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Zhang Yanfei , Joonsoo Kim From: Naoya Horiguchi Let's add a comment about where the failed page goes to, which makes code more readable. Acked-by: Christoph Lameter Signed-off-by: Naoya Horiguchi Signed-off-by: Joonsoo Kim diff --git a/mm/migrate.c b/mm/migrate.c index 3747fcd..c6ac87a 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1123,7 +1123,12 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, nr_succeeded++; break; default: - /* Permanent failure */ + /* + * Permanent failure (-EBUSY, -ENOSYS, etc.): + * unlike -EAGAIN case, the failed page is + * removed from migration page list and not + * retried in the next outer loop. + */ nr_failed++; break; } -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org