From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ee0-f45.google.com (mail-ee0-f45.google.com [74.125.83.45]) by kanga.kvack.org (Postfix) with ESMTP id DFE366B0055 for ; Tue, 3 Dec 2013 03:52:11 -0500 (EST) Received: by mail-ee0-f45.google.com with SMTP id d49so1251714eek.4 for ; Tue, 03 Dec 2013 00:52:11 -0800 (PST) Received: from mx2.suse.de (cantor2.suse.de. [195.135.220.15]) by mx.google.com with ESMTP id l44si2237100eem.145.2013.12.03.00.52.11 for ; Tue, 03 Dec 2013 00:52:11 -0800 (PST) From: Mel Gorman Subject: [PATCH 10/15] mm: numa: Avoid unnecessary work on the failure path Date: Tue, 3 Dec 2013 08:51:57 +0000 Message-Id: <1386060721-3794-11-git-send-email-mgorman@suse.de> In-Reply-To: <1386060721-3794-1-git-send-email-mgorman@suse.de> References: <1386060721-3794-1-git-send-email-mgorman@suse.de> Sender: owner-linux-mm@kvack.org List-ID: To: Alex Thorlton Cc: Rik van Riel , Linux-MM , LKML , Mel Gorman If a PMD changes during a THP migration then migration aborts but the failure path is doing more work than is necessary. Signed-off-by: Mel Gorman --- mm/migrate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/migrate.c b/mm/migrate.c index 3a87511..e429206 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1774,7 +1774,8 @@ fail_putback: putback_lru_page(page); mod_zone_page_state(page_zone(page), NR_ISOLATED_ANON + page_lru, -HPAGE_PMD_NR); - goto out_fail; + + goto out_unlock; } /* @@ -1848,6 +1849,7 @@ out_dropref: } spin_unlock(&mm->page_table_lock); +out_unlock: unlock_page(page); put_page(page); return 0; -- 1.8.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org