From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Dave Hansen <dave@sr71.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
dave.jiang@intel.com, akpm@linux-foundation.org,
dhillf@gmail.com, Mel Gorman <mgorman@suse.de>
Subject: [PATCH] mm: call cond_resched() per MAX_ORDER_NR_PAGES pages copy
Date: Mon, 18 Nov 2013 13:54:01 -0500 [thread overview]
Message-ID: <1384800841-314l1f3e-mutt-n-horiguchi@ah.jp.nec.com> (raw)
In-Reply-To: <1384800714-y653r3ch-mutt-n-horiguchi@ah.jp.nec.com>
In copy_huge_page() we call cond_resched() before every single page copy.
This is an overkill because single page copy is not a heavy operation.
This patch changes this to call cond_resched() per MAX_ORDER_NR_PAGES pages.
Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
---
mm/migrate.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index cb5d152b58bc..661ff5f66591 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -454,7 +454,8 @@ static void __copy_gigantic_page(struct page *dst, struct page *src,
struct page *src_base = src;
for (i = 0; i < nr_pages; ) {
- cond_resched();
+ if (i % MAX_ORDER_NR_PAGES == 0)
+ cond_resched();
copy_highpage(dst, src);
i++;
@@ -483,10 +484,9 @@ static void copy_huge_page(struct page *dst, struct page *src)
nr_pages = hpage_nr_pages(src);
}
- for (i = 0; i < nr_pages; i++ ) {
- cond_resched();
+ cond_resched();
+ for (i = 0; i < nr_pages; i++)
copy_highpage(dst + i, src + i);
- }
}
/*
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-11-18 18:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 22:55 [v3][PATCH 0/2] v3: fix hugetlb vs. anon-thp copy page Dave Hansen
2013-11-15 22:55 ` [v3][PATCH 1/2] mm: hugetlbfs: Add VM_BUG_ON()s to catch non-hugetlbfs pages Dave Hansen
2013-11-15 22:55 ` [v3][PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page Dave Hansen
2013-11-18 10:32 ` Mel Gorman
2013-11-18 18:51 ` [v3][PATCH 2/2] mm: thp: give transparent hugepage code aseparate copy_page Naoya Horiguchi
2013-11-18 18:54 ` Naoya Horiguchi [this message]
2013-11-18 19:02 ` [PATCH] mm: call cond_resched() per MAX_ORDER_NR_PAGES pages copy Dave Hansen
2013-11-18 20:20 ` Naoya Horiguchi
2013-11-18 20:48 ` Dave Hansen
2013-11-18 21:56 ` Naoya Horiguchi
2013-11-18 22:29 ` Dave Hansen
2013-11-19 0:34 ` Naoya Horiguchi
2013-11-18 19:23 ` [v3][PATCH 0/2] v3: fix hugetlb vs. anon-thp copy page Jiang, Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384800841-314l1f3e-mutt-n-horiguchi@ah.jp.nec.com \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=dave.jiang@intel.com \
--cc=dave@sr71.net \
--cc=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox