From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by kanga.kvack.org (Postfix) with ESMTP id D074D6B016A for ; Thu, 7 Nov 2013 11:55:18 -0500 (EST) Received: by mail-pa0-f41.google.com with SMTP id rd3so891179pab.28 for ; Thu, 07 Nov 2013 08:55:18 -0800 (PST) Received: from psmtp.com ([74.125.245.204]) by mx.google.com with SMTP id z1si3237648pbw.189.2013.11.07.08.55.14 for ; Thu, 07 Nov 2013 08:55:15 -0800 (PST) Subject: Re: [PATCH v4 5/5] MCS Lock: Allow architecture specific memory barrier in lock/unlock From: Tim Chen In-Reply-To: <20131107074038.GB26654@gmail.com> References: <1383787620.11046.368.camel@schen9-DESK> <20131107074038.GB26654@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 07 Nov 2013 08:55:11 -0800 Message-ID: <1383843311.11046.370.camel@schen9-DESK> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Ingo Molnar Cc: Ingo Molnar , Andrew Morton , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm , linux-arch@vger.kernel.org, Linus Torvalds , Waiman Long , Andrea Arcangeli , Alex Shi , Andi Kleen , Michel Lespinasse , Davidlohr Bueso , Matthew R Wilcox , Dave Hansen , Peter Zijlstra , Rik van Riel , Peter Hurley , "Paul E.McKenney" , Raghavendra K T , George Spelvin , "H. Peter Anvin" , Arnd Bergmann , Aswin Chandramouleeswaran , Scott J Norton , Will Deacon , "Figo.zhang" On Thu, 2013-11-07 at 08:40 +0100, Ingo Molnar wrote: > * Tim Chen wrote: > > > This patch moves the decision of what kind of memory barriers to be > > used in the MCS lock and unlock functions to the architecture specific > > layer. It also moves the actual lock/unlock code to mcs_spinlock.c > > file. > > > > A full memory barrier will be used if the following macros are not > > defined: > > 1) smp_mb__before_critical_section() > > 2) smp_mb__after_critical_section() > > > > For the x86 architecture, only compiler barrier will be needed. > > > > Acked-by: Tim Chen > > This should be Signed-off-by and should come last in the SOB chain, as you > are the person passing the patch along. > > > Signed-off-by: Waiman Long > > I think you lost a: > > From: Waiman Long > > from the beginning of the mail, because right now if your patch is applied > it will credit you with being the author - that wasn't the intention, > right? Will fix that. Thanks. Tim > > Thanks, > > Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org