From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5931C67861 for ; Mon, 8 Apr 2024 08:15:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3719C6B0083; Mon, 8 Apr 2024 04:15:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F8BB6B008C; Mon, 8 Apr 2024 04:15:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1734C6B0092; Mon, 8 Apr 2024 04:15:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E91AC6B008C for ; Mon, 8 Apr 2024 04:15:51 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A4A9A1607AC for ; Mon, 8 Apr 2024 08:15:51 +0000 (UTC) X-FDA: 81985656102.07.A56C2D1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 8DB7D10001B for ; Mon, 8 Apr 2024 08:15:48 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ih43xdCn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712564148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6r1tbKfHyOlCHMHOLN4//rRsziNLaiDaOQ/a7cTjTEk=; b=ENGT7Xq4V3+fteuHN35RoaWnz5EHXPlRA2qjfXHtUXmGumUa+mRDFMuZtO6b9CYH7zczIi 7WOEUjd957N2ZxzPrJgdnHx+5TtmwqEj7lx7wPXyBuNM8v1DtI1l2UoQDt6aNz84X9sWj+ oNV0dVCy64yDLBj27gXALxVt1FAycdw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ih43xdCn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712564148; a=rsa-sha256; cv=none; b=hKyuyBCvNs+1wmmOgvn1V+jALA8peRsrR1JEYQk/q96xxTmwoUceliscsylhwlwz9mLgyu M8SLTHWSViEBM4pgy3uoFd0LFFVXQ3oAdplB9QX7rVOW4zc1itU6HPjHarccseJbuLM9vz QLEYU0fii+5wTeu8BV2nbEadYK868JY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712564147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6r1tbKfHyOlCHMHOLN4//rRsziNLaiDaOQ/a7cTjTEk=; b=ih43xdCn+bWlecvNK9yqnNaZO7RswzqlIounFqU/bPANGUJS/PNjagqf4jjJGMn+SXMSee YJz8i31alG8Q5ac9nBE4b2GeXoDnseHJTrF9LDmueAtqDD2FONTf4/OQFCoNtgO0UffKDw 0gnGdw+zZMVJGEBdKaJHnAiMY559CHw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-199-Tq1SXCJlM_yAMaXlf9VbtQ-1; Mon, 08 Apr 2024 04:15:46 -0400 X-MC-Unique: Tq1SXCJlM_yAMaXlf9VbtQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-41663448bcbso3927025e9.1 for ; Mon, 08 Apr 2024 01:15:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712564145; x=1713168945; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6r1tbKfHyOlCHMHOLN4//rRsziNLaiDaOQ/a7cTjTEk=; b=KuSd7Z9M7IkhHQQ35ui2CEMdBYJMfrjC4IUF/mXnvYuVq2y0HyZyxm2q/nJJACpkPj GYpvQu2LmGZ6F3/reoF+FjEIFZ3ZtqoTc+odCaFQsvVubGKaOr+hA2L7snjyapSrr2Ns 8WCL3OkzCnmkUfE7TXgNHAlXMSiPuE0+BPJzp2yrfBX5hbEkn1Ke4GB2bqaQxeCDtoPj D2Y1uXZLRtf7jKSvB5MKhdFm/9BxznG0N3prblosYOEy9g1/+FtjKoYfoMcImPEXsyW0 UbNkq4ni6tK3OPS0CfzxfHvTEpL73MRL4WDQFHbImJEUIVM98ulMru4bY+q4S3dxTBcV epsA== X-Gm-Message-State: AOJu0YxOIKBaF2M85oRXeeUhnmFYsfVEhvVewIg8XvLMA/pO5JSN7HLj zHIdInebO4cEvBq/Z4cMwa6wHs163oTCFbXALf6hrV0d83om9oxBcSvX4oFAIVGEtemYE33WrKS 1C31t04poBHmXsPYrSm3z2uJEAuBMiX6KAwOIrqbgdOTmhJle X-Received: by 2002:a05:600c:470d:b0:416:6adf:fe44 with SMTP id v13-20020a05600c470d00b004166adffe44mr2013270wmo.17.1712564145191; Mon, 08 Apr 2024 01:15:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGscbuDcN414Ijs18OJVVR6dWLGPchNaRnBebcg2NHYd+HPoPdmnfIaWHeYZklwWDzwn/6p2Q== X-Received: by 2002:a05:600c:470d:b0:416:6adf:fe44 with SMTP id v13-20020a05600c470d00b004166adffe44mr2013243wmo.17.1712564144789; Mon, 08 Apr 2024 01:15:44 -0700 (PDT) Received: from ?IPV6:2003:cb:c718:1300:9860:66a2:fe4d:c379? (p200300cbc7181300986066a2fe4dc379.dip0.t-ipconnect.de. [2003:cb:c718:1300:9860:66a2:fe4d:c379]) by smtp.gmail.com with ESMTPSA id t14-20020a5d6a4e000000b0033b48190e5esm8333086wrw.67.2024.04.08.01.15.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 01:15:44 -0700 (PDT) Message-ID: <13833f69-0f32-4590-9188-a7fb04e31c45@redhat.com> Date: Mon, 8 Apr 2024 10:15:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm/hugetlb: pass correct order_per_bit to cma_declare_contiguous_nid To: Frank van der Linden Cc: linux-mm@kvack.org, muchun.song@linux.dev, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Roman Gushchin References: <20240404162515.527802-1-fvdl@google.com> <20240404162515.527802-2-fvdl@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 8DB7D10001B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 1o6nyiadpf3dt77ee9wr8ukn834genp7 X-HE-Tag: 1712564148-503787 X-HE-Meta: U2FsdGVkX18GHbFQiPNT7Dz8Vn4KyC9qK8465xxJfBx3VgvU/woEnevOeH+bb2N9/OlM1LKE5TOlEHcXUdp9OXe0agMJ/mRkpcoRoCozn2yoDIEu6m4JjRt3RI+oHvrQ8dQS2+YvvY5tdo8brg18AMPF06B75cLK10C17Akaj/GUmfxuFwDVs43aJ3FtkrvOwxVfVC9OMuYxmjxaR1GmTue5GSUf1R2+FaKWNdaAX5TK+h/ybfTOIV8JiTWUihDn4DPWzL+ZCbuU9gkhifYpoY38u8G1Kbo5NjFFDQqJQft8wyRmXIkKcdTu5O1qCp2WjDxZlH+vct+D9FR9Rt0u5qqCw6QL7m1ULJBpwFJ61Njqs9JtkRYeOkZEwSis41K8ZYUxL30pbyPmS82s3bw4ZNBZu14YhQv8kRbgFrHO8o6r3t66tm5ySPAvmokPZ8KjEmIDFtPpj2iHX41yJ+GKkkulZIPbUWkFbTOcXQtJOWoegCnUXzK3l3PtdTKXtsWx8+I0oq7M54VCZIGerQ1oxSkJEul0e1lJbl98JvvnLAsr22BGBtC1GRrOyX9IEUsdNOf9Xr/gGqcCCZVZMyCORe2bW060MenDpKEyO/e67rnpCkDuB2b0lDNXUfUwK/sDIr/90pyKv+NVwj1Kdy9kmbU+Ih8NTIvrhp9oz86QC8LpR1DfF9ogLO1kqtpNd4rEsESHCjSef6XnrjjBrTtAjl+gDOnTGn+OaysLE5M6hEwSBQ540k68118jbZkN3INGYCaqaSOntuy5gs6KukL/5V0ezex+mwDd3J4OxNN7wR2Z927tA0Fw1iYa29QlDmhcE50QWI8P6Ov7oAXh/Ts90nQcXnDyullIz7xl5LH4hotE5a6Axp3ag8f2n6ajZnKC77qGTpj6SwaUxTgHFwSWkLDiueeSj+K+7zqmJ3Bfx+98DaVoDRqHl+SMDREqTaMQYnEo9EfDmHpyCEkt1QL pX2KKcNp ZiZ8RyHHllAiYtY+Vh6mnGSETsWyP3QifLywCLMjw/2Rm0uML8ymbj8VyI4nRGeUuzaAM33C6oT7qs0qjmNCmDxx8vzgXmggCcjYN7gq+GY3ScScHORzWVTpCJoqooTMGqrtnmCsjNXUoSNgTW5nOqI0CzSl+oUF12iyGhwHa80g1lHPJdilfBBr1zXM+hnqbtbljcgReOnvSZ7o3lqGc6pPWvw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.04.24 23:44, Frank van der Linden wrote: > On Thu, Apr 4, 2024 at 1:13 PM David Hildenbrand wrote: >> >> On 04.04.24 18:25, Frank van der Linden wrote: >>> The hugetlb_cma code passes 0 in the order_per_bit argument to >>> cma_declare_contiguous_nid (the alignment, computed using the >>> page order, is correctly passed in). >>> >>> This causes a bit in the cma allocation bitmap to always represent >>> a 4k page, making the bitmaps potentially very large, and slower. >>> >>> So, correctly pass in the order instead. >>> >>> Signed-off-by: Frank van der Linden >>> Cc: Roman Gushchin >>> Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma") >> >> It might be subopimal, but do we call it a "BUG" that needs "fixing". I >> know, controversial :) >> >>> --- >>> mm/hugetlb.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >>> index 23ef240ba48a..6dc62d8b2a3a 100644 >>> --- a/mm/hugetlb.c >>> +++ b/mm/hugetlb.c >>> @@ -7873,9 +7873,9 @@ void __init hugetlb_cma_reserve(int order) >>> * huge page demotion. >>> */ >>> res = cma_declare_contiguous_nid(0, size, 0, >>> - PAGE_SIZE << HUGETLB_PAGE_ORDER, >>> - 0, false, name, >>> - &hugetlb_cma[nid], nid); >>> + PAGE_SIZE << HUGETLB_PAGE_ORDER, >>> + HUGETLB_PAGE_ORDER, false, name, >>> + &hugetlb_cma[nid], nid); >>> if (res) { >>> pr_warn("hugetlb_cma: reservation failed: err %d, node %d", >>> res, nid); >> >> ... I'm afraid this is not completely correct. >> >> For example, on arm64, HUGETLB_PAGE_ORDER is essentially PMD_ORDER. >> >> ... but we do support smaller hugetlb sizes than that (cont-pte hugetlb >> size is 64 KiB, not 2 MiB -- PMD -- on a 4k kernel) > > Right, smaller hugetlb page sizes exist. But, the value here is not > intended to represent the minimum hugetlb page size - it's the minimum > hugetlb page size that we can demote a CMA-allocated hugetlb page to. > See: > > a01f43901cfb ("hugetlb: be sure to free demoted CMA pages to CMA") > > So, this just restricts demotion of the gigantic, CMA-allocated pages > to HUGETLB_PAGE_ORDER-sized chunks. Right, now my memory comes back. In v1 of that patch set, Mike did support denoting to any smaller hugetlb order. And because that smallest hugetlb order is not known when we call cma_declare_contiguous_nid(), he used to pass "0" for the order. In v2, he simplifed that, though, and limited it to HUGETLB_PAGE_ORDER. He didn't update the order here, though. Acked-by: David Hildenbrand Note that I don't think any of these patches are CC-stable material. -- Cheers, David / dhildenb