From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A686AC678DC for ; Wed, 11 Jun 2025 13:31:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4763D6B008A; Wed, 11 Jun 2025 09:31:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44EA76B008C; Wed, 11 Jun 2025 09:31:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33D216B0092; Wed, 11 Jun 2025 09:31:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 12F836B008A for ; Wed, 11 Jun 2025 09:31:39 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7E8D41A0D74 for ; Wed, 11 Jun 2025 13:31:38 +0000 (UTC) X-FDA: 83543207076.02.C2524B2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id DCED18000B for ; Wed, 11 Jun 2025 13:31:35 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b4BhQwPV; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749648696; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LEkyC126nnamiGOnit+T/Tzx8cqMJmlYY+QH4KRlOVY=; b=QHsv4BQnizziDOe7dBl+BtG9JgkUaHZ2hdsdxc8StWel0WgFmcwTMGoqf2CT3qMgBpPWIf cTzItYKagC45fbXe1Q7PXc3G9aA5ZA/BCUcukwTTiEECuiLxs56tJlk/UOJuXt1NJe/uHg yrA4pIFynkBwTwMAiKU2+SgYy9vET98= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749648696; a=rsa-sha256; cv=none; b=ccEQCuYfsI1OSS5H0J9lO5Ht/tsGnPWYJPA+xJUy2pZ06BgEVUVZVVS3+v4KYrOM9FE22Z UPHjXTakTf/g7gQdOsFZfEZYtGTRXZZda0GM4N6sV/kIXDe37Qo6kH/qtfEwF0iamy0ZzD pUhqm5WOc+HkgA4q9AdR0+NTIYHuVlg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b4BhQwPV; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749648695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LEkyC126nnamiGOnit+T/Tzx8cqMJmlYY+QH4KRlOVY=; b=b4BhQwPVECu+v0haC2VHtXajJXKOcohEr0/XQXc8V9TMQxJF9DeHRDllPFQDdE5oelNuqf tsazymwbZqmSwaRSo5LlwGWLUv4WJjFy6PCa/Y7N9TBHDIENuRD1yusT9UiTtE6vG7C8vw ChXLHVDYCGOJnC+af9xW6d2E+nWORZA= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-25-QRvLmLdjNZCPKrGq9fpjRw-1; Wed, 11 Jun 2025 09:31:32 -0400 X-MC-Unique: QRvLmLdjNZCPKrGq9fpjRw-1 X-Mimecast-MFC-AGG-ID: QRvLmLdjNZCPKrGq9fpjRw_1749648691 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4a581009dc5so14553581cf.0 for ; Wed, 11 Jun 2025 06:31:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749648691; x=1750253491; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LEkyC126nnamiGOnit+T/Tzx8cqMJmlYY+QH4KRlOVY=; b=wTBaNybfXlFgn8TGOOmAIsjG7vCt0qgH82CbvwceP+cOBsGFYY/MMlhcVKxPNFGt9A 5XIX3FZ3crAy0OwWVkithZBR6C2G+BpGY1+ofXy1GzldgNLbnqqkDRp86uKWfekJour/ M7dbZ4FErdaNHH0DEhwtC6ydIQShZ7n9mZBt+Z4CpJgpFC/T10+bmr8elCA5bCYzGicn 62EJOhIXATTnlZw0Tv/u7nnbt7PBgSorbiWQuC0KQez4ghbSiUQFLrPzxucz1XtTrPU7 7aLv/bl+8lCNvV4FrorOuOkByw6tKyBT+Hw0Y7Lig2HRfARPaXlfZzdKyKWIVTx3J4SS uSlg== X-Forwarded-Encrypted: i=1; AJvYcCXc/ba4J0gJjGfvYYTdgQDmBOUkdUqRo62y72iHsdsgrlFWg0nFfx08GV9tzJx1zOqnizmsASefyg==@kvack.org X-Gm-Message-State: AOJu0YwV2ONBnowTaF4Q9eg/SJ7G/LajcCP6zS3JSaSJXE6J2jxg7+ew o6YtQ+xWhU4nw1dBX5VO/+TNq8eNyz0YOmXWcBS7KTNARStYy+/b4V08TveT28J+zILty3bRsFn W4NMCWACC2W7DCPeq5beZhSbZsTInL92hFcYQFW6CmE6pA6NyF9wv X-Gm-Gg: ASbGnct2ogOj/QYsa3svAuILm21ciac9lTXemoPjfew47tJXW50ddlcVDof3TT30N/V NxCTR12OztYqNMYE2vZskPpXxfY9tosq55ewscLHbTcrxpb6SMk5ZjHIYUIdQbxYTlLAQ1X/rta Bkn2aQHsThrD4f0co0pNYx7ORsoAFtIvMXfIDto+8SV3kw0n5fD1Dw4e19iPH2Auv6RTDEV6Y2Y h7Il9l9lCIexL/PlPrffDjxRY0br6wPrX3Wmh5AgK0cwR9Vo/Ru1rlbcdnI/DwIxXgh+OVolw/u DaK7kesi9Be6DZbXmksX2c25vIMg1JzFPO6UWvxxis2T X-Received: by 2002:a05:622a:400c:b0:4a5:8387:8b8d with SMTP id d75a77b69052e-4a713c8cda0mr58422391cf.21.1749648691403; Wed, 11 Jun 2025 06:31:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGcWcUNhxwdVjyDdqrdT3YUHh0qOifpmVI+UN68rcwEig23gtiiO+VGvBJ4PvocRgw6iK6kgw== X-Received: by 2002:a05:622a:400c:b0:4a5:8387:8b8d with SMTP id d75a77b69052e-4a713c8cda0mr58421651cf.21.1749648690697; Wed, 11 Jun 2025 06:31:30 -0700 (PDT) Received: from [10.32.64.156] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a61116b81asm89089271cf.21.2025.06.11.06.31.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jun 2025 06:31:30 -0700 (PDT) Message-ID: <13813741-d969-45a6-bd8e-163d71078b00@redhat.com> Date: Wed, 11 Jun 2025 15:31:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] mm: Call pointers to ptes as ptep To: Lorenzo Stoakes , Dev Jain Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, peterx@redhat.com, ryan.roberts@arm.com, mingo@kernel.org, libang.li@antgroup.com, maobibo@loongson.cn, zhengqi.arch@bytedance.com, baohua@kernel.org, anshuman.khandual@arm.com, willy@infradead.org, ioworker0@gmail.com, yang@os.amperecomputing.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, hughd@google.com References: <20250610035043.75448-1-dev.jain@arm.com> <20250610035043.75448-2-dev.jain@arm.com> <9cbaf817-7a33-42d8-ba39-fa1b448266f6@redhat.com> <574a1c6f-f542-408e-8d26-728749892b1c@arm.com> <5d1a561b-cf29-4527-b695-90ae9e5bd696@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <5d1a561b-cf29-4527-b695-90ae9e5bd696@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Q6mCf32yMlGMe5ZDsLo1xxC1wO5lL4_ivndU4MBXheY_1749648691 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DCED18000B X-Stat-Signature: nhzsth1n67jdirjtwddxnndzeditmnq9 X-HE-Tag: 1749648695-605228 X-HE-Meta: U2FsdGVkX1/17urjYNNiKUR/fgGuqKhW5NSVhlpq7lRejYRRgeqGNkPsZv/hkERe1nrG+HtDzDkAFKvAstQR6dP71asAxXWj/vdlMVFSspMhNG6QETbq5ezMjBZm5biWtQrgSI68gxrSV5jd9b5gJrtFGxEfo2rUV1LD4kz+GTOr0O6lJ0S7JWRN58neov/YcY8rpz+ZWEQ92w/rcCl4AYHnrOsp1vMp0apKrnlHxm8cCMUHolRTtfw4UR3ILywKAIKD5Y0/z8OEgmImDm6d8CXhJ9O3ZzEP7NBuDjTsP5UZMpAGGFydGSZFnwcKu2155KrGuHxkWD6ZHzp/gTR+2aFQkLFkSRbStkxHjrN+awE1dfuJxUnwL9IrFhRbPxpkqMPdM243Z/BVsh+V++SsDbfL59zPDDC0xHjcf77DavntkX0DDRl9EX3bacO02vWbqh0aOcQk5Klrx9JBlNsVr7fTGwVc8WIgMDcU0PLyccicfrCU07yN5VkKeUYcddi38ZXIA/KgZvJSUwj0Z4R5TlZG4Sx4Z9to8SEKn5Zxje3kUbhBriSF8mFEsInp7uuGgIfqD4nwd5qH7voKJzVmGYtTtWEIDa8jbsxNGSjjZo9gOScs0Kf/f/mN1Onr2uFw4Q9V/I+J+Vwz4MD9/TjAmnzqKalgVmqynjtuE6HzTyYmnXZX7shUZbt7V03ynWEOgulxIXFOpzcpbBtlcY8hzzapviiOa5yajRYYikITT5BxcstUS6b9w8v/veKTcvEqmYelKf6/oLl+Fc38ydQVwM95bc5MuWumhg2iTf924bHuivI1RDgKnGCTXY0VJandMNEw/QZyW9jKfalAypu9DiwQN01WS5IYFwBUuKL16Gv4sQhEpsHdeFi+myN0I1rt4rZCKq1BoOmeKxe/M+ukNqYryzi1prhRfYxmNY7Vmoc7YG+KRZiDADikLq8pjdWZQo3otZ8GMMOVSn+acky LIZVJRBU rh/4iwLXeweLkwa+3EB0AeCxcbwOyl5lWU22MSCLuDke9ONCIzfWr+cGBEWmiFW36CzC9Gu05NWUO6JyGrbM+SC0+CJwZtR9BjxLg3v34IVhvomwLEpqqPaQe0DNAR6SVQ/g24+2YTDw7bGtVMMlTTIqdxx0gVJkRZq1BFLNk1NHlAmIqB+8zbG0qchQ0oPMWsvRYia041xuRq+gBI8lQszNyj4BIXWYnPlEGvJQIWAaF+iYVZfdHek4S5FcSFxwdJyF48/FLmsnHpGU9RfFWasmXpOrLyaxZJsnz9/rXx4BAJzutMlFb6uNLOBjyCYCFGyz2LYD9IhJ5TJDmoeBlOQyTcjAZpogHWAJSOqApB4Chma5gaNwmI4MqVgCo4XKggz5KORzSLcLaftALRsNO4xJK9B5ODkExCqgiorXbsxnxmjYYHDb5aKBKA1J0CBkDkCVYk4MlqotMSFnLTTnmZUMHz3AYRxWzw58V8OLoiV38GI4zVhLVTVBT81AQrA06cvK1j8PHqjL8KktLq4VlvKVmBbKkbf19iAW/6YAR9Da9tnY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.06.25 15:29, Lorenzo Stoakes wrote: > On Wed, Jun 11, 2025 at 06:55:28PM +0530, Dev Jain wrote: >> >> On 11/06/25 6:53 pm, David Hildenbrand wrote: >>> On 10.06.25 05:50, Dev Jain wrote: >>>> Avoid confusion between pte_t* and pte_t data types by suffixing pointer >>>> type variables with p. No functional change. >>>> >>>> Reviewed-by: Barry Song >>>> Reviewed-by: Anshuman Khandual >>>> Reviewed-by: Lorenzo Stoakes >>>> Signed-off-by: Dev Jain >>>> --- >>>>   mm/mremap.c | 31 ++++++++++++++++--------------- >>>>   1 file changed, 16 insertions(+), 15 deletions(-) >>>> >>>> diff --git a/mm/mremap.c b/mm/mremap.c >>>> index 60f6b8d0d5f0..180b12225368 100644 >>>> --- a/mm/mremap.c >>>> +++ b/mm/mremap.c >>>> @@ -176,7 +176,8 @@ static int move_ptes(struct >>>> pagetable_move_control *pmc, >>>>       struct vm_area_struct *vma = pmc->old; >>>>       bool need_clear_uffd_wp = vma_has_uffd_without_event_remap(vma); >>>>       struct mm_struct *mm = vma->vm_mm; >>>> -    pte_t *old_pte, *new_pte, pte; >>>> +    pte_t *old_ptep, *new_ptep; >>>> +    pte_t pte; >>> >>> Could have left that on the same line ... >> >> AFAIR Lorenzo had insisted on moving that to a new line. > > Yeah, not a fan of having pointer and non-pointer types declared on same line. Apparently I am for such simple things. The joy of not having a common coding style. :) Anyhow, I don't really care, just something I noticed ... -- Cheers, David / dhildenb