From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) by kanga.kvack.org (Postfix) with ESMTP id AFC666B0031 for ; Fri, 27 Sep 2013 19:16:28 -0400 (EDT) Received: by mail-pd0-f171.google.com with SMTP id g10so3193994pdj.2 for ; Fri, 27 Sep 2013 16:16:28 -0700 (PDT) Message-ID: <1380323662.14046.51.camel@misato.fc.hp.com> Subject: Re: [PATCH v5 5/6] x86, acpi, crash, kdump: Do reserve_crashkernel() after SRAT is parsed From: Toshi Kani Date: Fri, 27 Sep 2013 17:14:22 -0600 In-Reply-To: <5241DB3A.6090002@gmail.com> References: <5241D897.1090905@gmail.com> <5241DB3A.6090002@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Zhang Yanfei Cc: "Rafael J . Wysocki" , lenb@kernel.org, Thomas Gleixner , mingo@elte.hu, "H. Peter Anvin" , Andrew Morton , Tejun Heo , Wanpeng Li , Thomas Renninger , Yinghai Lu , Jiang Liu , Wen Congyang , Lai Jiangshan , isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, Mel Gorman , Minchan Kim , mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, Rik van Riel , jweiner@redhat.com, prarit@redhat.com, "x86@kernel.org" , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux MM , linux-acpi@vger.kernel.org, imtangchen@gmail.com, Zhang Yanfei On Wed, 2013-09-25 at 02:34 +0800, Zhang Yanfei wrote: > From: Tang Chen > > Memory reserved for crashkernel could be large. So we should not allocate > this memory bottom up from the end of kernel image. > > When SRAT is parsed, we will be able to know whihc memory is hotpluggable, > and we can avoid allocating this memory for the kernel. So reorder > reserve_crashkernel() after SRAT is parsed. > > Acked-by: Tejun Heo > Signed-off-by: Tang Chen > Reviewed-by: Zhang Yanfei > --- > arch/x86/kernel/setup.c | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index f0de629..36cfce3 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -1120,8 +1120,6 @@ void __init setup_arch(char **cmdline_p) > acpi_initrd_override((void *)initrd_start, initrd_end - initrd_start); > #endif > > - reserve_crashkernel(); > - > vsmp_init(); > > io_delay_init(); > @@ -1136,6 +1134,12 @@ void __init setup_arch(char **cmdline_p) > initmem_init(); > memblock_find_dma_reserve(); > > + /* > + * Reserve memory for crash kernel after SRAT is parsed so that it > + * won't consume hotpluggable memory. > + */ > + reserve_crashkernel(); Out of curiosity, is there any particular reason why it is moved after memblock_find_dma_reserve(), not initmem_init()? Thanks, -Toshi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org