linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Douglas Anderson <dianders@chromium.org>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
	Linux Memory Management List <linux-mm@kvack.org>,
	Neil Armstrong <neil.armstrong@linaro.org>
Subject: [linux-next:master 4298/8232] drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c:366 sharp_panel_remove() error: we previously assumed 'sharp' could be null (see line 365)
Date: Mon, 1 Jul 2024 17:45:20 +0200	[thread overview]
Message-ID: <137ec596-b946-4076-a0c4-30f3b3285e36@suswa.mountain> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   0fc4bfab2cd45f9acb86c4f04b5191e114e901ed
commit: d7d473d8464e7b9931c0b19f68ea0df807e01b4c [4298/8232] drm/panel: sharp-lq101r1sx01: Don't call disable at shutdown/remove
config: x86_64-randconfig-161-20240626 (https://download.01.org/0day-ci/archive/20240626/202406261525.SkhtM3ZV-lkp@intel.com/config)
compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202406261525.SkhtM3ZV-lkp@intel.com/

smatch warnings:
drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c:366 sharp_panel_remove() error: we previously assumed 'sharp' could be null (see line 365)

vim +/sharp +366 drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c

79abca2b399009 Uwe Kleine-König 2022-07-08  355  static void sharp_panel_remove(struct mipi_dsi_device *dsi)
1976dbca047ed7 Thierry Reding   2014-08-01  356  {
1976dbca047ed7 Thierry Reding   2014-08-01  357  	struct sharp_panel *sharp = mipi_dsi_get_drvdata(dsi);
1976dbca047ed7 Thierry Reding   2014-08-01  358  	int err;
1976dbca047ed7 Thierry Reding   2014-08-01  359  
1976dbca047ed7 Thierry Reding   2014-08-01  360  	err = mipi_dsi_detach(dsi);
1976dbca047ed7 Thierry Reding   2014-08-01  361  	if (err < 0)
1976dbca047ed7 Thierry Reding   2014-08-01  362  		dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err);
1976dbca047ed7 Thierry Reding   2014-08-01  363  
d7d473d8464e7b Douglas Anderson 2024-06-04  364  	/* only detach from host for the DSI-LINK2 interface */
1976dbca047ed7 Thierry Reding   2014-08-01 @365  	if (!sharp)

Reversed if statement?

d7d473d8464e7b Douglas Anderson 2024-06-04 @366  		sharp_panel_del(sharp);
1976dbca047ed7 Thierry Reding   2014-08-01  367  }

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



             reply	other threads:[~2024-07-01 15:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 15:45 Dan Carpenter [this message]
2024-07-08 17:54 ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=137ec596-b946-4076-a0c4-30f3b3285e36@suswa.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=dianders@chromium.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=neil.armstrong@linaro.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox