From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EC5C77B72 for ; Mon, 17 Apr 2023 07:19:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63E4C8E0002; Mon, 17 Apr 2023 03:19:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EEA38E0001; Mon, 17 Apr 2023 03:19:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B71E8E0002; Mon, 17 Apr 2023 03:19:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3CBEA8E0001 for ; Mon, 17 Apr 2023 03:19:10 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 048DDABF78 for ; Mon, 17 Apr 2023 07:19:09 +0000 (UTC) X-FDA: 80690031660.06.1306672 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id D031C1C000D for ; Mon, 17 Apr 2023 07:19:07 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M8jzH3RH; spf=pass (imf21.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681715948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/ywuq69NDoGYBzQBvoab/Vrezh1wLVkJwTzR8zqW+Rk=; b=5bZt20vY1QoFfRGY2YhpOpcSgRcz2/V9ywv0fU1LGe8x73F0J+ISrnygXKHDf8PIHtsbAv WlXoAk8056uh1CkNr2nK5pLSbAEXfGzbpwG8T+1yHl8s5Fk+mX9pp1Eb3L7Rb7j2YKAVtM GA13zWKDpYOb+xptVbN9uDItk4CtsxQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M8jzH3RH; spf=pass (imf21.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681715948; a=rsa-sha256; cv=none; b=BATrd1dBwW38lIA4nAf99nNT4yMYyaaK9HZMyp0nWg4I3ebDkNbVm8l1q+CbHF6wa+cVWX d1WjNPVtWibmg3ccuZqAH3qSLNXQeBl5H2QoFtztaZtp0/5LJ3jk2baArfE8HgHdlkDhIe 5fM1HB4vLT+sAhG4Uys84U4AhjeSggo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681715947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/ywuq69NDoGYBzQBvoab/Vrezh1wLVkJwTzR8zqW+Rk=; b=M8jzH3RHUhYqkTyi8pE7nMycdocmwWio1gA+ImQInXuQ4eQx2Oo3m/iBNayTNIVqraSMDI 96ODaqlNG+SN1Sm8qb+T6eh6IqSuWodNk7LG3KTdw2/RfBYmqDwd9SYJJHVeGd7udCRcUj QXI4PXareBamcQ1l3Nk8gis1iQlRYss= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-22-GuH0lb_pPn6g73_mhRP5ZQ-1; Mon, 17 Apr 2023 03:18:59 -0400 X-MC-Unique: GuH0lb_pPn6g73_mhRP5ZQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 570C68996E8; Mon, 17 Apr 2023 07:18:59 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1602140C6E6E; Mon, 17 Apr 2023 07:18:57 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 In-Reply-To: <2d5fa5e3-dac5-6973-74e5-eeedf36a42b@google.com> References: <2d5fa5e3-dac5-6973-74e5-eeedf36a42b@google.com> To: Hugh Dickins Cc: dhowells@redhat.com, Jens Axboe , Andrew Morton , Matthew Wilcox , Naoya Horiguchi , David Hildenbrand , Yang Shi , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH next] shmem: minor fixes to splice-read implementation MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1379546.1681715874.1@warthog.procyon.org.uk> From: David Howells Date: Mon, 17 Apr 2023 08:18:57 +0100 Message-ID: <1379675.1681715937@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D031C1C000D X-Stat-Signature: 3kybt711eq968qh1jxu1kxipuiir5iem X-Rspam-User: X-HE-Tag: 1681715947-168807 X-HE-Meta: U2FsdGVkX1/4ABHBgX3qj22AD6hvt5RET7ubUugTnkvk2DaDdRpqX7U2KFTcV9Ck0ujmO8EAm0SMUoP5ZJWWhQet3ByVj2wWgFfWp2QxMk7y81fJbIT5AhFZSJPkkt1soiri68oGScJ0K20wYCobkEJPjQZtQerJRw8m5DjUUsaTS5QpV4kQEfn+tVkqfMbsjfsO8qLXpBIVyK1lv3aUSfkOP7ttny7owP7AaZgXJtIByLVPwPCLW6QmdYoqgJAgeaEnrt2y0Y0FWbbZocLqnoRi2exqhwkDBUoEA8bkW18NGiBTsPBQnOngMxq2aMF4DJUXfvg+L/Oe5a8ZmwqX7jW2JvKXYLUwl5M9KodUnFhlhJeyHJPA+i2q3NAOHb3jfAR5jVan2KwERHwgcdSyZzLdfcQjgyxKoARNy3EyQ9WewWL1fdfytArTGirxnbJTR9APHK7DB+Hc0WlmJV5zMPhJovp2bjyOk2PW7OUKNu7UaWUMBJ5C0frAQw+SGEyViNy1F+XqqnmyPR9XbAJdqxumrRmKVoUCWV/bgO6pxMR3b3mGf/9l+2PTeo6KBklw62hhZJs3nDFASuxrI+3o5TBZKIVrb+t8i0D8LmRdTmoUoeXPTF9ss198oDjOWryqUPNzRDV59BaiVDmMryQHgtBcVbPGL8jYQIHVM33dLwSP9s49Gdr/c5EIYRbH/aUwzJt1ULD5unJP77EFdB6mzHW6a+PGxIZBDFiovUwBO7flxxk78AN3sYGsoZ6UfoRNe4DdCm7lun7T9bZVjvJQi+1gc/yzdO/cy+3Up9NFB72l8gm+ZWG174mnzjHzRKJ5CjbdrgOt7N6Q2yYaEqSb9zD20a4FtBWLhhKYEMVMBKK8VREEsiHtyB4P8nkUmQZa8DG9/wruQbrNEx1PtOKhoBrrhGgpWjwmD7Sd9dTA1nxZJ/Y3O2O5TVHc/DJwL7zVMJ7gDuXIZhRQJTwekDD mm7H4rbJ m5Y4kjcJlW+ccePkSyRbvEerpCgBo9JRCl2ushASTtA18oj2y6kBuG3y8mLqww+IZ1eJY88pApSQP7eifTNSMht3F/d9dQY/QCjuywHOR+7zblBM05BqnMxvk/p5iQrJQ+c9M3/VovbYiHmO75IWjMD7ZrnNRFrEJdgagRNwwc3PbC5nVR3OCasirfc6N9MdCasg11wxPuA90xHsP2afJyf/bqE6i4VDKU54t1K1AvWrzIqqt0pZ3Fkhr3g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hugh Dickins wrote: > + if (unlikely(!len)) > + return 0; Should this be done in do_splice_to() instead? Also, is it too late for Jens to fold this into the original patch since it's not upstream yet? Otherwise: Reviewed-by: David Howells