From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx187.postini.com [74.125.245.187]) by kanga.kvack.org (Postfix) with SMTP id F1E8D6B0031 for ; Wed, 11 Sep 2013 09:42:27 -0400 (EDT) Message-ID: <1378906840.3039.0.camel@misato.fc.hp.com> Subject: Re: [PATCH v2] cpu/mem hotplug: Add try_online_node() for cpu_up() From: Toshi Kani Date: Wed, 11 Sep 2013 07:40:40 -0600 In-Reply-To: <522FD64B.8090206@jp.fujitsu.com> References: <1378853258-28633-1-git-send-email-toshi.kani@hp.com> <522FD64B.8090206@jp.fujitsu.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Yasuaki Ishimatsu Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rjw@sisk.pl, kosaki.motohiro@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com On Wed, 2013-09-11 at 11:32 +0900, Yasuaki Ishimatsu wrote: > (2013/09/11 7:47), Toshi Kani wrote: > > cpu_up() has #ifdef CONFIG_MEMORY_HOTPLUG code blocks, which > > call mem_online_node() to put its node online if offlined and > > then call build_all_zonelists() to initialize the zone list. > > These steps are specific to memory hotplug, and should be > > managed in mm/memory_hotplug.c. lock_memory_hotplug() should > > also be held for the whole steps. > > > > For this reason, this patch replaces mem_online_node() with > > try_online_node(), which performs the whole steps with > > lock_memory_hotplug() held. try_online_node() is named after > > try_offline_node() as they have similar purpose. > > > > There is no functional change in this patch. > > > > Signed-off-by: Toshi Kani > > --- > > v2: Added pr_err() in case of NULL pgdat in try_online_node(). > > --- > > Thank you for updating it. It looks good to me. > > Reviewed-by: Yasuaki Ishimatsu Thanks Yasuaki! -Toshi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org