From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Tony Luck <tony.luck@intel.com>,
gong.chen@linux.intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] mm/hwpoison: fix false report 2nd try page recovery
Date: Mon, 02 Sep 2013 14:34:26 -0400 [thread overview]
Message-ID: <1378146866-4o68qbq7-mutt-n-horiguchi@ah.jp.nec.com> (raw)
In-Reply-To: <1378125224-12794-3-git-send-email-liwanp@linux.vnet.ibm.com>
On Mon, Sep 02, 2013 at 08:33:43PM +0800, Wanpeng Li wrote:
> If the page is poisoned by software inject w/ MF_COUNT_INCREASED flag, there
> is a false report 2nd try page recovery which is not truth, this patch fix it
> by report first try free buddy page recovery if MF_COUNT_INCREASED is set.
>
> Before patch:
>
> [ 346.332041] Injecting memory failure at pfn 200010
> [ 346.332189] MCE 0x200010: free buddy, 2nd try page recovery: Delayed
>
> After patch:
>
> [ 297.742600] Injecting memory failure at pfn 200010
> [ 297.742941] MCE 0x200010: free buddy page recovery: Delayed
>
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> ---
> mm/memory-failure.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index b114570..6293164 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1114,8 +1114,10 @@ int memory_failure(unsigned long pfn, int trapno, int flags)
> * shake_page could have turned it free.
> */
> if (is_free_buddy_page(p)) {
> - action_result(pfn, "free buddy, 2nd try",
> - DELAYED);
> + if (flags & MF_COUNT_INCREASED)
> + action_result(pfn, "free buddy", DELAYED);
> + else
> + action_result(pfn, "free buddy, 2nd try", DELAYED);
> return 0;
> }
> action_result(pfn, "non LRU", IGNORED);
> --
> 1.7.5.4
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-02 18:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 12:33 [PATCH 1/4] mm/hwpoison: fix traverse hugetlbfs page to avoid printk flood Wanpeng Li
2013-09-02 12:33 ` [PATCH 2/4] mm/hwpoison: fix miss catch transparent huge page Wanpeng Li
2013-09-02 18:34 ` Naoya Horiguchi
2013-09-02 23:31 ` Wanpeng Li
2013-09-02 23:31 ` Wanpeng Li
2013-09-02 12:33 ` [PATCH 3/4] mm/hwpoison: fix false report 2nd try page recovery Wanpeng Li
2013-09-02 18:34 ` Naoya Horiguchi [this message]
2013-09-02 12:33 ` [PATCH 4/4] mm/hwpoison: fix the lack of one reference count against poisoned page Wanpeng Li
2013-09-02 18:34 ` Naoya Horiguchi
2013-09-02 18:34 ` [PATCH 1/4] mm/hwpoison: fix traverse hugetlbfs page to avoid printk flood Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378146866-4o68qbq7-mutt-n-horiguchi@ah.jp.nec.com \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=gong.chen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox